vrr/Pulse
2
0
Fork 0
mirror of https://github.com/rcourtman/Pulse.git synced 2026-10-03 12:47:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 16

Fix legacy webhook normalization migration proof

Browse source 
Change-source: pulse-maintainer
This commit is contained in:
pulse-triage[bot] 2026-08-27 20:34:14 +01:00
parent f9340e3334
commit 1ccd973050
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/migration/v5_to_v6_test.go
View file

@ -287,14 +287,18 @@ func TestV5GotifyWebhookSurvivesV6LoadAndRestart(t *testing.T) {
loaded, err := v6Persistence.LoadWebhooks()
require.NoError(t, err)
require.Len(t, loaded, 1)
assert.Equal(t, v5Webhooks[0], loaded[0])
// The legacy empty value and the v6 canonical "all" value have identical
// delivery semantics; persistence normalizes the former at its read boundary.
want := v5Webhooks[0]
want.MinimumSeverity = "all"
assert.Equal(t, want, loaded[0])
// A fresh persistence instance models the post-upgrade process restart.
restarted := config.NewConfigPersistence(dataDir)
loadedAfterRestart, err := restarted.LoadWebhooks()
require.NoError(t, err)
require.Len(t, loadedAfterRestart, 1)
assert.Equal(t, v5Webhooks[0], loadedAfterRestart[0])
assert.Equal(t, want, loadedAfterRestart[0])
stored, err := os.ReadFile(filepath.Join(dataDir, "webhooks.enc"))
require.NoError(t, err)