refactor: clean up unused configuration

This commit is contained in:
Carl-Robert Linnupuu 2024-02-07 00:48:35 +02:00
parent 1aac1f1084
commit d0132c6c34
3 changed files with 0 additions and 125 deletions

View file

@ -48,10 +48,8 @@ public class ConfigurationComponent {
private final JBCheckBox autoFormattingCheckBox;
private final JTextArea systemPromptTextArea;
private final JTextArea commitMessagePromptTextArea;
private final JTextArea inlineCompletionPromptTextArea;
private final IntegerField maxTokensField;
private final JBTextField temperatureField;
private final JBTextField inlineDelayField;
public ConfigurationComponent(Disposable parentDisposable, ConfigurationState configuration) {
table = new JBTable(new DefaultTableModel(
@ -109,33 +107,6 @@ public class ConfigurationComponent {
commitMessagePromptTextArea.setLineWrap(true);
commitMessagePromptTextArea.setBorder(JBUI.Borders.empty(8, 4));
inlineCompletionPromptTextArea = new JTextArea(configuration.getInlineCompletionPrompt(), 3,
60);
inlineCompletionPromptTextArea.setLineWrap(true);
inlineCompletionPromptTextArea.setBorder(JBUI.Borders.empty(8, 4));
inlineDelayField = new JBTextField(12);
inlineDelayField.setText(String.valueOf(configuration.getTemperature()));
var inlineDelayFieldValidator = createInlineDelayInputValidator(parentDisposable,
inlineDelayField);
inlineDelayField.getDocument().addDocumentListener(new DocumentListener() {
@Override
public void insertUpdate(DocumentEvent e) {
inlineDelayFieldValidator.revalidate();
}
@Override
public void removeUpdate(DocumentEvent e) {
inlineDelayFieldValidator.revalidate();
}
@Override
public void changedUpdate(DocumentEvent e) {
inlineDelayFieldValidator.revalidate();
}
});
checkForPluginUpdatesCheckBox = new JBCheckBox(
CodeGPTBundle.get("configurationConfigurable.checkForPluginUpdates.label"),
configuration.isCheckForPluginUpdates());
@ -160,15 +131,10 @@ public class ConfigurationComponent {
.addComponent(new TitledSeparator(
CodeGPTBundle.get("configurationConfigurable.section.assistant.title")))
.addComponent(createAssistantConfigurationForm())
.addComponentFillVertically(new JPanel(), 0)
.addComponent(new TitledSeparator(
CodeGPTBundle.get("configurationConfigurable.section.commitMessage.title")))
.addComponent(createCommitMessageConfigurationForm())
.addComponentFillVertically(new JPanel(), 0)
.addComponent(new TitledSeparator(
CodeGPTBundle.get("configurationConfigurable.section.inlineCompletion.title")))
.addComponent(createInlineCompletionConfigurationForm())
.addComponentFillVertically(new JPanel(), 0)
.getPanel();
}
@ -261,27 +227,6 @@ public class ConfigurationComponent {
return form;
}
private JPanel createInlineCompletionConfigurationForm() {
var formBuilder = FormBuilder.createFormBuilder();
addAssistantFormLabeledComponent(
formBuilder,
"configurationConfigurable.section.inlineCompletion.systemPromptField.label",
"configurationConfigurable.section.inlineCompletion.systemPromptField.comment",
JBUI.Panels
.simplePanel(inlineCompletionPromptTextArea)
.withBorder(JBUI.Borders.customLine(
JBUI.CurrentTheme.CustomFrameDecorations.separatorForeground())));
formBuilder.addVerticalGap(8);
addAssistantFormLabeledComponent(
formBuilder,
"configurationConfigurable.section.inlineCompletion.delay.label",
"configurationConfigurable.section.inlineCompletion.delay.comment",
inlineDelayField);
var form = formBuilder.getPanel();
form.setBorder(JBUI.Borders.emptyLeft(16));
return form;
}
private ComponentValidator createTemperatureInputValidator(
Disposable parentDisposable,
JBTextField component) {
@ -309,33 +254,6 @@ public class ConfigurationComponent {
return validator;
}
private ComponentValidator createInlineDelayInputValidator(
Disposable parentDisposable,
JBTextField component) {
var validator = new ComponentValidator(parentDisposable)
.withValidator(() -> {
var valueText = component.getText();
try {
var value = Integer.parseInt(valueText);
if (value <= 0) {
return new ValidationInfo(
CodeGPTBundle.get("validation.error.mustBeGreaterThanZero"),
component);
}
} catch (NumberFormatException e) {
return new ValidationInfo(
CodeGPTBundle.get("validation.error.mustBeNumber"),
component);
}
return null;
})
.andStartOnFocusLost()
.installOn(component);
validator.enableValidation();
return validator;
}
private DefaultTableModel getModel() {
return (DefaultTableModel) table.getModel();
}
@ -362,23 +280,6 @@ public class ConfigurationComponent {
return commitMessagePromptTextArea.getText();
}
public void setInlineCompletionPrompt(String inlineCompletionPrompt) {
inlineCompletionPromptTextArea.setText(inlineCompletionPrompt);
}
public String getInlineCompletionPrompt() {
return inlineCompletionPromptTextArea.getText();
}
public int getInlineDelay() {
return Integer.parseInt(inlineDelayField.getText());
}
public void setInlineDelay(int inlineDelay) {
inlineDelayField.setText(String.valueOf(inlineDelay));
}
public double getTemperature() {
return Double.parseDouble(temperatureField.getText());
}

View file

@ -36,12 +36,9 @@ public class ConfigurationConfigurable implements Configurable {
return !configurationComponent.getTableData().equals(configuration.getTableData())
|| configurationComponent.getMaxTokens() != configuration.getMaxTokens()
|| configurationComponent.getTemperature() != configuration.getTemperature()
|| configurationComponent.getInlineDelay() != configuration.getInlineDelay()
|| !configurationComponent.getSystemPrompt().equals(configuration.getSystemPrompt())
|| !configurationComponent.getCommitMessagePrompt()
.equals(configuration.getCommitMessagePrompt())
|| !configurationComponent.getInlineCompletionPrompt()
.equals(configuration.getInlineCompletionPrompt())
|| configurationComponent.isCheckForPluginUpdates()
!= configuration.isCheckForPluginUpdates()
|| configurationComponent.isCreateNewChatOnEachAction()
@ -60,8 +57,6 @@ public class ConfigurationConfigurable implements Configurable {
configuration.setTemperature(configurationComponent.getTemperature());
configuration.setSystemPrompt(configurationComponent.getSystemPrompt());
configuration.setCommitMessagePrompt(configurationComponent.getCommitMessagePrompt());
configuration.setInlineCompletionPrompt(configurationComponent.getInlineCompletionPrompt());
configuration.setInlineDelay(configurationComponent.getInlineDelay());
configuration.setCheckForPluginUpdates(configurationComponent.isCheckForPluginUpdates());
configuration.setCreateNewChatOnEachAction(
configurationComponent.isCreateNewChatOnEachAction());
@ -79,8 +74,6 @@ public class ConfigurationConfigurable implements Configurable {
configurationComponent.setTemperature(configuration.getTemperature());
configurationComponent.setSystemPrompt(configuration.getSystemPrompt());
configurationComponent.setCommitMessagePrompt(configuration.getCommitMessagePrompt());
configurationComponent.setInlineCompletionPrompt(configuration.getInlineCompletionPrompt());
configurationComponent.setInlineDelay(configuration.getInlineDelay());
configurationComponent.setCheckForPluginUpdates(configuration.isCheckForPluginUpdates());
configurationComponent.setCreateNewChatOnEachAction(
configuration.isCreateNewChatOnEachAction());

View file

@ -2,7 +2,6 @@ package ee.carlrobert.codegpt.settings.configuration;
import static ee.carlrobert.codegpt.completions.CompletionRequestProvider.COMPLETION_SYSTEM_PROMPT;
import static ee.carlrobert.codegpt.completions.CompletionRequestProvider.GENERATE_COMMIT_MESSAGE_SYSTEM_PROMPT;
import static ee.carlrobert.codegpt.completions.CompletionRequestProvider.INLINE_COMPLETION_PROMPT;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.components.PersistentStateComponent;
@ -21,10 +20,8 @@ public class ConfigurationState implements PersistentStateComponent<Configuratio
private String systemPrompt = COMPLETION_SYSTEM_PROMPT;
private String commitMessagePrompt = GENERATE_COMMIT_MESSAGE_SYSTEM_PROMPT;
private String inlineCompletionPrompt = INLINE_COMPLETION_PROMPT;
private int maxTokens = 1000;
private double temperature = 0.1;
private int inlineDelay = 500;
private boolean checkForPluginUpdates = true;
private boolean createNewChatOnEachAction;
private boolean ignoreGitCommitTokenLimit;
@ -65,22 +62,6 @@ public class ConfigurationState implements PersistentStateComponent<Configuratio
this.commitMessagePrompt = commitMessagePrompt;
}
public String getInlineCompletionPrompt() {
return inlineCompletionPrompt;
}
public void setInlineCompletionPrompt(String inlineCompletionPrompt) {
this.inlineCompletionPrompt = inlineCompletionPrompt;
}
public int getInlineDelay() {
return inlineDelay;
}
public void setInlineDelay(int inlineDelay) {
this.inlineDelay = inlineDelay;
}
public int getMaxTokens() {
return maxTokens;
}