mirror of
https://github.com/carlrobertoh/ProxyAI.git
synced 2026-04-28 19:52:17 +00:00
fix memory leak in extensions (#229)
This commit is contained in:
parent
7dfe62b96d
commit
99e6c5a733
4 changed files with 25 additions and 16 deletions
|
|
@ -2,6 +2,7 @@ package ee.carlrobert.codegpt.settings;
|
|||
|
||||
import com.intellij.openapi.Disposable;
|
||||
import com.intellij.openapi.options.Configurable;
|
||||
import com.intellij.openapi.util.Disposer;
|
||||
import ee.carlrobert.codegpt.CodeGPTBundle;
|
||||
import ee.carlrobert.codegpt.conversations.ConversationsState;
|
||||
import ee.carlrobert.codegpt.credentials.AzureCredentialsManager;
|
||||
|
|
@ -16,7 +17,9 @@ import javax.swing.JComponent;
|
|||
import org.jetbrains.annotations.Nls;
|
||||
import org.jetbrains.annotations.Nullable;
|
||||
|
||||
public class SettingsConfigurable implements Configurable, Disposable {
|
||||
public class SettingsConfigurable implements Configurable {
|
||||
|
||||
private Disposable parentDisposable;
|
||||
|
||||
private SettingsComponent settingsComponent;
|
||||
|
||||
|
|
@ -35,7 +38,8 @@ public class SettingsConfigurable implements Configurable, Disposable {
|
|||
@Override
|
||||
public JComponent createComponent() {
|
||||
var settings = SettingsState.getInstance();
|
||||
settingsComponent = new SettingsComponent(this, settings);
|
||||
parentDisposable = Disposer.newDisposable();
|
||||
settingsComponent = new SettingsComponent(parentDisposable, settings);
|
||||
return settingsComponent.getPanel();
|
||||
}
|
||||
|
||||
|
|
@ -109,13 +113,12 @@ public class SettingsConfigurable implements Configurable, Disposable {
|
|||
|
||||
@Override
|
||||
public void disposeUIResources() {
|
||||
if (parentDisposable != null) {
|
||||
Disposer.dispose(parentDisposable);
|
||||
}
|
||||
settingsComponent = null;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void dispose() {
|
||||
}
|
||||
|
||||
private boolean isServiceChanged(
|
||||
ServiceSelectionForm serviceSelectionForm,
|
||||
SettingsState settings) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue