vrr/ProxyAI
2
0
Fork 0
mirror of https://github.com/carlrobertoh/ProxyAI.git synced 2026-05-17 03:57:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: make custom openai api key optional (fixes #1218)
Some checks failed
Build / Build (push) Has been cancelled
Details
Build / Verify Plugin (push) Has been cancelled
Details

Browse source
This commit is contained in:
Carl-Robert Linnupuu 2026-05-01 10:58:09 +01:00
parent 04a4efdca0
commit 1082f93174
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/main/kotlin/ee/carlrobert/codegpt/settings/models/LLMClientFactory.kt
View file

@ -140,7 +140,7 @@ object LLMClientFactory {
service<CustomServicesSettings>().customServiceStateForFeatureType(featureType)
val serviceId = state.id ?: error("No custom service configured")
val apiKey = getCredential(CredentialKey.CustomServiceApiKeyById(serviceId))
?: error("No API key found for custom service: $serviceId")
?: ""
when (featureType) {
FeatureType.CODE_COMPLETION -> CustomOpenAILLMClient.fromCodeCompletionSettingsState(

21
src/test/kotlin/ee/carlrobert/codegpt/agent/AgentProviderIntegrationTest.kt
View file

@ -363,6 +363,22 @@ class AgentProviderIntegrationTest : IntegrationTest() {
assertThat(result.events.text.toString()).isEqualTo("Hello from Custom OpenAI")
}
fun testCustomOpenAIAgentAllowsMissingApiKey() {
val customService = configureCustomOpenAIService(apiKey = null)
expectCustomOpenAI(BasicHttpExchange { request ->
assertThat(request.uri.path).isEqualTo("/v1/chat/completions")
assertThat(request.method).isEqualTo("POST")
assertThat(extractPromptText(request)).contains("Say hello without Custom OpenAI auth")
ResponseEntity(customOpenAiResponse("Hello without Custom OpenAI auth"))
})
val result = runAgent(ServiceType.CUSTOM_OPENAI, "Say hello without Custom OpenAI auth")
assertThat(customService.id).isNotBlank()
assertThat(result.output).isEqualTo("Hello without Custom OpenAI auth")
assertThat(result.events.text.toString()).isEqualTo("Hello without Custom OpenAI auth")
}
fun testCustomOpenAIAgentStreamsWhenStoredSelectionUsesModelId() {
val customService = configureCustomOpenAIService(stream = true)
service<ModelSettings>().setModel(
@ -1144,7 +1160,8 @@ class AgentProviderIntegrationTest : IntegrationTest() {
path: String = "/v1/chat/completions",
model: String = "custom-agent-model",
stream: Boolean = false,
useResponsesApiBody: Boolean = false
useResponsesApiBody: Boolean = false,
apiKey: String? = "TEST_API_KEY"
): CustomServiceSettingsState {
val settings = service<CustomServicesSettings>()
val serviceState = CustomServiceSettingsState().apply {
@ -1163,7 +1180,7 @@ class AgentProviderIntegrationTest : IntegrationTest() {
settings.state.services.add(serviceState)
setCredential(
CustomServiceApiKeyById(requireNotNull(serviceState.id)),
"TEST_API_KEY"
apiKey
)
service<ModelSettings>().setModel(
FeatureType.AGENT,