vrr/Fileshed
2
0
Fork 0
mirror of https://github.com/Fade78/Fileshed.git synced 2026-04-28 11:30:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix validation bugs in 4 shed_* functions

Browse source 
1. shed_patch_text: Skip line/end_line/pattern validation when overwrite=True
2. shed_patch_bytes: Only validate offset bounds when position uses it (at/replace)
3. shed_lockedit_overwrite: Add explicit validation that content is not None
4. shed_sqlite: Reject contradictory import_csv + query parameters

These parameters were being validated even when ignored, causing unnecessary
errors when LLMs pass default values like end_line=0 or pattern="".

https://claude.ai/code/session_0126dD9QeVgoFVT7ZBxbnhNM
This commit is contained in:
Claude 2026-01-30 10:59:12 +00:00
parent a4f768709d
commit 914cfd0061
No known key found for this signature in database
1 changed files with 34 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

53
Fileshed.py
View file

@ -3767,26 +3767,28 @@ Note: stdout/stderr are truncated at 50KB to prevent context overflow.
f"Invalid position: {position}. Valid: {', '.join(valid_positions)}{hint}"
)
# Validate line parameter early - line=0 is explicitly invalid
if line is not None and line < 1:
raise StorageError("INVALID_PARAMETER", "Line must be >= 1 (first line is 1, not 0)")
# Skip line/end_line/pattern validation when overwrite=True (these params are ignored)
if not overwrite:
# Validate line parameter - line=0 is explicitly invalid
if line is not None and line < 1:
raise StorageError("INVALID_PARAMETER", "Line must be >= 1 (first line is 1, not 0)")
if end_line is not None and end_line < 1:
raise StorageError("INVALID_PARAMETER", "end_line must be >= 1 (first line is 1, not 0)")
if end_line is not None and end_line < 1:
raise StorageError("INVALID_PARAMETER", "end_line must be >= 1 (first line is 1, not 0)")
if position in ("before", "after", "replace"):
if line is None and pattern is None:
raise StorageError("MISSING_PARAMETER", f"Position '{position}' requires 'line' or 'pattern'")
if end_line is not None and position != "replace":
raise StorageError("INVALID_PARAMETER", "end_line only valid with position='replace'")
if end_line is not None and end_line < line:
raise StorageError("INVALID_PARAMETER", "end_line must be >= line")
if not overwrite and position in ("before", "after", "replace"):
if line is None and pattern is None:
raise StorageError("MISSING_PARAMETER", f"Position '{position}' requires 'line' or 'pattern'")
if end_line is not None and position != "replace":
raise StorageError("INVALID_PARAMETER", "end_line only valid with position='replace'")
if end_line is not None and end_line < line:
raise StorageError("INVALID_PARAMETER", "end_line must be >= line")
# === COMPILE REGEX ===
compiled_pattern = None
if pattern is not None:
if pattern is not None and not overwrite:
if pattern == "":
raise StorageError("INVALID_PARAMETER", "Pattern cannot be empty")
flags = 0
@ -4128,7 +4130,8 @@ Note: stdout/stderr are truncated at 50KB to prevent context overflow.
except FileNotFoundError:
current_size = 0
if offset is not None and offset > current_size:
# Only validate offset bounds when it will actually be used
if offset is not None and position in ("at", "replace") and offset > current_size:
raise StorageError("INVALID_PARAMETER", f"Offset {offset} beyond file size ({current_size})")
bytes_removed = 0
@ -5104,7 +5107,11 @@ class Tools:
if not editzone_path.exists():
raise StorageError("NOT_IN_EDIT_MODE", f"File not open for editing: {path}",
hint="Use shed_lockedit_open() first. Note: shed_lockedit_save() CLOSES edit mode!")
# Validate content parameter
if content is None:
raise StorageError("MISSING_PARAMETER", "Content parameter is required")
# Check content size
self._core._validate_content_size(content)
@ -6859,7 +6866,15 @@ class Tools:
# Ensure parent directory exists
db_path.parent.mkdir(parents=True, exist_ok=True)
# Validate mutually exclusive parameters
if import_csv and query:
raise StorageError(
"INVALID_PARAMETER",
"Cannot use both 'import_csv' and 'query' parameters",
hint="Use import_csv for CSV import OR query for SQL execution, not both"
)
# =====================================================
# CSV IMPORT MODE
# =====================================================