mirror of
https://github.com/NeuralNomadsAI/CodeNomad.git
synced 2026-11-17 05:49:28 +00:00
## Summary
Electron already ships the Node runtime the backend needs. The Electron
package now launches the CodeNomad server through `process.execPath`
with `ELECTRON_RUN_AS_NODE=1` and keeps only npm (from the pinned
`.node-version` archive), dropping the redundant standalone `node.exe`
(~89 MiB on Windows). Tauri keeps its full bundled runtime unchanged.
## Changes
- **Launch**: `process-manager.ts` runs the backend with Electron's own
executable in run-as-Node mode; `managed-node.ts` is removed.
- **Resources**: `prepare-node-runtime.cjs` gains an npm-only layout
requested by `electron-app/scripts/prepare-resources.js`; Tauri keeps
the full Node + npm layout.
- **npm discovery**: `bundledNpm()` (`npm-runtime.ts`) finds npm in
Electron resources (Windows, Linux, macOS `.app/Contents/Resources`)
while preserving Node/Tauri layouts.
- **npm lifecycle scripts**: `@opencode/cli` runs `node
./postinstall.mjs`; installation (`shared-installation.ts`) and native
upgrades (`native-upgrade.ts`) get a private, scoped `node` command
pointing at the Electron executable, removed afterwards. The shared
OpenCode daemon never inherits `ELECTRON_RUN_AS_NODE`.
- **Checks/CI**: packaged-resource smoke, `verify-bundled-node`,
`build.js` and `build-and-upload.yml` separate the Electron (npm-only)
and Tauri contracts; `test-opencode-*-native.mjs` and the desktop setup
qualification can target the packaged Electron runtime without a system
Node on PATH.
- **Docs**: `dev-docs/RUNTIME_MAINTENANCE.md` (the Electron package
follows Electron's Node version), `dev-docs/OPENCODE_RUNTIME_SETUP.md`,
and `server.md` / `updates.md` help pages in all ten locales.
## Validation
- Electron 39.0.0 → Node 22.20.0; npm 11.19.0 (engines `^20.17.0 ||
>=22.9.0`).
- Packaged Windows ZIP and Linux (`linux-unpacked` + extracted DEB,
Ubuntu 24.04 VM): backend reaches ready, API answers 200, both backend
processes run as the app executable with `ELECTRON_RUN_AS_NODE=1`, no
Node in resources or on PATH, clean exit with no orphan and the
executable released.
- `test-opencode-install-native` (2.2.3), `test-opencode-upgrade-native`
(→ 2.2.5, isolated service PID kept) and
`test-opencode-legacy-replacement-native` (1.18.10 → 2.2.5) pass on
Windows and Linux with the packaged Electron runtime.
- Typechecks (server, Electron), resource tests 11/11, `opencode-update`
tests (Windows 66 pass / 1 POSIX skip; Linux 62 pass / 5 Windows skips),
help validation.
- The full Electron suite on Windows shows intermittent failures in
`process-stop.test.ts` and `native-service-start.test.ts` (PowerShell
capture timeout of 1.5 s); they reproduce identically on `dev`
(30527e58d) and the files are unchanged here.
## Size (same machine and options)
| | Before | After | Delta |
|---|---:|---:|---:|
| Windows `resources` | 344 274 218 B | 250 740 778 B | −89.20 MiB |
| Windows ZIP | 221 737 165 B | 188 286 779 B | −31.90 MiB |
| Linux `resources` | 377 016 175 B | 250 408 680 B | −120.74 MiB |
| Linux DEB | 138 393 810 B | 107 123 634 B | −29.82 MiB |
macOS was not exercised at runtime (path handling is covered by unit
tests; arm64/x64 builds run in CI).
30 lines
1.7 KiB
JavaScript
30 lines
1.7 KiB
JavaScript
import assert from "node:assert/strict"
|
|
import { execFileSync } from "node:child_process"
|
|
import { mkdir, symlink } from "node:fs/promises"
|
|
import path from "node:path"
|
|
import { tsImport } from "tsx/esm/api"
|
|
|
|
const { bundledNpm } = await tsImport("../packages/server/src/opencode-update/npm-runtime.ts", import.meta.url)
|
|
|
|
// Select an actual packaged Electron executable and npm-only resources, never a renamed Node copy.
|
|
export async function fixtureRuntime(root) {
|
|
const electron = process.env.CODENOMAD_FIXTURE_ELECTRON === "1"
|
|
const node = process.env.CODENOMAD_FIXTURE_NODE || process.execPath
|
|
const resources = process.env.CODENOMAD_FIXTURE_RESOURCES
|
|
if (electron) {
|
|
assert.ok(resources && process.env.CODENOMAD_FIXTURE_NODE, "Electron fixture requires NODE and RESOURCES")
|
|
const version = execFileSync(node, ["-p", "process.versions.electron ?? ''"], {
|
|
env: { ...process.env, ELECTRON_RUN_AS_NODE: "1" }, encoding: "utf8", windowsHide: true }).trim()
|
|
assert.match(version, /^\d+\.\d+\.\d+/, "Electron fixture requires an Electron executable")
|
|
}
|
|
const npm = bundledNpm(node, resources)
|
|
assert.ok(npm, "Fixture requires npm beside its runtime or in its resources")
|
|
const tools = path.join(root, "tools")
|
|
await mkdir(tools, { recursive: true })
|
|
if (process.platform !== "win32") await symlink("/bin/sh", path.join(tools, "sh"))
|
|
// Both desktop hosts start their backend with ELECTRON_RUN_AS_NODE=1; Electron
|
|
// also sets ELECTRON_NO_ASAR=1.
|
|
return { node, npm, electron, env: electron ? { ELECTRON_RUN_AS_NODE: "1", ELECTRON_NO_ASAR: "1" } : { ELECTRON_RUN_AS_NODE: "1" },
|
|
path: process.platform === "win32" ? `${process.env.SystemRoot}/System32`
|
|
: electron ? tools : `${path.dirname(node)}:/usr/bin:/bin` }
|
|
}
|