mirror of
https://github.com/NeuralNomadsAI/CodeNomad.git
synced 2026-07-30 10:08:07 +00:00
4c50829da0
## Summary - do not mount SessionList while the temporary left drawer is floating and closed - keep the session-list error state mutually exclusive with virtualized rows - register focused visibility-policy tests in the PR workflow ## Root cause SUID constructs temporary Drawer children while open is false. This occurs both after restarting with a persisted closed panel and when narrowing the window into mobile mode, which forces the left panel to become unpinned and closed. SessionSidebar then mounted the virtua Virtualizer in a detached staging document. virtua resolves ResizeObserver through ownerDocument.defaultView, which is null for that document. The failure is timing-dependent: if session hydration publishes rows while that closed mobile Drawer is detached, the synchronous render exception escapes through setSessionPage and is caught by fetchSessions as if the successful API request had failed. Opening the panel later therefore reveals an empty list or the misleading Unable to load sessions error. If hydration finishes under a different drawer lifecycle, the bug does not appear. Because the error UI and virtualized rows were both mounted, Retry cleared the error and immediately hit the same poisoned lifecycle again. ## Behavior Session fetching and startup restore continue while the panel is closed. The virtualized DOM is created only after the panel is open or pinned. Genuine list errors dispose the rows; Retry can then mount a clean virtualizer after succeeding. ## Reproduction 1. Narrow the window until CodeNomad enters mobile mode and the left panel can no longer remain pinned. 2. Leave the sessions panel closed while sessions hydrate, or restart in that state. 3. Open the left panel. 4. Before this fix, the list may be empty or show Unable to load sessions with a ResizeObserver null error. ## Validation - 19 focused session visibility, tree, and pagination tests - UI TypeScript typecheck - production Vite build - full Windows Tauri release build - NSIS installer bundle - regression test included in PR CI |
||
|---|---|---|
| .. | ||
| build-and-upload.yml | ||
| comment-pr-artifacts.yml | ||
| dev-release.yml | ||
| manual-npm-publish.yml | ||
| pr-build.yml | ||
| release-ui.yml | ||
| release.yml | ||
| restrict-non-dev-prs.yml | ||
| reusable-release.yml | ||
| update-winget.yml | ||