CodeNomad/scripts/native-pruning-ready.test.mjs
Pascal André f747d47f41
Some checks are pending
Download Caches / seed (windows-2025) (push) Waiting to run
Download Caches / seed (ubuntu-24.04) (push) Waiting to run
Download Caches / seed (macos-15-intel) (push) Waiting to run
Download Caches / seed (macos-26) (push) Waiting to run
Publish help / build (push) Waiting to run
Publish help / deploy (push) Blocked by required conditions
fix(opencode): prepare cold Location RPCs before one-shot dispatch (#1448)
## Problem

OpenCode 2.2.7 intentionally removes `Plugin.awaitActivation` from
`rpc.call`. On unchanged CodeNomad, native cold history/pruning returns
`rpc.unavailable`, `/goal` incorrectly reports unsupported, and a
headless integration host can fail its first advertisement. The same
native checks pass on 2.2.6.

## Adaptation

- Adopt the existing bounded, connection-owned pruning readiness
foundation and its eight fixed broker families. Preparation targets the
already-authorized exact native Location and requires a fresh
lease/registration-scope acknowledgement, rather than treating a
backend-wide startup marker as universal readiness.
- Preserve session/workspace/connection, deletion/ABA, cancellation and
extension-grant fences around waits and the single functional dispatch.
No pruning mutation is probed, replayed or retried; generic RPC proxy
access stays closed.
- Share the native catalogue activation wait with `/goal`. Only method
absence after activation proves unsupported; transient registration loss
remains unavailable.
- Preserve current Memory provisioning and ownership options while
adopting the foundation. Abort the startup marker observer on close so
cleanup does not wait on an unreferenced polling timer.
- Correct the reference host discovery client, vendored byte-for-byte
from [opencode-integrations
#17](https://github.com/NeuralNomadsAI/opencode-integrations/pull/17):
payload-free status preparation may repeat while registration is
unavailable; advertise/withdraw are sent once, with no directory
fallback after dispatch. The external PR publishes source only;
installed hosts need the corresponding host update.
- Keep minimum, recommendation and authoring dependency pins unchanged.
Add cold fixed-broker native coverage to minimum/latest and
Windows/Linux/macOS native lanes.

## Validation

- **199** affected broker/lifecycle/readiness/goal tests pass; the final
cancellation cleanup additionally passes **40** focused tests.
- **30** real-browser Images/panel-extension journeys pass.
- Official isolated **2.2.3, 2.2.6 and 2.2.7**, driven by pinned **Node
24.22.2**: full pruning/history/Images/replay fixture, production goal
route, cold fixed preview/prune/history/Images brokers and headless
integration discovery/advertise/attach/withdraw all pass. The cold
broker check asserts one prune dispatch and retained conclusion bytes,
plus a new backend lease.
- **2.2.7 split storage** passes full pruning, native proxy/UI
contracts, assets/gallery, mixed split+inline content after flag
disable/restart, receipts, active-claim refusal and retained model
payload.
- Server/UI typechecks, complete server/UI/native-plugin build, **27**
package/vendor parity tests, **31** help tests, native driver test, YAML
and whitespace checks pass.
- External Python reference tests **9/9** and kit test typechecking
pass; Blender's vendored copy equals the reference.

Only private synthetic daemons, local providers and owned fixture state
were used. No shared service restart, real
credentials/database/configuration change or stable publication. Earlier
fixture attempts exposed an import-ID conflict, Windows path
normalization in the fixture ownership stub, and teardown ordering;
those harness defects were corrected without relaxing assertions. One
final rerun was needed after a simultaneous build cleaned its dist
input; the post-build rerun passes.

The native tests reuse source from the independently prepared readiness
foundation and broker work, adapted onto current dev without taking the
unrelated multi-backend branch. Public labels, controls and documented
steps stay unchanged; the fix restores their documented behavior. Large
existing touched files: `packages/server/src/index.ts` (~758 lines),
`packages/server/src/server/http-server.ts` (~2574),
`packages/server/src/workspaces/manager.ts` (~1230), and
`packages/server/src/server/routes/pending-requests.test.ts` (~1025).
Integrated CI and platform builds remain the final gate.
2026-11-10 16:25:51 +01:00

41 lines
1.9 KiB
JavaScript

import assert from "node:assert/strict"
import { test } from "node:test"
import { waitNativePruningPlugin } from "./native-pruning-ready.mjs"
test("pruning discovery preserves Location/options, bounds absence and rejects failure/cancellation without RPC", async () => {
const location = { directory: "/isolated/cold" }, locationOptions = { headers: { fixture: "owned" } }
const active = { id: "codenomad-session-pruning", source: { type: "local" }, state: { status: "active" } }
let plugins = [], reads = 0, rpc = 0
const controller = new AbortController()
const client = {
plugin: { list: async (input, options) => {
reads++
assert.equal(input.location, location)
assert.equal(options.headers, locationOptions.headers)
assert.equal(options.signal, controller.signal)
return { data: plugins }
} },
rpc: { call: () => { rpc++; throw new Error("Discovery must never call RPC") } },
}
const until = async predicate => {
for (let n = 0; n < 3; n++) if (await predicate()) return
throw new Error("Fixture deadline")
}
const ready = () => waitNativePruningPlugin({ client, location, locationOptions, signal: controller.signal, until })
plugins = [{ ...active, id: "another-plugin" }]
await assert.rejects(ready(), error => /cold/.test(error.message) && /Fixture deadline/.test(error.cause.message))
assert.equal(reads, 3)
plugins = [active]
await ready()
for (const state of [{ status: "failed", error: "activation canary" }, { status: "disabled" }]) {
plugins = [{ ...active, state }]
const before = reads
await assert.rejects(ready(), error => error.message.includes(state.status))
assert.equal(reads, before + 1)
}
controller.abort(new Error("Cancelled fixture"))
const before = reads
await assert.rejects(ready(), error => error.cause === controller.signal.reason)
assert.equal(reads, before)
assert.equal(rpc, 0)
})