mirror of
https://github.com/NeuralNomadsAI/CodeNomad.git
synced 2026-11-19 23:12:07 +00:00
## Summary
CodeNomad was accepted into SignPath Foundation's open-source program
(organization "CodeNomad [OSS]", project `CodeNomad`, GitHub.com trusted
build system, `test-signing` and `release-signing` policies with manual
approval). This wires Authenticode signing of the Windows artifacts into
the release CI. **Signing is off by default**: until the repository
variable `SIGNPATH_RELEASE_SIGNING=true` is set (once SignPath
Foundation issues the release certificate, still "CSR pending"),
releases publish exactly what they publish today.
## What Windows users get, and what is signed
Checked against the `v1.0.1-dev-20261101-fb44655c` prerelease:
- **Tauri NSIS installer** (download, WinGet package and in-app update
file) and the `codenomad-tauri.exe` it installs: both signed. Tauri
rewrites the executable while packaging it (the NSIS bundle-type marker
the updater relies on), which would break a signature applied first, so
the Tauri job becomes two-stage:
1. `tauri build --no-bundle`;
2. `patch-bundle-type.mjs` writes the NSIS marker (same rewrite as Tauri
2.12.4, verified on a real binary);
3. sign the executable;
4. `tauri bundle --no-binary-patching`;
5. sign the installer;
6. recompute the updater signature over the signed installer (`tauri
signer sign --app-version`); the existing staging check, `latest.json`
and WinGet then hash the signed file.
Unsigned builds take the same path, so every PR build exercises it.
`uninstall.exe` is generated during packaging and stays unsigned;
`node.exe` is already signed by OpenJS.
- **Electron portable ZIP:** `CodeNomad.exe` is signed; CI checks that
every other entry of the returned ZIP is unchanged.
SignPath only accepts uploaded GitHub artifacts and waits for a manual
approval on `release-signing`, so the electron-builder and Tauri
in-build signing hooks are not used. Requests go through
`signpath/github-action-submit-signing-request@v3` (composite action
`.github/actions/signpath-sign`), with artifact configurations in
`.signpath/artifact-configurations/` (zip root, `<authenticode-sign/>`,
metadata restrictions on product name `CodeNomad` and the release
version; validated against SignPath's XSD).
## When signing runs
- PR and fork builds: never signed, never fail for lack of a token.
- Stable releases: `release-signing` when
`SIGNPATH_RELEASE_SIGNING=true`; the release then fails before building
if `SIGNPATH_API_TOKEN` is missing (fail closed).
- New manual **SignPath Test Signing** workflow: signs a real build with
`test-signing` and publishes nothing. The dev prerelease gains a
`signpath_test_signing` input for an end-to-end check including the
updater signature.
- Returned files are verified: product name and version before
submission; afterwards a timestamped Authenticode signature, signer
`CN=SignPath Foundation` and `signtool verify` for releases (test
certificates accept an untrusted root).
## Docs
`CODE_SIGNING.md` describes the actual workflow (release certificate
pending); `dev-docs/TAURI_UPDATER.md`, `dev-docs/INDEX.md`, `BUILD.md`
and `docs/guides/winget-release-automation.md` follow the two-stage
Tauri build. No UI change, so no help pages.
## Validation
- actionlint 1.7.12: no new findings (the only one is the existing `if:
${{ false }}` on the disabled Linux arm64 job).
- The three artifact configurations validate against SignPath's official
XSD.
- Node tests 21/21, including signing gates and the build → sign →
package → re-sign order; `patch-bundle-type.mjs` tested.
- PowerShell checks run on the real dev artifacts: wrong versions,
unsigned files, a wrong signer and a modified DLL in the ZIP are
rejected.
- Not run: the signed path itself (needs the token and the SignPath
portal artifact configurations), and a full Tauri build locally; this
PR's CI exercises the unsigned two-stage Tauri build.
Large file: `.github/workflows/build-and-upload.yml` is now about 1,260
lines.
Final review: ZERO FINDINGS at a4ca8d255. Electron uses
shortVersionWindows before native signing; no post-sign hook remains.
Stable and prerelease native-signed ZIPs retain their timestamped
signatures (temporary untrusted root). Actual SignPath testing remains
pending and release signing stays off.
|
||
|---|---|---|
| .. | ||
| winget-release-automation.md | ||