Commit graph

2 commits

Author SHA1 Message Date
Pascal André
f3bf6c4032
feat(plugins): protect CodeNomad-managed system plugins (#1308)
## Problem

CodeNomad's own OpenCode plugins appeared as ordinary plugins with
activation switches, so users could disable an application feature
without knowing it. Filtering by a `codenomad` name or ID would also
hide unrelated third-party plugins and lose loading failures.

## Behavior

- Verified CodeNomad-managed plugins stay outside ordinary plugin rows,
activation switches, package actions and source-removal controls.
- Disabled, failed or loading-unconfirmed managed plugins appear in a
compact warning above the list, with accessible on-demand
error/configuration details.
- **Re-enable** uses the existing activation path: append a positive
exact-ID rule, preserve the disabling rule and unrelated configuration,
and target the disabling Global/Project scope when writable, otherwise
the writable Project override.
- A configuration write does not clear the warning. A fenced native
inventory refresh must confirm active runtime; failed or unconfirmed
loading stays visible. OpenCode is never restarted automatically.

## Approach and edge cases

The server computes `managedBy: "codenomad"` from the authenticated
daemon's discovery root, a validated installer-generated entry and its
SHA-256-addressed payload location/content. The UI filters that marker
rather than recognizing names. Shared installer parsing preserves
retained outside-root storage. Build scripts publish a minimal
exported-ID descriptor inside the hashed payload so absent runtime
entries can still be correlated with exact, prefix and all-plugin
disabling rules, without importing executable code or adding an ID
catalogue.

- Windows paths and file URLs retain their native identity; WSL
translates native directories only for host IO. Reserved WSL UNC
zero-device metadata still requires independent handles, matching
nonzero inodes, regular single-link files, stable bounded reads and
SHA-256 verification. Final file links remain detectable.
- Inherited/external and virtual configuration origins remain distinct
from the writable Project recovery destination; unavailable destinations
offer no mutation.
- Managed failures before exporting an ID retain details, including
native references, without fabricated activation switches or duplicate
warnings. Unproven and third-party local failures retain ordinary path
rows.
- Third-party homonyms remain controllable. The separately packaged
session-pruning TUI companion is not installer-owned merely because its
ID resembles a desktop plugin.
- Concurrent mutation/read reconciliation preserves newer runtime
provenance and failure details; keyboard focus returns to Refresh when a
warning disappears.

## Documentation

Updated `dev-docs/PLUGIN_CONTROLS.md`,
`dev-docs/OPENCODE_COMPATIBILITY.md`, and `docs/help/*/integrations.md`
in all ten supported languages, alongside localized UI labels. The
plugin list is documented on the Integrations help page.

## Validation

Publication rerun on the pushed commits:

- `node --import tsx --test
packages/server/src/opencode/desktop-plugin-artifact.test.ts
packages/server/src/opencode/desktop-plugin-managed.test.ts
packages/server/src/opencode/plugin-controls.test.ts
packages/ui/src/stores/plugin-controls.test.ts` — **96 passed, 0 failed,
0 skipped**. Covers verified managed files, third-party homonyms,
tampering/links, disabled rules, scoped recovery, stale-response fencing
and runtime confirmation.
- `node --import tsx --test --test-concurrency=1
packages/ui/tests/browser/plugin-controls.test.ts` — **28 passed, 0
failed, 0 skipped**. Exercises the real list, warning, Re-enable, native
events, failure details, scope labels and keyboard focus.
- `npm run test:help` — **31 passed**; validates **28 pages in 10
locales**.
- `npm run typecheck --workspace @neuralnomads/codenomad` and `npm run
typecheck --workspace @codenomad/ui` — **passed**.
- `node --import tsx scripts/test-plugin-runtime-native.mjs
<absolute-isolated-cli>` with **OpenCode 2.2.5** — **passed**: native
loading reports the generated `.ts` shim, matches verified installation
provenance, and agrees with the exported-ID descriptor; isolated native
RPC/Form checks also pass.
- With `CODENOMAD_TEST_WSL_PLUGIN_CONTROLS=Ubuntu`, the real
`desktop-plugin-managed-wsl.test.ts` case **passed**, including
zero-device metadata, corruption repair and hard/symbolic-link refusal.
The combined rerun with `plugin-control-document-wsl.test.ts` exceeded
its 180-second local budget after successful document cases; that full
rerun is not claimed complete.
- `git diff --check origin/dev...HEAD` — **passed**. Clean worktree;
exactly the two delivery commits above `origin/dev`, with no rebase,
force push or push to `dev`.
2026-11-06 04:13:30 +01:00
Pascal André
dd5a1f387d
fix(opencode): share host plugin runtime and require 2.0.27 (#920)
## Résultat
Corrige le chargement des plugins CodeNomad avec OpenCode 2.0.27 et
établit cette version comme minimum pour les prochaines releases et les
prereleases dev. Aucun déploiement de l’application active ni
redémarrage du daemon partagé.

## Cause démontrée
- Le runtime natif passe d’Effect 4.0.0-rc.112 à 4.0.1. Le bundle
précédent reproduit `cache.stackFrame` sur une CLI 2.0.27 isolée.
- Embarquer Effect 4.0.1 ne préserve pas la 2.0.26 : échec inverse
`cache.scheduler`.
- Les schémas 2.0.27 consomment `Schema.isStartingWith`, absent du
moteur 2.0.26. Le plancher est fondé sur cette rupture mesurée, pas sur
une liste de versions testées.

## Implémentation
- Pins client/plugin synchronisés à 2.0.27 ; Effect et le SDK public des
plugins sont fournis par OpenCode, hors bundles natifs
pruning/Missions/automation.
- Réglages de build partagés et régression qui interdit une seconde
copie du runtime ; smoke natif ajouté à la matrice minimum/latest.
- Diagnostic `plugin_runtime` traduit dans les dix locales ; versions
futures et personnalisées conservent la reconnaissance authentifiée du
contrat.
- Adaptations du SDK : annulation des lectures projet, références de
credentials externes et connexion fournisseur externe avec formulaire
natif, sans fallback OAuth/API key ni rejeu.
- Le runtime OpenTunnel du backend reste isolé et inchangé. Aucun
tunnel, route ou identité distant n’est modifié.

## Validation locale
- Échec reproduit sur 2.0.26 et réussite sur 2.0.27 pour les variantes
de bundle comparées.
- Suites natives isolées automation,
pruning/historique/proxy/concurrence/redémarrage et Missions réussies
sur 2.0.27.
- Régressions ciblées de build, store/serveur et navigateur (diagnostic
du minimum, connexion externe et brouillon conservé) réussies ;
typechecks UI/serveur/Electron/OpenTunnel réussis.
- Suite serveur complète et CI multiplateforme encore en validation à
l’ouverture ; aucun résultat entièrement vert anticipé.

La revue gatekeeper indépendante sera publiée ici avant fusion. Les
anciennes preuves de qualification restent historiques, pas une promesse
de support des moteurs antérieurs au nouveau plancher.
2026-10-12 16:42:07 +02:00