2 commits

Author	SHA1	Message	Date
Pascal André	0bab9e3438	fix(restore): simplify persistence and harden cross-platform cleanup (#602) ... ## Summary - Follow up #578 by consolidating desktop persistence, restore reconciliation, lifecycle coordination, and regression coverage. - Preserve active drafts and attachments, request-scoped workspace ownership, deletion tombstones, renderer authority, and bounded shutdown behavior. - Fix the reported macOS cleanup failure with targeted BSD process queries and random-token-guarded process-group cleanup, without an unverified PID fallback. ## Platform hardening - Ignore development renderer origins in packaged Electron builds. - Preserve staged Tauri navigation authority and handle confirmed Windows session-end shutdown on the UI thread. - Bound workspace launch preflight, runtime startup, and health readiness. - Retain cleanup ownership after unexpected leaders exit and verify portable POSIX descendants by immutable identity or inherited launch token. - Add real Darwin-only process-group integration tests for macOS CI. ## Scope - 96 files changed. - 6,295 additions and 12,167 deletions, a net reduction of 5,872 lines from the merged implementation. - Consolidated duplicated tests while retaining focused race, durability, cleanup, and platform contracts. ## Validation - pm run typecheck - pm run typecheck --workspace @neuralnomads/codenomad - Electron native suite: 60 passed - Tauri suite: 49 passed - Focused server lifecycle/identity suite: 31 passed, 2 Darwin-only skipped on Windows - Focused UI restore/codec/reconciliation suite: 36 passed - Broader server suite: 59 passed, 3 platform skips - Broader UI suite: 97 passed, 1 skip; 2 Node 25 solid-toast loader failures reproduced on the merged baseline - git diff --check - Final limited gatekeeper: PASS for server/macOS, UI restore, and Electron/Tauri	2026-07-17 22:17:15 +01:00
Pascal André	1efe5e91d1	feat(desktop): persist and restore UI state across restarts (#578) ... ## Summary - Restore the primary desktop client's window bounds, zoom, workspace tabs, active sessions, drafts, bounded attachments, scroll positions, and panel layout across launches. - Keep additional Electron and Tauri processes independent: they still start normally but do not read or write the shared native snapshot. - Add translated settings to disable startup restoration or clear the saved state. ## Implementation - Persist a versioned, bounded snapshot atomically in Electron and Tauri, preserving unknown future envelopes until an explicit clear. - Elect one primary process with stale-owner recovery and process identity checks, then protect renderer access with per-document capability tokens. - Flush renderer state before close, quit, reload, and app-owned navigation with bounded failure handling and fresh token rotation. - Reconcile partial or timed-out workspace hydration without losing unsent prompt state or resurrecting explicitly cleared drafts, attachments, sessions, or tabs. - Correlate restore-created workspaces so cancellation and delayed SSE events cannot produce ghost tabs. - Harden workspace launch cancellation and cross-platform process cleanup so failed starts cannot orphan detached POSIX, WSL, or Windows children; incomplete shutdown exits nonzero. The restored shell state remains local to the desktop client. Durable semantic session properties continue to use OpenCode session metadata separately. ## Validation pm run typecheck --workspace @neuralnomads/codenomad - Electron native suite: 43 passed - Tauri suite: 54 passed - Focused UI restore, reconciliation, attachment, authority, and race suites passed - Focused server workspace runtime, manager, process identity, route, and shutdown suites passed - pm run build - pm run build:tauri - git diff --check - 16-pass adversarial review loop completed with final No findings - extensivly optimized, tested and used day by day ## Platform notes - Native menu reloads and app-owned navigation have awaited durability guarantees. Browser-engine crashes or forced process termination remain inherently best effort. - Process cleanup uses identity-guarded platform adapters and fails conservatively when target ownership cannot be proven.	2026-07-15 10:22:23 +01:00