Commit graph

5 commits

Author SHA1 Message Date
Pascal André
0ae85b378b
docs(help): rewrite the Support page around its maintainer and add Ko-fi (#1567)
Some checks are pending
Publish help / build (push) Waiting to run
Publish help / deploy (push) Blocked by required conditions
## Summary

- Support page (10 locales): sponsor buttons right under the title, then
the maintainer's own text signed with his name, then other ways to help.
The funding policy section is removed. The Download page support
sentence follows.
- Ko-fi added as a second channel (`funding.json`, strict
`https://ko-fi.com/<page>` allowlist with tests, `.github/FUNDING.yml`).
Funding buttons no longer show a payee line.
- `GOVERNANCE.md`, `CODE_OF_CONDUCT.md`, `SECURITY.md`,
`CODE_SIGNING.md`, `PRIVACY.md`: Pascal André as the single maintainer
and contact; Shantur Rathore credited as creator and organization owner.

## Validation

`npm run test:help` 31/31, `npm run build:help`, the funding browser
case, `git diff --check`. The help browser suite's home tour video
assertion fails the same way on `dev`.
2026-11-16 21:57:25 +01:00
Pascal André
2f153e2e34
fix(security): qualify electron-builder 26 before Windows signing (#1459)
Some checks are pending
Download Caches / seed (macos-15-intel) (push) Waiting to run
Download Caches / seed (macos-26) (push) Waiting to run
Download Caches / seed (ubuntu-24.04) (push) Waiting to run
Download Caches / seed (windows-2025) (push) Waiting to run
Publish help / build (push) Waiting to run
Publish help / deploy (push) Blocked by required conditions
fix(security): qualify electron-builder 26 before Windows signing

Resolve the ten remaining builder/runtime/tar alerts with electron-builder and app-builder-lib 26.18.0, builder-util-runtime 9.7.0 and tar 7.5.22. Declare the server tests' actual AJV 6 dependency so builder's AJV 8 hoisting cannot change their API; preserve the separate AJV2020 alias and production AJV 8.

Before the Windows builder CLI starts, apply the three-line reviewed resource-editor correction behind an exact source hash and version fence. Keep full stable/prerelease ProductVersion and FileVersion strings alongside their numeric Windows prefixes. The actual packager edits resources before signIf; unsigned and signed metadata checks remain unchanged.

Integrate the qualified PWA/runtime dependency graph rather than overwrite its lockfile. Correct the new minimatch consumers through family-scoped overrides, retain historical ASAR/temp callback APIs and remove config-file-ts's unused closure. Qualify actual matching, file copies, ASAR merges, TypeScript configuration, cancellation and resource-edit ordering.

Frozen Windows/Linux installs, consumer tests, typechecks, complete builds, real offline PWA behavior and the normal Windows packaging/executable smoke qualify the combined candidate. The existing blocked Dependabot proposal stays visible until this tested replacement is merged and its alerts are independently checked.


Include the explicitly user-authorized artifact announcer permission pair (PR-write, Issues-read), guarded by thirteen helper tests and the unchanged trusted-default-branch boundary. No new secret or protection change.

Capture original Windows identity probes in the test fixture instead of a second misleading diagnostic lookup. Preserve the shared identity budget, retries and fencing; fifteen Node and eighteen native module checks pass. The initial OS incident remains open in #1462. Incorporate the already merged GLib backport and verify the complete 4,456-file tree before final full CI.
2026-11-11 03:56:42 +01:00
Pascal André
926e2c7d98
ci(release): sign Windows artifacts with SignPath (#1257)
## Summary

CodeNomad was accepted into SignPath Foundation's open-source program
(organization "CodeNomad [OSS]", project `CodeNomad`, GitHub.com trusted
build system, `test-signing` and `release-signing` policies with manual
approval). This wires Authenticode signing of the Windows artifacts into
the release CI. **Signing is off by default**: until the repository
variable `SIGNPATH_RELEASE_SIGNING=true` is set (once SignPath
Foundation issues the release certificate, still "CSR pending"),
releases publish exactly what they publish today.

## What Windows users get, and what is signed

Checked against the `v1.0.1-dev-20261101-fb44655c` prerelease:

- **Tauri NSIS installer** (download, WinGet package and in-app update
file) and the `codenomad-tauri.exe` it installs: both signed. Tauri
rewrites the executable while packaging it (the NSIS bundle-type marker
the updater relies on), which would break a signature applied first, so
the Tauri job becomes two-stage:
  1. `tauri build --no-bundle`;
2. `patch-bundle-type.mjs` writes the NSIS marker (same rewrite as Tauri
2.12.4, verified on a real binary);
  3. sign the executable;
  4. `tauri bundle --no-binary-patching`;
  5. sign the installer;
6. recompute the updater signature over the signed installer (`tauri
signer sign --app-version`); the existing staging check, `latest.json`
and WinGet then hash the signed file.

Unsigned builds take the same path, so every PR build exercises it.
`uninstall.exe` is generated during packaging and stays unsigned;
`node.exe` is already signed by OpenJS.
- **Electron portable ZIP:** `CodeNomad.exe` is signed; CI checks that
every other entry of the returned ZIP is unchanged.

SignPath only accepts uploaded GitHub artifacts and waits for a manual
approval on `release-signing`, so the electron-builder and Tauri
in-build signing hooks are not used. Requests go through
`signpath/github-action-submit-signing-request@v3` (composite action
`.github/actions/signpath-sign`), with artifact configurations in
`.signpath/artifact-configurations/` (zip root, `<authenticode-sign/>`,
metadata restrictions on product name `CodeNomad` and the release
version; validated against SignPath's XSD).

## When signing runs

- PR and fork builds: never signed, never fail for lack of a token.
- Stable releases: `release-signing` when
`SIGNPATH_RELEASE_SIGNING=true`; the release then fails before building
if `SIGNPATH_API_TOKEN` is missing (fail closed).
- New manual **SignPath Test Signing** workflow: signs a real build with
`test-signing` and publishes nothing. The dev prerelease gains a
`signpath_test_signing` input for an end-to-end check including the
updater signature.
- Returned files are verified: product name and version before
submission; afterwards a timestamped Authenticode signature, signer
`CN=SignPath Foundation` and `signtool verify` for releases (test
certificates accept an untrusted root).

## Docs

`CODE_SIGNING.md` describes the actual workflow (release certificate
pending); `dev-docs/TAURI_UPDATER.md`, `dev-docs/INDEX.md`, `BUILD.md`
and `docs/guides/winget-release-automation.md` follow the two-stage
Tauri build. No UI change, so no help pages.

## Validation

- actionlint 1.7.12: no new findings (the only one is the existing `if:
${{ false }}` on the disabled Linux arm64 job).
- The three artifact configurations validate against SignPath's official
XSD.
- Node tests 21/21, including signing gates and the build → sign →
package → re-sign order; `patch-bundle-type.mjs` tested.
- PowerShell checks run on the real dev artifacts: wrong versions,
unsigned files, a wrong signer and a modified DLL in the ZIP are
rejected.
- Not run: the signed path itself (needs the token and the SignPath
portal artifact configurations), and a full Tauri build locally; this
PR's CI exercises the unsigned two-stage Tauri build.

Large file: `.github/workflows/build-and-upload.yml` is now about 1,260
lines.


Final review: ZERO FINDINGS at a4ca8d255. Electron uses
shortVersionWindows before native signing; no post-sign hook remains.
Stable and prerelease native-signed ZIPs retain their timestamped
signatures (temporary untrusted root). Actual SignPath testing remains
pending and release signing stays off.
2026-11-01 16:07:50 +01:00
Pascal André
a9bf2ddc3b
docs: record both maintainers as repository administrators with equal rights (#1253)
## Summary

@shantur made @pascalandr an administrator of the CodeNomad repository
and agreed, in a private conversation, that both maintainers now hold
the same rights and responsibilities for the project. This records it in
the governance documents, as `GOVERNANCE.md` requires for changes to
itself.

- **`GOVERNANCE.md`:** both maintainers are listed as maintainers and
administrators of the repository (Shantur also owns the NeuralNomadsAI
organization). A new paragraph states that they have the same rights and
responsibilities, and that either of them can change the repository's
settings, manage its access and act for the project with the services it
uses (code signing, package registries, funding platforms). The decision
rules are unchanged: significant decisions still need both maintainers.
- **`CODE_SIGNING.md`:** both maintainers are the project owners for the
SignPath Foundation application, so either can authorize the signing
integration and approve changes to signing responsibilities. Pascal
remains the signing operator and approver.

The `LICENSE` copyright line is not changed here; it is discussed
separately.

@shantur, a comment confirming this here would complete the record.

## Repository settings applied with the new administrator access

- Private vulnerability reporting enabled, so the **Report a
vulnerability** button that `SECURITY.md` points to works.
- Sponsorships enabled, so the **Sponsor** button reads
`.github/FUNDING.yml`.
- Homepage set to the help site, and topics added.

## Validation

- `git diff --check`; relative links unchanged.
2026-11-01 10:40:07 +01:00
Pascal André
6c793bae79
docs: propose CodeNomad code signing policy (#1051)
Publish the proposed SignPath Foundation policy with Shantur Rathore as project owner and Pascal Andre as signing operator and approver. Describe source/build provenance, manual signing approval, MFA requirements and artifact verification, with links from the README and to the privacy policy.
2026-10-20 23:50:12 +02:00