vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-04-03 18:49:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[fix] UI: Error when clicking on 'Apps' in the application configuration

Browse source 
https://github.com/safing/portmaster/issues/1721
This commit is contained in:
Alexandr Stelnykovych 2025-01-31 17:50:00 +02:00
parent f021ec2444
commit d8108bff0e
2 changed files with 8 additions and 2 deletions
desktop/angular/src
app/pages/app-view
app-view.html
main.ts

2
desktop/angular/src/app/pages/app-view/app-view.html
View file

@ -3,7 +3,7 @@
<div class="flex justify-between items-center p-4 px-12 text-xxs">
<!-- Breadcrumbs -->
<div class="flex items-center">
<a class="text-secondary hover:text-primary" [routerLink]="['/app/overview']">Apps</a>
<div class="cursor-pointer text-secondary hover:text-primary" [routerLink]="['/app/overview']">Apps</div>
<svg viewBox="0 0 24 24" class="inline-block w-4 h-4 text-secondary">
<g fill="none" class="inner" stroke="currentColor">
<path stroke-linecap="round" stroke-linejoin="round" stroke-width="2.2" d="M10 16l4-4-4-4" />

8
desktop/angular/src/main.ts
View file

@ -27,9 +27,15 @@ if (typeof (CSS as any)['registerProperty'] === 'function') {
}
function handleExternalResources(e: Event) {
// TODO:
// This code executes "openExternal()" when any "<a />" element in the app is clicked.
// This could potentially be a security issue.
// We should consider restricting this to only external links that belong to a certain domain (e.g., https://safing.io).
// get click target
let target: HTMLElement | null = e.target as HTMLElement;
// traverse until we reach an a tag
// traverse until we reach element "<a />"
while (!!target && target.tagName !== "A") {
target = target.parentElement;
}