vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-02 18:49:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve trace logging

Browse source
This commit is contained in:
Daniel 2020-10-15 11:29:47 +02:00
parent d2545e9d64
commit cfafbfca4e
20 changed files with 121 additions and 109 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
firewall/dns.go
View file

@ -170,31 +170,28 @@ func DecideOnResolvedDNS(
updateIPsAndCNAMEs(q, rrCache, conn) updateIPsAndCNAMEs(q, rrCache, conn)
if mayBlockCNAMEs(conn) { if mayBlockCNAMEs(ctx, conn) {
return nil return nil
} }
// TODO: Gate17 integration
// tunnelInfo, err := AssignTunnelIP(fqdn)
return updatedRR return updatedRR
} }
func mayBlockCNAMEs(conn *network.Connection) bool { func mayBlockCNAMEs(ctx context.Context, conn *network.Connection) bool {
// if we have CNAMEs and the profile is configured to filter them // if we have CNAMEs and the profile is configured to filter them
// we need to re-check the lists and endpoints here // we need to re-check the lists and endpoints here
if conn.Process().Profile().FilterCNAMEs() { if conn.Process().Profile().FilterCNAMEs() {
conn.Entity.ResetLists() conn.Entity.ResetLists()
conn.Entity.EnableCNAMECheck(true) conn.Entity.EnableCNAMECheck(ctx, true)
result, reason := conn.Process().Profile().MatchEndpoint(conn.Entity) result, reason := conn.Process().Profile().MatchEndpoint(ctx, conn.Entity)
if result == endpoints.Denied { if result == endpoints.Denied {
conn.BlockWithContext(reason.String(), reason.Context()) conn.BlockWithContext(reason.String(), reason.Context())
return true return true
} }
if result == endpoints.NoMatch { if result == endpoints.NoMatch {
result, reason = conn.Process().Profile().MatchFilterLists(conn.Entity) result, reason = conn.Process().Profile().MatchFilterLists(ctx, conn.Entity)
if result == endpoints.Denied { if result == endpoints.Denied {
conn.BlockWithContext(reason.String(), reason.Context()) conn.BlockWithContext(reason.String(), reason.Context())
return true return true

14
firewall/interception.go
View file

@ -87,13 +87,13 @@ func fastTrackedPermit(pkt packet.Packet) (handled bool) {
switch meta.Protocol { switch meta.Protocol {
case packet.ICMP: case packet.ICMP:
// Always permit ICMP. // Always permit ICMP.
log.Debugf("accepting ICMP: %s", pkt) log.Debugf("filter: fast-track accepting ICMP: %s", pkt)
_ = pkt.PermanentAccept() _ = pkt.PermanentAccept()
return true return true
case packet.ICMPv6: case packet.ICMPv6:
// Always permit ICMPv6. // Always permit ICMPv6.
log.Debugf("accepting ICMPv6: %s", pkt) log.Debugf("filter: fast-track accepting ICMPv6: %s", pkt)
_ = pkt.PermanentAccept() _ = pkt.PermanentAccept()
return true return true
@ -116,7 +116,7 @@ func fastTrackedPermit(pkt packet.Packet) (handled bool) {
} }
// Log and permit. // Log and permit.
log.Debugf("accepting DHCP: %s", pkt) log.Debugf("filter: fast-track accepting DHCP: %s", pkt)
_ = pkt.PermanentAccept() _ = pkt.PermanentAccept()
return true return true
@ -141,7 +141,7 @@ func fastTrackedPermit(pkt packet.Packet) (handled bool) {
// Only allow to own IPs. // Only allow to own IPs.
dstIsMe, err := netenv.IsMyIP(meta.Dst) dstIsMe, err := netenv.IsMyIP(meta.Dst)
if err != nil { if err != nil {
log.Warningf("filter: failed to check if IP is local: %s", err) log.Warningf("filter: failed to check if IP %s is local: %s", meta.Dst, err)
} }
if !dstIsMe { if !dstIsMe {
return false return false
@ -150,9 +150,9 @@ func fastTrackedPermit(pkt packet.Packet) (handled bool) {
// Log and permit. // Log and permit.
switch meta.DstPort { switch meta.DstPort {
case 53: case 53:
log.Debugf("accepting local dns: %s", pkt) log.Debugf("filter: fast-track accepting local dns: %s", pkt)
case apiPort: case apiPort:
log.Debugf("accepting api connection: %s", pkt) log.Debugf("filter: fast-track accepting api connection: %s", pkt)
default: default:
return false return false
} }
@ -165,7 +165,7 @@ func fastTrackedPermit(pkt packet.Packet) (handled bool) {
} }
func initialHandler(conn *network.Connection, pkt packet.Packet) { func initialHandler(conn *network.Connection, pkt packet.Packet) {
log.Tracer(pkt.Ctx()).Trace("filter: [initial handler]") log.Tracer(pkt.Ctx()).Trace("filter: handing over to connection-based handler")
// check for internal firewall bypass // check for internal firewall bypass
ps := getPortStatusAndMarkUsed(pkt.Info().LocalPort()) ps := getPortStatusAndMarkUsed(pkt.Info().LocalPort())

8
firewall/master.go
View file

@ -134,7 +134,7 @@ func checkProfileExists(_ context.Context, conn *network.Connection, _ packet.Pa
return false return false
} }
func checkEndpointLists(_ context.Context, conn *network.Connection, _ packet.Packet) bool { func checkEndpointLists(ctx context.Context, conn *network.Connection, _ packet.Packet) bool {
var result endpoints.EPResult var result endpoints.EPResult
var reason endpoints.Reason var reason endpoints.Reason
@ -143,9 +143,9 @@ func checkEndpointLists(_ context.Context, conn *network.Connection, _ packet.Pa
// check endpoints list // check endpoints list
if conn.Inbound { if conn.Inbound {
result, reason = p.MatchServiceEndpoint(conn.Entity) result, reason = p.MatchServiceEndpoint(ctx, conn.Entity)
} else { } else {
result, reason = p.MatchEndpoint(conn.Entity) result, reason = p.MatchEndpoint(ctx, conn.Entity)
} }
switch result { switch result {
case endpoints.Denied: case endpoints.Denied:
@ -271,7 +271,7 @@ func checkFilterLists(ctx context.Context, conn *network.Connection, pkt packet.
// apply privacy filter lists // apply privacy filter lists
p := conn.Process().Profile() p := conn.Process().Profile()
result, reason := p.MatchFilterLists(conn.Entity) result, reason := p.MatchFilterLists(ctx, conn.Entity)
switch result { switch result {
case endpoints.Denied: case endpoints.Denied:
conn.DenyWithContext(reason.String(), reason.Context()) conn.DenyWithContext(reason.String(), reason.Context())

80
intel/entity.go
View file

@ -89,9 +89,9 @@ func (e *Entity) Init() *Entity {
} }
// FetchData fetches additional information, meant to be called before persisting an entity record. // FetchData fetches additional information, meant to be called before persisting an entity record.
func (e *Entity) FetchData() { func (e *Entity) FetchData(ctx context.Context) {
e.getLocation() e.getLocation(ctx)
e.getLists() e.getLists(ctx)
} }
// ResetLists resets the current list data and forces // ResetLists resets the current list data and forces
@ -119,18 +119,18 @@ func (e *Entity) ResetLists() {
// ResolveSubDomainLists enables or disables list lookups for // ResolveSubDomainLists enables or disables list lookups for
// sub-domains. // sub-domains.
func (e *Entity) ResolveSubDomainLists(enabled bool) { func (e *Entity) ResolveSubDomainLists(ctx context.Context, enabled bool) {
if e.domainListLoaded { if e.domainListLoaded {
log.Warningf("intel/filterlists: tried to change sub-domain resolving for %s but lists are already fetched", e.Domain) log.Tracer(ctx).Warningf("intel/filterlists: tried to change sub-domain resolving for %s but lists are already fetched", e.Domain)
} }
e.resolveSubDomainLists = enabled e.resolveSubDomainLists = enabled
} }
// EnableCNAMECheck enalbes or disables list lookups for // EnableCNAMECheck enalbes or disables list lookups for
// entity CNAMEs. // entity CNAMEs.
func (e *Entity) EnableCNAMECheck(enabled bool) { func (e *Entity) EnableCNAMECheck(ctx context.Context, enabled bool) {
if e.domainListLoaded { if e.domainListLoaded {
log.Warningf("intel/filterlists: tried to change CNAME resolving for %s but lists are already fetched", e.Domain) log.Tracer(ctx).Warningf("intel/filterlists: tried to change CNAME resolving for %s but lists are already fetched", e.Domain)
} }
e.checkCNAMEs = enabled e.checkCNAMEs = enabled
} }
@ -148,7 +148,7 @@ func (e *Entity) EnableReverseResolving() {
e.reverseResolveEnabled = true e.reverseResolveEnabled = true
} }
func (e *Entity) reverseResolve() { func (e *Entity) reverseResolve(ctx context.Context) {
e.reverseResolveOnce.Do(func() { e.reverseResolveOnce.Do(func() {
// check if we should resolve // check if we should resolve
if !e.reverseResolveEnabled { if !e.reverseResolveEnabled {
@ -165,9 +165,9 @@ func (e *Entity) reverseResolve() {
return return
} }
// TODO: security level // TODO: security level
domain, err := reverseResolver(context.TODO(), e.IP.String(), status.SecurityLevelNormal) domain, err := reverseResolver(ctx, e.IP.String(), status.SecurityLevelNormal)
if err != nil { if err != nil {
log.Warningf("intel: failed to resolve IP %s: %s", e.IP, err) log.Tracer(ctx).Warningf("intel: failed to resolve IP %s: %s", e.IP, err)
return return
} }
e.Domain = domain e.Domain = domain
@ -194,7 +194,7 @@ func (e *Entity) GetIP() (net.IP, bool) {
// Location // Location
func (e *Entity) getLocation() { func (e *Entity) getLocation(ctx context.Context) {
e.fetchLocationOnce.Do(func() { e.fetchLocationOnce.Do(func() {
// need IP! // need IP!
if e.IP == nil { if e.IP == nil {
@ -204,7 +204,7 @@ func (e *Entity) getLocation() {
// get location data // get location data
loc, err := geoip.GetLocation(e.IP) loc, err := geoip.GetLocation(e.IP)
if err != nil { if err != nil {
log.Warningf("intel: failed to get location data for %s: %s", e.IP, err) log.Tracer(ctx).Warningf("intel: failed to get location data for %s: %s", e.IP, err)
return return
} }
e.location = loc e.location = loc
@ -214,8 +214,8 @@ func (e *Entity) getLocation() {
} }
// GetLocation returns the raw location data and whether it is set. // GetLocation returns the raw location data and whether it is set.
func (e *Entity) GetLocation() (*geoip.Location, bool) { func (e *Entity) GetLocation(ctx context.Context) (*geoip.Location, bool) {
e.getLocation() e.getLocation(ctx)
if e.location == nil { if e.location == nil {
return nil, false return nil, false
@ -224,8 +224,8 @@ func (e *Entity) GetLocation() (*geoip.Location, bool) {
} }
// GetCountry returns the two letter ISO country code and whether it is set. // GetCountry returns the two letter ISO country code and whether it is set.
func (e *Entity) GetCountry() (string, bool) { func (e *Entity) GetCountry(ctx context.Context) (string, bool) {
e.getLocation() e.getLocation(ctx)
if e.Country == "" { if e.Country == "" {
return "", false return "", false
@ -234,8 +234,8 @@ func (e *Entity) GetCountry() (string, bool) {
} }
// GetASN returns the AS number and whether it is set. // GetASN returns the AS number and whether it is set.
func (e *Entity) GetASN() (uint, bool) { func (e *Entity) GetASN(ctx context.Context) (uint, bool) {
e.getLocation() e.getLocation(ctx)
if e.ASN == 0 { if e.ASN == 0 {
return 0, false return 0, false
@ -244,11 +244,11 @@ func (e *Entity) GetASN() (uint, bool) {
} }
// Lists // Lists
func (e *Entity) getLists() { func (e *Entity) getLists(ctx context.Context) {
e.getDomainLists() e.getDomainLists(ctx)
e.getASNLists() e.getASNLists(ctx)
e.getIPLists() e.getIPLists(ctx)
e.getCountryLists() e.getCountryLists(ctx)
} }
func (e *Entity) mergeList(key string, list []string) { func (e *Entity) mergeList(key string, list []string) {
@ -263,7 +263,7 @@ func (e *Entity) mergeList(key string, list []string) {
e.ListOccurences[key] = mergeStringList(e.ListOccurences[key], list) e.ListOccurences[key] = mergeStringList(e.ListOccurences[key], list)
} }
func (e *Entity) getDomainLists() { func (e *Entity) getDomainLists(ctx context.Context) {
if e.domainListLoaded { if e.domainListLoaded {
return return
} }
@ -277,7 +277,7 @@ func (e *Entity) getDomainLists() {
var domainsToInspect = []string{domain} var domainsToInspect = []string{domain}
if e.checkCNAMEs { if e.checkCNAMEs {
log.Tracef("intel: CNAME filtering enabled, checking %v too", e.CNAME) log.Tracer(ctx).Tracef("intel: CNAME filtering enabled, checking %v too", e.CNAME)
domainsToInspect = append(domainsToInspect, e.CNAME...) domainsToInspect = append(domainsToInspect, e.CNAME...)
} }
@ -294,10 +294,10 @@ func (e *Entity) getDomainLists() {
domains = makeDistinct(domains) domains = makeDistinct(domains)
for _, d := range domains { for _, d := range domains {
log.Tracef("intel: loading domain list for %s", d) log.Tracer(ctx).Tracef("intel: loading domain list for %s", d)
list, err := filterlists.LookupDomain(d) list, err := filterlists.LookupDomain(d)
if err != nil { if err != nil {
log.Errorf("intel: failed to get domain blocklists for %s: %s", d, err) log.Tracer(ctx).Errorf("intel: failed to get domain blocklists for %s: %s", d, err)
e.loadDomainListOnce = sync.Once{} e.loadDomainListOnce = sync.Once{}
return return
} }
@ -334,22 +334,22 @@ func splitDomain(domain string) []string {
return domains return domains
} }
func (e *Entity) getASNLists() { func (e *Entity) getASNLists(ctx context.Context) {
if e.asnListLoaded { if e.asnListLoaded {
return return
} }
asn, ok := e.GetASN() asn, ok := e.GetASN(ctx)
if !ok { if !ok {
return return
} }
log.Tracef("intel: loading ASN list for %d", asn) log.Tracer(ctx).Tracef("intel: loading ASN list for %d", asn)
e.loadAsnListOnce.Do(func() { e.loadAsnListOnce.Do(func() {
asnStr := fmt.Sprintf("%d", asn) asnStr := fmt.Sprintf("%d", asn)
list, err := filterlists.LookupASNString(asnStr) list, err := filterlists.LookupASNString(asnStr)
if err != nil { if err != nil {
log.Errorf("intel: failed to get ASN blocklist for %d: %s", asn, err) log.Tracer(ctx).Errorf("intel: failed to get ASN blocklist for %d: %s", asn, err)
e.loadAsnListOnce = sync.Once{} e.loadAsnListOnce = sync.Once{}
return return
} }
@ -359,21 +359,21 @@ func (e *Entity) getASNLists() {
}) })
} }
func (e *Entity) getCountryLists() { func (e *Entity) getCountryLists(ctx context.Context) {
if e.countryListLoaded { if e.countryListLoaded {
return return
} }
country, ok := e.GetCountry() country, ok := e.GetCountry(ctx)
if !ok { if !ok {
return return
} }
log.Tracef("intel: loading country list for %s", country) log.Tracer(ctx).Tracef("intel: loading country list for %s", country)
e.loadCoutryListOnce.Do(func() { e.loadCoutryListOnce.Do(func() {
list, err := filterlists.LookupCountry(country) list, err := filterlists.LookupCountry(country)
if err != nil { if err != nil {
log.Errorf("intel: failed to load country blocklist for %s: %s", country, err) log.Tracer(ctx).Errorf("intel: failed to load country blocklist for %s: %s", country, err)
e.loadCoutryListOnce = sync.Once{} e.loadCoutryListOnce = sync.Once{}
return return
} }
@ -383,7 +383,7 @@ func (e *Entity) getCountryLists() {
}) })
} }
func (e *Entity) getIPLists() { func (e *Entity) getIPLists(ctx context.Context) {
if e.ipListLoaded { if e.ipListLoaded {
return return
} }
@ -402,12 +402,12 @@ func (e *Entity) getIPLists() {
return return
} }
log.Tracef("intel: loading IP list for %s", ip) log.Tracer(ctx).Tracef("intel: loading IP list for %s", ip)
e.loadIPListOnce.Do(func() { e.loadIPListOnce.Do(func() {
list, err := filterlists.LookupIP(ip) list, err := filterlists.LookupIP(ip)
if err != nil { if err != nil {
log.Errorf("intel: failed to get IP blocklist for %s: %s", ip.String(), err) log.Tracer(ctx).Errorf("intel: failed to get IP blocklist for %s: %s", ip.String(), err)
e.loadIPListOnce = sync.Once{} e.loadIPListOnce = sync.Once{}
return return
} }
@ -418,8 +418,8 @@ func (e *Entity) getIPLists() {
// LoadLists searches all filterlists for all occurrences of // LoadLists searches all filterlists for all occurrences of
// this entity. // this entity.
func (e *Entity) LoadLists() bool { func (e *Entity) LoadLists(ctx context.Context) bool {
e.getLists() e.getLists(ctx)
return e.ListOccurences != nil return e.ListOccurences != nil
} }

3
intel/geoip/lookup.go
View file

@ -4,7 +4,6 @@ import (
"net" "net"
"github.com/oschwald/maxminddb-golang" "github.com/oschwald/maxminddb-golang"
"github.com/safing/portbase/log"
) )
func getReader(ip net.IP) *maxminddb.Reader { func getReader(ip net.IP) *maxminddb.Reader {
@ -49,7 +48,5 @@ func GetLocation(ip net.IP) (record *Location, err error) {
return nil, err return nil, err
} }
log.Tracef("geoip: record: %+v", record)
return record, nil return record, nil
} }

12
nameserver/nameserver.go
View file

@ -76,12 +76,15 @@ func handleRequestAsWorker(w dns.ResponseWriter, query *dns.Msg) {
return handleRequest(ctx, w, query) return handleRequest(ctx, w, query)
}) })
if err != nil { if err != nil {
log.Warningf("intel: failed to handle dns request: %s", err) log.Warningf("nameserver: failed to handle dns request: %s", err)
} }
} }
func handleRequest(ctx context.Context, w dns.ResponseWriter, request *dns.Msg) error { //nolint:gocognit // TODO func handleRequest(ctx context.Context, w dns.ResponseWriter, request *dns.Msg) error { //nolint:gocognit // TODO
// Only process first question, that's how everyone does it. // Only process first question, that's how everyone does it.
if len(request.Question) == 0 {
return errors.New("missing question")
}
originalQuestion := request.Question[0] originalQuestion := request.Question[0]
// Check if we are handling a non-standard query name. // Check if we are handling a non-standard query name.
@ -116,7 +119,12 @@ func handleRequest(ctx context.Context, w dns.ResponseWriter, request *dns.Msg)
// Setup quick reply function. // Setup quick reply function.
reply := func(responder nsutil.Responder, rrProviders ...nsutil.RRProvider) error { reply := func(responder nsutil.Responder, rrProviders ...nsutil.RRProvider) error {
return sendResponse(ctx, w, request, responder, rrProviders...) err := sendResponse(ctx, w, request, responder, rrProviders...)
// Log error here instead of returning it in order to keep the context.
if err != nil {
tracer.Errorf("nameserver: %s", err)
}
return nil
} }
// Return with server failure if offline. // Return with server failure if offline.

11
nameserver/response.go
View file

@ -36,19 +36,19 @@ func sendResponse(
} }
// Write reply. // Write reply.
if err := writeDNSResponse(w, reply); err != nil { if err := writeDNSResponse(ctx, w, reply); err != nil {
return fmt.Errorf("nameserver: failed to send response: %w", err) return fmt.Errorf("failed to send response: %w", err)
} }
return nil return nil
} }
func writeDNSResponse(w dns.ResponseWriter, m *dns.Msg) (err error) { func writeDNSResponse(ctx context.Context, w dns.ResponseWriter, m *dns.Msg) (err error) {
defer func() { defer func() {
// recover from panic // recover from panic
if panicErr := recover(); panicErr != nil { if panicErr := recover(); panicErr != nil {
err = fmt.Errorf("panic: %s", panicErr) err = fmt.Errorf("panic: %s", panicErr)
log.Warningf("nameserver: panic caused by this msg: %#v", m) log.Tracer(ctx).Debugf("nameserver: panic caused by this msg: %#v", m)
} }
}() }()
@ -56,10 +56,11 @@ func writeDNSResponse(w dns.ResponseWriter, m *dns.Msg) (err error) {
if err != nil { if err != nil {
// If we receive an error we might have exceeded the message size with all // If we receive an error we might have exceeded the message size with all
// our extra information records. Retry again without the extra section. // our extra information records. Retry again without the extra section.
log.Tracer(ctx).Tracef("nameserver: retrying to write dns message without extra section, error was: %s", err)
m.Extra = nil m.Extra = nil
noExtraErr := w.WriteMsg(m) noExtraErr := w.WriteMsg(m)
if noExtraErr == nil { if noExtraErr == nil {
log.Warningf("nameserver: failed to write dns message with extra section: %s", err) return fmt.Errorf("failed to write dns message without extra section: %w", err)
} }
} }
return return

22
network/connection.go
View file

@ -80,7 +80,7 @@ func NewConnectionFromDNSRequest(ctx context.Context, fqdn string, cnames []stri
}, },
) )
if err != nil { if err != nil {
log.Debugf("network: failed to find process of dns request for %s: %s", fqdn, err) log.Tracer(ctx).Debugf("network: failed to find process of dns request for %s: %s", fqdn, err)
proc = process.GetUnidentifiedProcess(ctx) proc = process.GetUnidentifiedProcess(ctx)
} }
@ -103,7 +103,7 @@ func NewConnectionFromFirstPacket(pkt packet.Packet) *Connection {
// get Process // get Process
proc, inbound, err := process.GetProcessByConnection(pkt.Ctx(), pkt.Info()) proc, inbound, err := process.GetProcessByConnection(pkt.Ctx(), pkt.Info())
if err != nil { if err != nil {
log.Debugf("network: failed to find process of packet %s: %s", pkt, err) log.Tracer(pkt.Ctx()).Debugf("network: failed to find process of packet %s: %s", pkt, err)
proc = process.GetUnidentifiedProcess(pkt.Ctx()) proc = process.GetUnidentifiedProcess(pkt.Ctx())
} }
@ -203,9 +203,7 @@ func GetConnection(id string) (*Connection, bool) {
// AcceptWithContext accepts the connection. // AcceptWithContext accepts the connection.
func (conn *Connection) AcceptWithContext(reason string, ctx interface{}) { func (conn *Connection) AcceptWithContext(reason string, ctx interface{}) {
if conn.SetVerdict(VerdictAccept, reason, ctx) { if !conn.SetVerdict(VerdictAccept, reason, ctx) {
log.Infof("filter: granting connection %s, %s", conn, conn.Reason)
} else {
log.Warningf("filter: tried to accept %s, but current verdict is %s", conn, conn.Verdict) log.Warningf("filter: tried to accept %s, but current verdict is %s", conn, conn.Verdict)
} }
} }
@ -217,9 +215,7 @@ func (conn *Connection) Accept(reason string) {
// BlockWithContext blocks the connection. // BlockWithContext blocks the connection.
func (conn *Connection) BlockWithContext(reason string, ctx interface{}) { func (conn *Connection) BlockWithContext(reason string, ctx interface{}) {
if conn.SetVerdict(VerdictBlock, reason, ctx) { if !conn.SetVerdict(VerdictBlock, reason, ctx) {
log.Infof("filter: blocking connection %s, %s", conn, conn.Reason)
} else {
log.Warningf("filter: tried to block %s, but current verdict is %s", conn, conn.Verdict) log.Warningf("filter: tried to block %s, but current verdict is %s", conn, conn.Verdict)
} }
} }
@ -231,9 +227,7 @@ func (conn *Connection) Block(reason string) {
// DropWithContext drops the connection. // DropWithContext drops the connection.
func (conn *Connection) DropWithContext(reason string, ctx interface{}) { func (conn *Connection) DropWithContext(reason string, ctx interface{}) {
if conn.SetVerdict(VerdictDrop, reason, ctx) { if !conn.SetVerdict(VerdictDrop, reason, ctx) {
log.Infof("filter: dropping connection %s, %s", conn, conn.Reason)
} else {
log.Warningf("filter: tried to drop %s, but current verdict is %s", conn, conn.Verdict) log.Warningf("filter: tried to drop %s, but current verdict is %s", conn, conn.Verdict)
} }
} }
@ -259,9 +253,7 @@ func (conn *Connection) Deny(reason string) {
// FailedWithContext marks the connection with VerdictFailed and stores the reason. // FailedWithContext marks the connection with VerdictFailed and stores the reason.
func (conn *Connection) FailedWithContext(reason string, ctx interface{}) { func (conn *Connection) FailedWithContext(reason string, ctx interface{}) {
if conn.SetVerdict(VerdictFailed, reason, ctx) { if !conn.SetVerdict(VerdictFailed, reason, ctx) {
log.Infof("filter: dropping connection %s because of an internal error: %s", conn, reason)
} else {
log.Warningf("filter: tried to drop %s due to error but current verdict is %s", conn, conn.Verdict) log.Warningf("filter: tried to drop %s due to error but current verdict is %s", conn, conn.Verdict)
} }
} }
@ -401,6 +393,8 @@ func (conn *Connection) packetHandler() {
} else { } else {
defaultFirewallHandler(conn, pkt) defaultFirewallHandler(conn, pkt)
} }
// log verdict
log.Tracer(pkt.Ctx()).Infof("filter: connection %s %s: %s", conn, conn.Verdict.Verb(), conn.Reason)
conn.Unlock() conn.Unlock()
// save does not touch any changing data // save does not touch any changing data
// must not be locked, will deadlock with cleaner functions // must not be locked, will deadlock with cleaner functions

8
profile/endpoints/endpoint-any.go
View file

@ -1,6 +1,10 @@
package endpoints package endpoints
import "github.com/safing/portmaster/intel" import (
"context"
"github.com/safing/portmaster/intel"
)
// EndpointAny matches anything. // EndpointAny matches anything.
type EndpointAny struct { type EndpointAny struct {
@ -8,7 +12,7 @@ type EndpointAny struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointAny) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointAny) Matches(_ context.Context, entity *intel.Entity) (EPResult, Reason) {
return ep.match(ep, entity, "*", "matches") return ep.match(ep, entity, "*", "matches")
} }

5
profile/endpoints/endpoint-asn.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"fmt" "fmt"
"regexp" "regexp"
"strconv" "strconv"
@ -20,8 +21,8 @@ type EndpointASN struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointASN) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointASN) Matches(ctx context.Context, entity *intel.Entity) (EPResult, Reason) {
asn, ok := entity.GetASN() asn, ok := entity.GetASN(ctx)
if !ok { if !ok {
return Undeterminable, nil return Undeterminable, nil
} }

5
profile/endpoints/endpoint-country.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"regexp" "regexp"
"strings" "strings"
@ -19,8 +20,8 @@ type EndpointCountry struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointCountry) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointCountry) Matches(ctx context.Context, entity *intel.Entity) (EPResult, Reason) {
country, ok := entity.GetCountry() country, ok := entity.GetCountry(ctx)
if !ok { if !ok {
return Undeterminable, nil return Undeterminable, nil
} }

1
profile/endpoints/endpoint-domain.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"regexp" "regexp"
"strings" "strings"

3
profile/endpoints/endpoint-ip.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"net" "net"
"github.com/safing/portmaster/intel" "github.com/safing/portmaster/intel"
@ -14,7 +15,7 @@ type EndpointIP struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointIP) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointIP) Matches(_ context.Context, entity *intel.Entity) (EPResult, Reason) {
if entity.IP == nil { if entity.IP == nil {
return Undeterminable, nil return Undeterminable, nil
} }

3
profile/endpoints/endpoint-iprange.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"net" "net"
"github.com/safing/portmaster/intel" "github.com/safing/portmaster/intel"
@ -14,7 +15,7 @@ type EndpointIPRange struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointIPRange) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointIPRange) Matches(_ context.Context, entity *intel.Entity) (EPResult, Reason) {
if entity.IP == nil { if entity.IP == nil {
return Undeterminable, nil return Undeterminable, nil
} }

5
profile/endpoints/endpoint-lists.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"strings" "strings"
"github.com/safing/portmaster/intel" "github.com/safing/portmaster/intel"
@ -15,8 +16,8 @@ type EndpointLists struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointLists) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointLists) Matches(ctx context.Context, entity *intel.Entity) (EPResult, Reason) {
if !entity.LoadLists() { if !entity.LoadLists(ctx) {
return Undeterminable, nil return Undeterminable, nil
} }

3
profile/endpoints/endpoint-scopes.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"strings" "strings"
"github.com/safing/portmaster/network/netutils" "github.com/safing/portmaster/network/netutils"
@ -30,7 +31,7 @@ type EndpointScope struct {
} }
// Matches checks whether the given entity matches this endpoint definition. // Matches checks whether the given entity matches this endpoint definition.
func (ep *EndpointScope) Matches(entity *intel.Entity) (EPResult, Reason) { func (ep *EndpointScope) Matches(_ context.Context, entity *intel.Entity) (EPResult, Reason) {
if entity.IP == nil { if entity.IP == nil {
return Undeterminable, nil return Undeterminable, nil
} }

3
profile/endpoints/endpoint.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"fmt" "fmt"
"strconv" "strconv"
"strings" "strings"
@ -11,7 +12,7 @@ import (
// Endpoint describes an Endpoint Matcher // Endpoint describes an Endpoint Matcher
type Endpoint interface { type Endpoint interface {
Matches(entity *intel.Entity) (EPResult, Reason) Matches(ctx context.Context, entity *intel.Entity) (EPResult, Reason)
String() string String() string
} }

5
profile/endpoints/endpoints.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"fmt" "fmt"
"strings" "strings"
@ -63,10 +64,10 @@ func (e Endpoints) IsSet() bool {
} }
// Match checks whether the given entity matches any of the endpoint definitions in the list. // Match checks whether the given entity matches any of the endpoint definitions in the list.
func (e Endpoints) Match(entity *intel.Entity) (result EPResult, reason Reason) { func (e Endpoints) Match(ctx context.Context, entity *intel.Entity) (result EPResult, reason Reason) {
for _, entry := range e { for _, entry := range e {
if entry != nil { if entry != nil {
if result, reason = entry.Matches(entity); result != NoMatch { if result, reason = entry.Matches(ctx, entity); result != NoMatch {
return return
} }
} }

3
profile/endpoints/endpoints_test.go
View file

@ -1,6 +1,7 @@
package endpoints package endpoints
import ( import (
"context"
"net" "net"
"runtime" "runtime"
"testing" "testing"
@ -16,7 +17,7 @@ func TestMain(m *testing.M) {
} }
func testEndpointMatch(t *testing.T, ep Endpoint, entity *intel.Entity, expectedResult EPResult) { func testEndpointMatch(t *testing.T, ep Endpoint, entity *intel.Entity, expectedResult EPResult) {
result, _ := ep.Matches(entity) result, _ := ep.Matches(context.TODO(), entity)
if result != expectedResult { if result != expectedResult {
t.Errorf( t.Errorf(
"line %d: unexpected result for endpoint %s and entity %+v: result=%s, expected=%s", "line %d: unexpected result for endpoint %s and entity %+v: result=%s, expected=%s",

23
profile/profile-layered.go
View file

@ -1,6 +1,7 @@
package profile package profile
import ( import (
"context"
"sync" "sync"
"sync/atomic" "sync/atomic"
@ -221,10 +222,10 @@ func (lp *LayeredProfile) DefaultAction() uint8 {
} }
// MatchEndpoint checks if the given endpoint matches an entry in any of the profiles. // MatchEndpoint checks if the given endpoint matches an entry in any of the profiles.
func (lp *LayeredProfile) MatchEndpoint(entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) { func (lp *LayeredProfile) MatchEndpoint(ctx context.Context, entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) {
for _, layer := range lp.layers { for _, layer := range lp.layers {
if layer.endpoints.IsSet() { if layer.endpoints.IsSet() {
result, reason := layer.endpoints.Match(entity) result, reason := layer.endpoints.Match(ctx, entity)
if endpoints.IsDecision(result) { if endpoints.IsDecision(result) {
return result, reason return result, reason
} }
@ -233,16 +234,16 @@ func (lp *LayeredProfile) MatchEndpoint(entity *intel.Entity) (endpoints.EPResul
cfgLock.RLock() cfgLock.RLock()
defer cfgLock.RUnlock() defer cfgLock.RUnlock()
return cfgEndpoints.Match(entity) return cfgEndpoints.Match(ctx, entity)
} }
// MatchServiceEndpoint checks if the given endpoint of an inbound connection matches an entry in any of the profiles. // MatchServiceEndpoint checks if the given endpoint of an inbound connection matches an entry in any of the profiles.
func (lp *LayeredProfile) MatchServiceEndpoint(entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) { func (lp *LayeredProfile) MatchServiceEndpoint(ctx context.Context, entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) {
entity.EnableReverseResolving() entity.EnableReverseResolving()
for _, layer := range lp.layers { for _, layer := range lp.layers {
if layer.serviceEndpoints.IsSet() { if layer.serviceEndpoints.IsSet() {
result, reason := layer.serviceEndpoints.Match(entity) result, reason := layer.serviceEndpoints.Match(ctx, entity)
if endpoints.IsDecision(result) { if endpoints.IsDecision(result) {
return result, reason return result, reason
} }
@ -251,19 +252,19 @@ func (lp *LayeredProfile) MatchServiceEndpoint(entity *intel.Entity) (endpoints.
cfgLock.RLock() cfgLock.RLock()
defer cfgLock.RUnlock() defer cfgLock.RUnlock()
return cfgServiceEndpoints.Match(entity) return cfgServiceEndpoints.Match(ctx, entity)
} }
// MatchFilterLists matches the entity against the set of filter // MatchFilterLists matches the entity against the set of filter
// lists. // lists.
func (lp *LayeredProfile) MatchFilterLists(entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) { func (lp *LayeredProfile) MatchFilterLists(ctx context.Context, entity *intel.Entity) (endpoints.EPResult, endpoints.Reason) {
entity.ResolveSubDomainLists(lp.FilterSubDomains()) entity.ResolveSubDomainLists(ctx, lp.FilterSubDomains())
entity.EnableCNAMECheck(lp.FilterCNAMEs()) entity.EnableCNAMECheck(ctx, lp.FilterCNAMEs())
for _, layer := range lp.layers { for _, layer := range lp.layers {
// search for the first layer that has filterListIDs set // search for the first layer that has filterListIDs set
if len(layer.filterListIDs) > 0 { if len(layer.filterListIDs) > 0 {
entity.LoadLists() entity.LoadLists(ctx)
if entity.MatchLists(layer.filterListIDs) { if entity.MatchLists(layer.filterListIDs) {
return endpoints.Denied, entity.ListBlockReason() return endpoints.Denied, entity.ListBlockReason()
@ -276,7 +277,7 @@ func (lp *LayeredProfile) MatchFilterLists(entity *intel.Entity) (endpoints.EPRe
cfgLock.RLock() cfgLock.RLock()
defer cfgLock.RUnlock() defer cfgLock.RUnlock()
if len(cfgFilterLists) > 0 { if len(cfgFilterLists) > 0 {
entity.LoadLists() entity.LoadLists(ctx)
if entity.MatchLists(cfgFilterLists) { if entity.MatchLists(cfgFilterLists) {
return endpoints.Denied, entity.ListBlockReason() return endpoints.Denied, entity.ListBlockReason()