diff --git a/firewall/firewall.go b/firewall/firewall.go index e8675455..41c5c2e5 100644 --- a/firewall/firewall.go +++ b/firewall/firewall.go @@ -146,6 +146,7 @@ func handlePacket(pkt packet.Packet) { pkt.PermanentAccept() return } + // TODO: Howto handle NetBios? } // log.Debugf("firewall: pkt %s has ID %s", pkt, pkt.GetLinkID()) @@ -268,6 +269,7 @@ func initialHandler(pkt packet.Packet, link *network.Link) { // link.StopFirewallHandler() // permanentVerdict(pkt, network.VerdictAccept) case link.Inspect: + log.Tracer(pkt.Ctx()).Trace("firewall: start inspecting") link.SetFirewallHandler(inspectThenVerdict) inspectThenVerdict(pkt, link) default: diff --git a/firewall/inspection/inspection.go b/firewall/inspection/inspection.go index 3ecd23cc..cce18084 100644 --- a/firewall/inspection/inspection.go +++ b/firewall/inspection/inspection.go @@ -64,7 +64,7 @@ func RunInspectors(pkt packet.Packet, link *network.Link) (network.Verdict, bool continue } - action := inspectors[key](pkt, link) + action := inspectors[key](pkt, link) // Actually run inspector switch action { case DO_NOTHING: if verdict < network.VerdictAccept { diff --git a/status/threat.go b/status/threat.go index f829e91c..e6462895 100644 --- a/status/threat.go +++ b/status/threat.go @@ -14,6 +14,7 @@ type Threat struct { MitigationLevel uint8 // Recommended Security Level to switch to for mitigation Started int64 Ended int64 + // TODO: add locking } // AddOrUpdateThreat adds or updates a new threat in the system status.