vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-02 18:49:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add missing TODOs

Browse source
This commit is contained in:
Vladimir Stoilov 2024-12-10 14:21:34 +02:00
parent be62c788de
commit c21a93a4d6
No known key found for this signature in database
GPG key ID: 2F190B67A43A81AF
2 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
desktop/tauri/src-tauri/src/main.rs
View file

@ -126,6 +126,7 @@ fn main() {
let cli_args = cli::parse(std::env::args()); let cli_args = cli::parse(std::env::args());
// TODO(vladimir): Support for other log targets?
#[cfg(target_os = "linux")] #[cfg(target_os = "linux")]
let log_target = tauri_plugin_log::Target::new(tauri_plugin_log::TargetKind::Stdout); let log_target = tauri_plugin_log::Target::new(tauri_plugin_log::TargetKind::Stdout);
// let log_target = if let Some(data_dir) = cli_args.data { // let log_target = if let Some(data_dir) = cli_args.data {

3
service/intel/filterlists/index.go
View file

@ -182,11 +182,13 @@ func updateListIndex() error {
// Check if the version in the cache is current. // Check if the version in the cache is current.
_, err = getListIndexFromCache() _, err = getListIndexFromCache()
// index, err = getListIndexFromCache()
switch { switch {
case errors.Is(err, database.ErrNotFound): case errors.Is(err, database.ErrNotFound):
log.Info("filterlists: index not in cache, starting update") log.Info("filterlists: index not in cache, starting update")
case err != nil: case err != nil:
log.Warningf("filterlists: failed to load index from cache, starting update: %s", err) log.Warningf("filterlists: failed to load index from cache, starting update: %s", err)
// TODO(vladimir): Change so it fits the new updater
// case !listIndexUpdate.EqualsVersion(strings.TrimPrefix(index.Version, "v")): // case !listIndexUpdate.EqualsVersion(strings.TrimPrefix(index.Version, "v")):
// log.Infof( // log.Infof(
// "filterlists: index from cache is outdated, starting update (%s != %s)", // "filterlists: index from cache is outdated, starting update (%s != %s)",
@ -238,6 +240,7 @@ func updateListIndex() error {
func ResolveListIDs(ids []string) ([]string, error) { func ResolveListIDs(ids []string) ([]string, error) {
index, err := getListIndexFromCache() index, err := getListIndexFromCache()
if err != nil { if err != nil {
// FIXME(vladimir): Fix the stack overflow bug
// if errors.Is(err, database.ErrNotFound) { // if errors.Is(err, database.ErrNotFound) {
// if err := updateListIndex(); err != nil { // if err := updateListIndex(); err != nil {
// return nil, err // return nil, err