vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-04 11:39:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix access on undefined object in line-chart

Browse source
This commit is contained in:
Patrick Pacher 2024-03-29 09:37:01 +01:00
parent 3d88b3fd3b
commit a148eb57a9
No known key found for this signature in database
GPG key ID: E8CD2DA160925A6D
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
desktop/angular/src/app/shared/netquery/line-chart/line-chart.ts
View file

@ -188,12 +188,12 @@ export class SfngNetqueryLineChartComponent<D extends SeriesData = any> implemen
} }
ngOnChanges(changes: SimpleChanges): void { ngOnChanges(changes: SimpleChanges): void {
if (changes.hasOwnProperty('config') && this.config) { if (Object.prototype.hasOwnProperty.call(changes, 'config') && this.config) {
this.redraw() this.redraw()
return return
} }
if (changes.hasOwnProperty('data') && this.data) { if (Object.prototype.hasOwnProperty.call(changes, 'data') && this.data) {
this.drawChart(); this.drawChart();
} }
} }
@ -398,9 +398,9 @@ export class SfngNetqueryLineChartComponent<D extends SeriesData = any> implemen
const interval = this.config.fillEmptyTicks.interval; const interval = this.config.fillEmptyTicks.interval;
let filledData: D[] = []; const filledData: D[] = [];
const addEmpty = (ts: number) => { const addEmpty = (ts: number) => {
let empty: any = { const empty: any = {
timestamp: ts, timestamp: ts,
} }
@ -410,7 +410,11 @@ export class SfngNetqueryLineChartComponent<D extends SeriesData = any> implemen
filledData.push(empty) filledData.push(empty)
} }
let firstElement = data[0]!.timestamp; if (!data.length) {
return [];
}
let firstElement = data[0].timestamp;
if (this.config.time?.from) { if (this.config.time?.from) {
firstElement = Math.round(coerceDate(this.config.time.from).getTime() / 1000) firstElement = Math.round(coerceDate(this.config.time.from).getTime() / 1000)
} }