vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-02 02:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Implement review suggestions

Browse source
This commit is contained in:
Daniel 2022-03-22 13:55:46 +01:00
parent ef64acd271
commit 90a113397f
3 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
nameserver/response.go
View file

@ -28,6 +28,8 @@ func sendResponse(
return nil return nil
} }
// Signify that we are a recursive resolver. // Signify that we are a recursive resolver.
// While we do not handle recursion directly, we can safely assume, that we
// always forward to a recursive resolver.
reply.RecursionAvailable = true reply.RecursionAvailable = true
// Add extra RRs through a custom RRProvider. // Add extra RRs through a custom RRProvider.

3
resolver/resolvers.go
View file

@ -205,12 +205,15 @@ func createResolver(resolverURL, source string) (*Resolver, bool, error) {
} }
func configureSearchDomains(resolver *Resolver, searches []string, hardfail bool) error { func configureSearchDomains(resolver *Resolver, searches []string, hardfail bool) error {
resolver.Search = make([]string, 0, len(searches))
// Check all search domains. // Check all search domains.
for i, value := range searches { for i, value := range searches {
trimmedDomain := strings.ToLower(strings.Trim(value, ".")) trimmedDomain := strings.ToLower(strings.Trim(value, "."))
err := checkSearchScope(trimmedDomain) err := checkSearchScope(trimmedDomain)
if err != nil { if err != nil {
if hardfail { if hardfail {
resolver.Search = nil
return fmt.Errorf("failed to validate search domain #%d: %w", i+1, err) return fmt.Errorf("failed to validate search domain #%d: %w", i+1, err)
} }
log.Warningf("resolver: skipping invalid search domain for resolver %s: %s", resolver, utils.SafeFirst16Chars(value)) log.Warningf("resolver: skipping invalid search domain for resolver %s: %s", resolver, utils.SafeFirst16Chars(value))

1
updates/upgrader.go
View file

@ -117,6 +117,7 @@ func upgradeCoreNotify() error {
), ),
ShowOnSystem: true, ShowOnSystem: true,
AvailableActions: []*notifications.Action{ AvailableActions: []*notifications.Action{
// TODO: Use special UI action in order to reload UI on restart.
{ {
ID: "restart", ID: "restart",
Text: "Restart", Text: "Restart",