vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-02 02:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve udp connection attribution for broadcast and multicast packets

Browse source
This commit is contained in:
Daniel 2020-05-18 14:29:04 +02:00
parent 89317b8848
commit 85c7fd4af7
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
network/state/lookup.go
View file

@ -6,6 +6,7 @@ import (
"sync" "sync"
"time" "time"
"github.com/safing/portmaster/network/netutils"
"github.com/safing/portmaster/network/packet" "github.com/safing/portmaster/network/packet"
"github.com/safing/portmaster/network/socket" "github.com/safing/portmaster/network/socket"
) )
@ -160,12 +161,20 @@ func searchUDP(
err error, err error,
) { ) {
isInboundMulticast := pktInbound && netutils.ClassifyIP(localIP) == netutils.LocalMulticast
// TODO: Currently broadcast/multicast scopes are not checked, so we might
// attribute an incoming broadcast/multicast packet to the wrong process if
// there are multiple processes listening on the same local port, but
// binding to different addresses. This highly unusual for clients.
// search until we find something // search until we find something
for i := 0; i < 5; i++ { for i := 0; i < 5; i++ {
// search binds // search binds
for _, socketInfo := range binds { for _, socketInfo := range binds {
if localPort == socketInfo.Local.Port && if localPort == socketInfo.Local.Port &&
(socketInfo.Local.IP[0] == 0 || localIP.Equal(socketInfo.Local.IP)) { (socketInfo.Local.IP[0] == 0 || // zero IP
isInboundMulticast || // inbound broadcast, multicast
localIP.Equal(socketInfo.Local.IP)) {
// do not check direction if remoteIP/Port is not given // do not check direction if remoteIP/Port is not given
if remotePort == 0 { if remotePort == 0 {