vikarti.anatra/safing-portmaster
1
0
Fork 0
mirror of https://github.com/safing/portmaster synced 2025-09-04 03:29:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[service] Always put ICMP in the Other Connections group instead of Network Noise

Browse source
This commit is contained in:
Daniel 2024-05-28 16:32:28 +02:00
parent 47f805ce00
commit 7e4e4c47a8
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
service/process/find.go
View file

@ -10,6 +10,7 @@ import (
"github.com/safing/portbase/log" "github.com/safing/portbase/log"
"github.com/safing/portmaster/service/network/netutils" "github.com/safing/portmaster/service/network/netutils"
"github.com/safing/portmaster/service/network/packet" "github.com/safing/portmaster/service/network/packet"
"github.com/safing/portmaster/service/network/reference"
"github.com/safing/portmaster/service/network/state" "github.com/safing/portmaster/service/network/state"
"github.com/safing/portmaster/service/profile" "github.com/safing/portmaster/service/profile"
) )
@ -77,10 +78,22 @@ func GetPidOfConnection(ctx context.Context, pktInfo *packet.Info) (pid int, con
// Fallback to special profiles if PID could not be found. // Fallback to special profiles if PID could not be found.
if pid == UndefinedProcessID { if pid == UndefinedProcessID {
if connInbound && !netutils.ClassifyIP(pktInfo.Dst).IsLocalhost() { switch {
pid = UnsolicitedProcessID case !connInbound:
} else {
pid = UnidentifiedProcessID pid = UnidentifiedProcessID
case netutils.ClassifyIP(pktInfo.Dst).IsLocalhost():
// Always treat localhost connections as unidentified/unknown.
pid = UnidentifiedProcessID
case reference.IsICMP(uint8(pktInfo.Protocol)):
// Always treat ICMP as unidentified/unknown, as the direction
// might change to outgoing by new ICMP echo packets.
pid = UnidentifiedProcessID
default:
// All other inbound connections are "unsolicited".
pid = UnsolicitedProcessID
} }
} }