From 6251111cdfdd46763e991d1d2d0edd069c9c739f Mon Sep 17 00:00:00 2001 From: Alexandr Stelnykovych Date: Fri, 12 Apr 2024 16:38:49 +0300 Subject: [PATCH] [fix] (Windows;performance) Ineffective break statement. Did you mean to break out of the outer loop? --- service/network/iphelper/tables.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/service/network/iphelper/tables.go b/service/network/iphelper/tables.go index 9e082173..b221d2ef 100644 --- a/service/network/iphelper/tables.go +++ b/service/network/iphelper/tables.go @@ -214,7 +214,7 @@ func (ipHelper *IPHelper) getTable(ipVersion, protocol uint8) (connections []*so maxTries := 5 usedBufSize := lbf.getBufSize() var buf []byte - +triesLoop: for i := 1; i <= maxTries; i++ { bufSizeParam := usedBufSize buf = make([]byte, bufSizeParam) @@ -256,7 +256,7 @@ func (ipHelper *IPHelper) getTable(ipVersion, protocol uint8) (connections []*so return nil, nil, fmt.Errorf("invalid parameter: [NT 0x%X] %s", r1, err) case windows.NO_ERROR: // success - break + break triesLoop default: return nil, nil, fmt.Errorf("unexpected error: [NT 0x%X] %s", r1, err) }