Update based on portbase review suggestions

This commit is contained in:
Daniel 2021-01-06 13:35:25 +01:00
parent 72c7592cdd
commit 60ac9af5f2
4 changed files with 12 additions and 12 deletions

View file

@ -9,17 +9,17 @@ import (
func registerActions() error {
if err := api.RegisterEndpoint(api.Endpoint{
Path: "core/shutdown",
Read: api.PermitSelf,
ActionFn: shutdown,
Path: "core/shutdown",
Read: api.PermitSelf,
ActionFunc: shutdown,
}); err != nil {
return err
}
if err := api.RegisterEndpoint(api.Endpoint{
Path: "core/restart",
Read: api.PermitSelf,
ActionFn: restart,
Path: "core/restart",
Read: api.PermitSelf,
ActionFunc: restart,
}); err != nil {
return err
}

View file

@ -59,7 +59,7 @@ func startAPIAuth() {
log.Tracef("filter: api port set to %d", apiPort)
}
func apiAuthenticator(ctx context.Context, s *http.Server, r *http.Request) (token *api.AuthToken, err error) {
func apiAuthenticator(r *http.Request, s *http.Server) (token *api.AuthToken, err error) {
if devMode() {
return &api.AuthToken{
Read: api.PermitSelf,
@ -85,7 +85,7 @@ func apiAuthenticator(ctx context.Context, s *http.Server, r *http.Request) (tok
var retry bool
for tries := 0; tries < 20; tries++ {
retry, err = authenticateAPIRequest(
ctx,
r.Context(),
&packet.Info{
Inbound: false, // outbound as we are looking for the process of the source address
Version: packet.IPv4,

View file

@ -80,9 +80,9 @@ func start() error {
// Register api endpoint to clear DNS cache.
if err := api.RegisterEndpoint(api.Endpoint{
Path: "dns/clear/namecache",
Read: api.PermitUser,
ActionFn: clearNameCache,
Path: "dns/clear/namecache",
Read: api.PermitUser,
ActionFunc: clearNameCache,
}); err != nil {
return err
}

View file

@ -109,7 +109,7 @@ func (rec *NameRecord) Save() error {
func clearNameCache(ar *api.Request) (msg string, err error) {
log.Warning("resolver: user requested dns cache clearing via action")
n, err := recordDatabase.Purge(ar.Ctx(), query.New(nameRecordsKeyPrefix))
n, err := recordDatabase.Purge(ar.Context(), query.New(nameRecordsKeyPrefix))
if err != nil {
return "", err
}