Merge pull request #164 from safing/fix/perm-verdict-description

Improve Permanent Verdicts description.
This commit is contained in:
Patrick Pacher 2020-09-30 08:28:19 +02:00 committed by GitHub
commit 278846a5b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View file

@ -29,10 +29,10 @@ func registerConfig() error {
err := config.Register(&config.Option{ err := config.Register(&config.Option{
Name: "Permanent Verdicts", Name: "Permanent Verdicts",
Key: CfgOptionPermanentVerdictsKey, Key: CfgOptionPermanentVerdictsKey,
Description: "With permanent verdicts, control of a connection is fully handed back to the OS after the initial decision. This brings a great performance increase, but makes it impossible to change the decision of a link later on.", Description: "With permanent verdicts, control of a connection is fully handed back to the OS after the initial decision in order to drastically increase performance.",
Order: CfgOptionPermanentVerdictsOrder, Order: CfgOptionPermanentVerdictsOrder,
OptType: config.OptTypeBool, OptType: config.OptTypeBool,
ExpertiseLevel: config.ExpertiseLevelExpert, ExpertiseLevel: config.ExpertiseLevelDeveloper,
ReleaseLevel: config.ReleaseLevelExperimental, ReleaseLevel: config.ReleaseLevelExperimental,
DefaultValue: true, DefaultValue: true,
}) })

View file

@ -288,7 +288,7 @@ func issueVerdict(conn *network.Connection, pkt packet.Packet, verdict network.V
err = pkt.RerouteToTunnel() err = pkt.RerouteToTunnel()
case network.VerdictFailed: case network.VerdictFailed:
atomic.AddUint64(packetsFailed, 1) atomic.AddUint64(packetsFailed, 1)
fallthrough err = pkt.Drop()
default: default:
atomic.AddUint64(packetsDropped, 1) atomic.AddUint64(packetsDropped, 1)
err = pkt.Drop() err = pkt.Drop()