mirror of
https://github.com/safing/portbase
synced 2025-09-10 23:34:42 +00:00
Fix locking when updating the interface cache in Put methods
Also, update the cache when fetching records from the database.
This commit is contained in:
parent
85e985c493
commit
ac1e00b0fe
2 changed files with 27 additions and 8 deletions
|
@ -188,6 +188,16 @@ func (i *Interface) getRecord(dbName string, dbKey string, mustBeWriteable bool)
|
|||
return nil, db, ErrPermissionDenied
|
||||
}
|
||||
|
||||
r.Lock()
|
||||
ttl := r.Meta().GetRelativeExpiry()
|
||||
r.Unlock()
|
||||
i.updateCache(
|
||||
r,
|
||||
false, // writing
|
||||
false, // remove
|
||||
ttl, // expiry
|
||||
)
|
||||
|
||||
return r, db, nil
|
||||
}
|
||||
|
||||
|
@ -243,14 +253,19 @@ func (i *Interface) Put(r record.Record) (err error) {
|
|||
}
|
||||
|
||||
r.Lock()
|
||||
defer r.Unlock()
|
||||
i.options.Apply(r)
|
||||
remove := r.Meta().IsDeleted()
|
||||
ttl := r.Meta().GetRelativeExpiry()
|
||||
r.Unlock()
|
||||
|
||||
written := i.updateCache(r, true)
|
||||
// The record may not be locked when updating the cache.
|
||||
written := i.updateCache(r, true, remove, ttl)
|
||||
if written {
|
||||
return nil
|
||||
}
|
||||
|
||||
r.Lock()
|
||||
defer r.Unlock()
|
||||
return db.Put(r)
|
||||
}
|
||||
|
||||
|
@ -271,18 +286,22 @@ func (i *Interface) PutNew(r record.Record) (err error) {
|
|||
}
|
||||
|
||||
r.Lock()
|
||||
defer r.Unlock()
|
||||
|
||||
if r.Meta() != nil {
|
||||
r.Meta().Reset()
|
||||
}
|
||||
i.options.Apply(r)
|
||||
remove := r.Meta().IsDeleted()
|
||||
ttl := r.Meta().GetRelativeExpiry()
|
||||
r.Unlock()
|
||||
|
||||
written := i.updateCache(r, true)
|
||||
// The record may not be locked when updating the cache.
|
||||
written := i.updateCache(r, true, remove, ttl)
|
||||
if written {
|
||||
return nil
|
||||
}
|
||||
|
||||
r.Lock()
|
||||
defer r.Unlock()
|
||||
return db.Put(r)
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue