Move devMode config option to config pkg

config/devmode.go

@@ -0,0 +1,39 @@
+package config
+
+import (
+	"flag"
+
+	"github.com/safing/portbase/log"
+)
+
+// Configuration Keys.
+var (
+	CfgDevModeKey  = "core/devMode"
+	defaultDevMode bool
+)
+
+func init() {
+	flag.BoolVar(&defaultDevMode, "devmode", false, "enable development mode")
+}
+
+func logDevModeOverride() {
+	if defaultDevMode {
+		log.Warning("config: development mode is enabled by default by the -devmode flag")
+	}
+}
+
+func registerDevModeOption() error {
+	return Register(&Option{
+		Name:           "Development Mode",
+		Key:            CfgDevModeKey,
+		Description:    "In Development Mode, security restrictions are lifted/softened to enable unrestricted access for debugging and testing purposes.",
+		OptType:        OptTypeBool,
+		ExpertiseLevel: ExpertiseLevelDeveloper,
+		ReleaseLevel:   ReleaseLevelStable,
+		DefaultValue:   defaultDevMode,
+		Annotations: Annotations{
+			DisplayOrderAnnotation: 512,
+			CategoryAnnotation:     "Development",
+		},
+	})
+}

config/expertise.go

@@ -14,7 +14,7 @@ import (
 // to change deep configuration settings.
 type ExpertiseLevel uint8
 
-// Expertise Level constants
+// Expertise Level constants.
 const (
 	ExpertiseLevelUser      ExpertiseLevel = 0
 	ExpertiseLevelExpert    ExpertiseLevel = 1

config/main.go

@@ -47,6 +47,12 @@ func prep() error {
 		modules.SetCmdLineOperation(exportConfigCmd)
 	}
 
+	logDevModeOverride()
+	err := registerDevModeOption()
+	if err != nil {
+		return err
+	}
+
 	return nil
 }
 

config/option.go

@@ -60,7 +60,7 @@ type PossibleValue struct {
 // future well-known annotation additions do not conflict
 // with vendor/product/package specific annoations.
 //
-// Format: <vendor/package>:<scope>:<identifier>
+// Format: <vendor/package>:<scope>:<identifier> //.
 type Annotations map[string]interface{}
 
 // Well known annotations defined by this package.
@@ -144,7 +144,7 @@ type ValueRequirement struct {
 	Value interface{}
 }
 
-// Values for the DisplayHintAnnotation
+// Values for the DisplayHintAnnotation.
 const (
 	// DisplayHintOneOf is used to mark an option
 	// as a "select"-style option. That is, only one of
@@ -263,7 +263,7 @@ func (option *Option) SetAnnotation(key string, value interface{}) {
 	option.Annotations[key] = value
 }
 
-// GetAnnotation returns the value of the annotation key
+// GetAnnotation returns the value of the annotation key.
 func (option *Option) GetAnnotation(key string) (interface{}, bool) {
 	option.Lock()
 	defer option.Unlock()