vikarti.anatra/safing-portbase
1
0
Fork 0
mirror of https://github.com/safing/portbase synced 2025-09-02 18:50:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix nil check error marked by linter

Browse source
This commit is contained in:
Daniel 2020-04-21 14:12:15 +02:00
parent 94b5fe8e4d
commit 65d47e2974
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
modules/tasks.go
View file

@ -63,9 +63,6 @@ const (
// NewTask creates a new task with a descriptive name (non-unique), a optional deadline, and the task function to be executed. You must call one of Queue, Prioritize, StartASAP, Schedule or Repeat in order to have the Task executed. // NewTask creates a new task with a descriptive name (non-unique), a optional deadline, and the task function to be executed. You must call one of Queue, Prioritize, StartASAP, Schedule or Repeat in order to have the Task executed.
func (m *Module) NewTask(name string, fn func(context.Context, *Task) error) *Task { func (m *Module) NewTask(name string, fn func(context.Context, *Task) error) *Task {
m.Lock()
defer m.Unlock()
if m == nil { if m == nil {
log.Errorf(`modules: cannot create task "%s" with nil module`, name) log.Errorf(`modules: cannot create task "%s" with nil module`, name)
return &Task{ return &Task{
@ -74,6 +71,10 @@ func (m *Module) NewTask(name string, fn func(context.Context, *Task) error) *Ta
canceled: true, canceled: true,
} }
} }
m.Lock()
defer m.Unlock()
if m.Ctx == nil || !m.OnlineSoon() { if m.Ctx == nil || !m.OnlineSoon() {
log.Errorf(`modules: tasks should only be started when the module is online or starting`) log.Errorf(`modules: tasks should only be started when the module is online or starting`)
return &Task{ return &Task{