vikarti.anatra/safing-portbase
1
0
Fork 0
mirror of https://github.com/safing/portbase synced 2025-09-04 03:29:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Database controller should not lock in PushUpdate

Browse source
This commit is contained in:
Patrick Pacher 2020-10-07 08:57:18 +02:00
parent 643d67aff4
commit 33dcc88dc0
No known key found for this signature in database
GPG key ID: E8CD2DA160925A6D
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
database/controller.go
View file

@ -195,6 +195,8 @@ func (c *Controller) Query(q *query.Query, local, internal bool) (*iterator.Iter
} }
// PushUpdate pushes a record update to subscribers. // PushUpdate pushes a record update to subscribers.
// The caller must hold the record's lock when calling
// PushUpdate.
func (c *Controller) PushUpdate(r record.Record) { func (c *Controller) PushUpdate(r record.Record) {
if c != nil { if c != nil {
c.exclusiveAccess.RLock() c.exclusiveAccess.RLock()
@ -205,9 +207,7 @@ func (c *Controller) PushUpdate(r record.Record) {
} }
for _, sub := range c.subscriptions { for _, sub := range c.subscriptions {
r.Lock()
push := r.Meta().CheckPermission(sub.local, sub.internal) && sub.q.Matches(r) push := r.Meta().CheckPermission(sub.local, sub.internal) && sub.q.Matches(r)
r.Unlock()
if push { if push {
select { select {