vikarti.anatra/safing-portbase
1
0
Fork 0
mirror of https://github.com/safing/portbase synced 2025-09-04 19:50:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix executable suffix detection

Browse source
This commit is contained in:
Daniel 2021-02-19 09:52:37 +01:00
parent 8a1917c4e0
commit 0aeb007138
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
utils/osdetail/binmeta.go
View file

@ -25,9 +25,21 @@ func GenerateBinaryNameFromPath(path string) string {
segments := segmentsSplitter.FindAllString(fileName, -1) segments := segmentsSplitter.FindAllString(fileName, -1)
// Remove last segment if it's an extension. // Remove last segment if it's an extension.
if len(segments) >= 2 && if len(segments) >= 2 {
strings.HasPrefix(segments[len(segments)-1], ".") { switch strings.ToLower(segments[len(segments)-1]) {
segments = segments[:len(segments)-1] case
".exe", // Windows Executable
".msi", // Windows Installer
".bat", // Windows Batch File
".cmd", // Windows Command Script
".ps1", // Windows Powershell Cmdlet
".run", // Linux Executable
".appimage", // Linux AppImage
".app", // MacOS Executable
".action", // MacOS Automator Action
".out": // Generic Compiled Executable
segments = segments[:len(segments)-1]
}
} }
// Debugging snippet: // Debugging snippet:

5
utils/osdetail/binmeta_test.go
View file

@ -7,6 +7,8 @@ import (
) )
func TestGenerateBinaryNameFromPath(t *testing.T) { func TestGenerateBinaryNameFromPath(t *testing.T) {
t.Parallel()
assert.Equal(t, "Nslookup", GenerateBinaryNameFromPath("nslookup.exe")) assert.Equal(t, "Nslookup", GenerateBinaryNameFromPath("nslookup.exe"))
assert.Equal(t, "System Settings", GenerateBinaryNameFromPath("SystemSettings.exe")) assert.Equal(t, "System Settings", GenerateBinaryNameFromPath("SystemSettings.exe"))
assert.Equal(t, "One Drive Setup", GenerateBinaryNameFromPath("OneDriveSetup.exe")) assert.Equal(t, "One Drive Setup", GenerateBinaryNameFromPath("OneDriveSetup.exe"))
@ -18,9 +20,12 @@ func TestGenerateBinaryNameFromPath(t *testing.T) {
assert.Equal(t, "Test Script", GenerateBinaryNameFromPath(".test-script")) assert.Equal(t, "Test Script", GenerateBinaryNameFromPath(".test-script"))
assert.Equal(t, "Browser Broker", GenerateBinaryNameFromPath("browser_broker.exe")) assert.Equal(t, "Browser Broker", GenerateBinaryNameFromPath("browser_broker.exe"))
assert.Equal(t, "Virtual Box VM", GenerateBinaryNameFromPath("VirtualBoxVM")) assert.Equal(t, "Virtual Box VM", GenerateBinaryNameFromPath("VirtualBoxVM"))
assert.Equal(t, "Io Elementary Appcenter", GenerateBinaryNameFromPath("io.elementary.appcenter"))
} }
func TestCleanFileDescription(t *testing.T) { func TestCleanFileDescription(t *testing.T) {
t.Parallel()
assert.Equal(t, "Product Name", cleanFileDescription("Product Name. Does this and that.")) assert.Equal(t, "Product Name", cleanFileDescription("Product Name. Does this and that."))
assert.Equal(t, "Product Name", cleanFileDescription("Product Name - Does this and that.")) assert.Equal(t, "Product Name", cleanFileDescription("Product Name - Does this and that."))
assert.Equal(t, "Product Name", cleanFileDescription("Product Name / Does this and that.")) assert.Equal(t, "Product Name", cleanFileDescription("Product Name / Does this and that."))