vikarti.anatra/nginx-ultimate-bad-bot-blocker
1
0
Fork 0
mirror of https://github.com/mitchellkrogza/nginx-ultimate-bad-bot-blocker.git synced 2025-09-02 18:50:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

setup-ngxblocker: use getopts not getopt

Browse source 
long options for the command line are removed. getopt is replaced with
the newer getopts (which is compatible with Debian's DASH Shell)

* fixes https://github.com/mitchellkrogza/nginx-ultimate-bad-bot-blocker/issues/35

* adds sanity checks for user command line switches
This commit is contained in:
Stuart Cardall 2017-04-26 15:55:40 +00:00
parent f67776d8a9
commit 59c34aebe7
1 changed files with 59 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
setup-ngxblocker
View file

@ -22,21 +22,21 @@ INC_DDOS="Y"
####### end user configuration ########################### ####### end user configuration ###########################
usage() { usage() {
local script=$(basename $0) local script=$(basename $0)
cat <<EOF cat <<EOF
$script: add Nginx Bad Bot Blocker configuration [ in $MAIN_CONF ] [ $VHOST_DIR/* ] $script: SETUP Nginx Bad Bot Blocker configuration in [ $MAIN_CONF ] [ $VHOST_DIR/* ]
Usage: $script [OPTIONS] Usage: $script [OPTIONS]
[ -w | --www ] : WWW path (default: $WWW) [ -w ] : WWW path (default: $WWW)
[ -e | --ext ] : Vhost file extension (default: .$VHOST_EXT) [ -e ] : Vhost file extension (default: .$VHOST_EXT)
[ -v | --vhost ] : Vhost directory (default: $VHOST_DIR) [ -v ] : Vhost directory (default: $VHOST_DIR)
[ -b | --bots ] : Bot rules directory (default: $BOTS_DIR) [ -b ] : Bot rules directory (default: $BOTS_DIR)
[ -c | --conf ] : NGINX conf directory (default: $CONF_DIR) [ -c ] : NGINX conf directory (default: $CONF_DIR)
[ -m | --main ] : NGINX main configuration (default: $MAIN_CONF) [ -m ] : NGINX main configuration (default: $MAIN_CONF)
[ -n | --names ] : NO whitelist of .names only (default: $DOT_NAMES) [ -n ] : NO whitelist of .names only (default: $DOT_NAMES)
[ -d | --ddos ] : NO insert of DDOS rule (default: $INC_DDOS) [ -d ] : NO insert of DDOS rule (default: $INC_DDOS)
[ -x | --exec ] : Actually change the files (default: don't change anything) [ -x ] : Actually change the files (default: don't change anything)
[ -h | --help ] : this help message [ -h ] : this help message
Examples: Examples:
$script -n (Whitelist all directory names in $WWW as domains: not just dot.name directories) $script -n (Whitelist all directory names in $WWW as domains: not just dot.name directories)
@ -44,7 +44,7 @@ Examples:
$script (Don't change anything: display results on stdout) $script (Don't change anything: display results on stdout)
$script -x (Change / update config files) $script -x (Change / update config files)
EOF EOF
return 0 exit 0
} }
check_config() { check_config() {
@ -184,30 +184,54 @@ find_includes() {
echo $line echo $line
} }
sanitize_path() {
echo $1 |tr -cd '[:alnum:] [=@=] [=.=] [=-=] [=/=] [=_=]' \
|tr -s '@.-/_' |awk '{print tolower($0)}'
}
sanitize_ext() {
echo $1 |tr -cd '[:alnum:]' |awk '{print tolower($0)}'
}
check_args() {
local option=$1 type=$2 arg=$3
local msg="ERROR: option '-$option' argument '$arg' requires:"
case "$type" in
path) if ! echo $arg | grep ^/ 1>/dev/null; then
printf "$msg absolute path.\n"
exit 1
fi
;;
none) printf "$msg argument.\n"; exit 1;;
esac
}
get_options() { get_options() {
local options=$(getopt -o w:e:v:b:c:m:ndhx --long \ local arg= opts=
www:,ext:,vhost:,bots:,conf:,main:,names,ddos,help,exec -- "$@" 2>/dev/null)
if [ $? -ne 0 ]; then while getopts :w:e:v:b:c:m:ndxh opts "$@"
usage do
exit 1 if [ -n "${OPTARG}" ]; then
fi case "$opts" in
e) arg=$(sanitize_ext ${OPTARG});;
*) arg=$(sanitize_path ${OPTARG});;
esac
fi
eval set -- "$options" case "$opts" in
w) WWW=$arg; check_args $opts path $arg ;;
while :; do e) VHOST_EXT=$arg;;
case "$1" in v) VHOST_DIR=$arg; check_args $opts path $arg ;;
-h | --help) usage && exit 1;; b) BOTS_DIR=$arg; check_args $opts path $arg ;;
-x | --exec) DRY_RUN=N; shift;; c) CONF_DIR=$arg; check_args $opts path $arg ;;
-w | --www) WWW=$2; shift 2;; m) MAIN_CONF=$arg; check_args $opts path $arg ;;
-e | --ext) VHOST_EXT=$2; shift 2;; n) DOT_NAMES=N ;;
-v | --vhost) VHOST_DIR=$2; shift 2;; d) INC_DDOS=N ;;
-b | --bots) BOTS_DIR=$2; shift 2;; x) DRY_RUN=N ;;
-c | --conf) CONF_DIR=$2; shift 2;; h) usage ;;
-m | --main) MAIN_CONF=$2; shift 2;; \?) usage ;;
-n | --names) DOT_NAMES=N; shift;; :) check_args $OPTARG none none ;;
-d | --ddos) INC_DDOS=N; shift;;
*) break;;
esac esac
done done
} }