fix(extraction-shadow): follow-up to SKY-8871 — cycle, dead code, comment nits (#5486)
Some checks are pending
Run tests and pre-commit / Run tests and pre-commit hooks (push) Waiting to run
Run tests and pre-commit / Frontend Lint and Build (push) Waiting to run
Publish Fern Docs / run (push) Waiting to run

This commit is contained in:
Aaron Perez 2026-04-13 23:32:20 -05:00 committed by GitHub
parent 3db5dd4e5b
commit ff198cb6f5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 188 additions and 16 deletions

View file

@ -310,6 +310,22 @@ class TestLLMReasoningError:
assert "LLM_REASONING_ERROR" in categories
class TestParameterBindingError:
@pytest.mark.parametrize(
"reason",
[
"Value should have already been set through workflow run parameters",
"Context should have already been set through workflow run context init",
"Pre-run invariant: workflow_definition and persisted parameter rows disagree",
],
)
def test_keywords_match(self, reason: str) -> None:
result = classify_from_failure_reason(reason)
assert result is not None
categories = [r["category"] for r in result]
assert "PARAMETER_BINDING_ERROR" in categories
class TestMultipleCategories:
def test_captcha_and_max_steps(self) -> None:
"""A max_steps failure caused by captcha should return both categories."""