remove connect_to_scraping_browser (#303)

This commit is contained in:
Shuchang Zheng 2024-05-13 12:08:12 -04:00 committed by GitHub
parent 20a86590dd
commit e89318aba8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1,11 +1,10 @@
from __future__ import annotations from __future__ import annotations
import structlog import structlog
from playwright.async_api import Browser, Playwright, async_playwright from playwright.async_api import async_playwright
from skyvern.exceptions import MissingBrowserState from skyvern.exceptions import MissingBrowserState
from skyvern.forge.sdk.schemas.tasks import ProxyLocation, Task from skyvern.forge.sdk.schemas.tasks import ProxyLocation, Task
from skyvern.forge.sdk.settings_manager import SettingsManager
from skyvern.forge.sdk.workflow.models.workflow import WorkflowRun from skyvern.forge.sdk.workflow.models.workflow import WorkflowRun
from skyvern.webeye.browser_factory import BrowserContextFactory, BrowserState from skyvern.webeye.browser_factory import BrowserContextFactory, BrowserState
@ -131,14 +130,6 @@ class BrowserManager:
) )
return b"" return b""
@classmethod
async def connect_to_scraping_browser(cls, pw: Playwright) -> Browser:
if not SettingsManager.get_settings().REMOTE_BROWSER_KEY:
raise Exception("REMOTE_BROWSER_KEY is empty. Cannot connect to remote browser.")
browser = await pw.chromium.connect_over_cdp(SettingsManager.get_settings().REMOTE_BROWSER_KEY)
LOG.info("Connected to remote browser", browser_type=SettingsManager.get_settings().BROWSER_TYPE)
return browser
@classmethod @classmethod
async def close(cls) -> None: async def close(cls) -> None:
LOG.info("Closing BrowserManager") LOG.info("Closing BrowserManager")