vikarti.anatra/Skyvern
1
0
Fork 0
mirror of https://github.com/Skyvern-AI/skyvern.git synced 2026-04-28 11:40:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix: cache file_download blocks inside for-loops (#5323)

Browse source
This commit is contained in:
pedrohsdb 2026-03-31 20:33:45 -07:00 • committed by GitHub
parent c3e1ba290a
commit e1fdae2a8d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 208 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

25
skyvern/forge/sdk/workflow/service.py
View file

@ -2377,6 +2377,31 @@ class WorkflowService:
workflow_run_id=workflow_run_id,
)
# Track uncached for-loop child blocks for regeneration.
# ForLoopBlock children execute via block.py's execute_loop_helper(),
# bypassing _execute_single_block. Without this, their labels never
# reach blocks_to_update and the script generator never produces
# cached functions for them (e.g., file_download inside a loop).
if (
isinstance(block, ForLoopBlock)
and (is_adaptive_caching(workflow, workflow_run) or is_script_run)
and workflow_run_block_result.status in cacheable_statuses
):
for loop_child in block.loop_blocks:
if (
loop_child.label
and loop_child.label not in script_blocks_by_label
and loop_child.block_type in BLOCK_TYPES_THAT_SHOULD_BE_CACHED
):
blocks_to_update.add(loop_child.label)
LOG.info(
"For-loop child block marked for caching",
parent_label=block.label,
child_label=loop_child.label,
child_block_type=loop_child.block_type,
workflow_run_id=workflow_run_id,
)
workflow_run, should_stop = await self._handle_block_result_status(
block=block,
block_idx=block_idx,