vikarti.anatra/Skyvern
1
0
Fork 0
mirror of https://github.com/Skyvern-AI/skyvern.git synced 2026-05-02 13:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: validate bare interaction calls missing selector and ai argument (#5437)

Browse source
This commit is contained in:
pedrohsdb 2026-04-08 20:32:03 -07:00 • committed by GitHub
parent eb9ad1025a
commit 8d424d8368
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/unit/test_script_reviewer_quality.py
View file

@ -387,16 +387,19 @@ async def block_fn(page, context):
assert error is not None
assert "page.fill()" in error
def test_no_ai_arg_not_flagged(self) -> None:
"""Calls without ai='fallback' are not our concern here."""
def test_no_ai_arg_without_selector_flagged(self) -> None:
"""Bare calls with no ai= and no selector= silently burn LLM tokens."""
code = """
async def block_fn(page, context):
await page.click(prompt='Click something')
"""
assert self.reviewer._validate_missing_selectors(code) is None
error = self.reviewer._validate_missing_selectors(code)
assert error is not None
assert "page.click()" in error
assert "no ai= argument" in error
def test_proactive_without_selector_not_flagged(self) -> None:
"""ai='proactive' without selector is caught by _validate_proactive_misuse, not this validator."""
"""ai='proactive' without selector is intentional — AI always generates the value."""
code = """
async def block_fn(page, context):
await page.click(ai='proactive', prompt='Click something')