vikarti.anatra/Skyvern
1
0
Fork 0
mirror of https://github.com/Skyvern-AI/skyvern.git synced 2026-07-09 16:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

SKY-11940 MCP browser tool schemas: selector/ref leads, intent is the explicit AI fallback (#7220)

Browse source
This commit is contained in:
Marc Kelechava 2026-07-08 17:11:30 -07:00 • committed by GitHub
parent 26f73ec044
commit 633b65d33d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 143 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

51
tests/unit/test_mcp_browser_tools.py
View file

@ -10,6 +10,7 @@ import pytest
from skyvern.cli.core.result import BrowserContext
from skyvern.cli.mcp_tools import browser as mcp_browser
from skyvern.cli.mcp_tools import mcp
from skyvern.client.errors import InternalServerError, UnprocessableEntityError
@ -150,6 +151,56 @@ async def test_skyvern_run_task_timeout_returns_timeout_code(monkeypatch: pytest
assert "45" in result["error"]["message"]
@pytest.mark.asyncio
async def test_browser_tool_targeting_schema_prefers_direct_params() -> None:
tools_by_name = {tool.name: tool for tool in await mcp.list_tools()}
expectations = {
"skyvern_click": (("selector",), ("intent",)),
"skyvern_drag": (("source_selector", "target_selector"), ("source_intent", "target_intent")),
"skyvern_file_upload": (("selector",), ("intent",)),
"skyvern_hover": (("selector",), ("intent",)),
"skyvern_type": (("selector",), ("intent",)),
"skyvern_screenshot": (("selector",), ()),
"skyvern_scroll": (("selector",), ("intent",)),
"skyvern_select_option": (("selector",), ("intent",)),
"skyvern_press_key": (("selector",), ("intent",)),
"skyvern_wait": (("selector",), ("intent",)),
"skyvern_observe": (("selector",), ()),
"skyvern_frame_switch": (("selector",), ()),
"skyvern_execute": (("steps",), ()),
"skyvern_get_html": (("selector",), ()),
"skyvern_get_value": (("selector",), ()),
"skyvern_get_styles": (("selector",), ()),
}
for tool_name, (direct_params, intent_params) in expectations.items():
tool = tools_by_name[tool_name]
properties = tool.parameters["properties"]
ordered_property_names = list(properties)
for direct_param in direct_params:
assert mcp_browser.DIRECT_TARGET_DESCRIPTION in properties[direct_param]["description"]
assert ordered_property_names.index(direct_param) < ordered_property_names.index("session_id")
for intent_param in intent_params:
assert ordered_property_names.index(direct_param) < ordered_property_names.index(intent_param)
for intent_param in intent_params:
assert properties[intent_param]["description"] == mcp_browser.AI_FALLBACK_DESCRIPTION
@pytest.mark.asyncio
async def test_run_task_schema_description_demotes_autonomous_trial() -> None:
tools_by_name = {tool.name: tool for tool in await mcp.list_tools()}
description = tools_by_name["skyvern_run_task"].description or ""
assert "one-off autonomous trial" in description
assert "highest-cost AI path" in description
assert "Not for production or reusable automations" in description
assert "Prefer direct tools" in description
assert "selector/ref" in description
assert "skyvern_observe + skyvern_execute" in description
def _click_page(monkeypatch: pytest.MonkeyPatch) -> AsyncMock:
click = AsyncMock(return_value="#resolved")
page = SimpleNamespace(click=click)