vikarti.anatra/Skyvern
1
0
Fork 0
mirror of https://github.com/Skyvern-AI/skyvern.git synced 2026-04-28 03:30:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix ReDoS in script_reviewer string literal regex (#5364)

Browse source
This commit is contained in:
Shuchang Zheng 2026-04-02 15:39:47 -07:00 • committed by GitHub
parent a36e107d20
commit 4358f9c695
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
65 changed files with 5240 additions and 3471 deletions
Download patch file Download diff file Expand all files Collapse all files

29
skyvern-frontend/src/routes/credentials/CredentialsModal.tsx
View file

@ -753,10 +753,10 @@ function CredentialsModal({
? updateCredentialMutation
: createCredentialMutation;
const handleRenameOnly = (name: string, hasMetadataChanges: boolean) => {
const handleRenameOnly = (name: string) => {
if (!editingCredential) return;
// Skip the API call if nothing actually changed
if (name === editingCredential.name && !hasMetadataChanges) {
// Skip the API call if the name hasn't actually changed
if (name === editingCredential.name) {
reset();
setIsOpen(false);
return;
@ -764,9 +764,6 @@ function CredentialsModal({
renameCredentialMutation.mutate({
id: editingCredential.credential_id,
name,
tested_url: testUrl.trim() || undefined,
user_context: userContext.trim() || null,
save_browser_session_intent: testAndSave,
});
};
@ -788,26 +785,14 @@ function CredentialsModal({
// In edit mode, use editingGroups to determine what changed (type-agnostic)
if (isEditMode && editingCredential) {
const hasMetadataChanges =
testUrl.trim() !== (editingCredential.tested_url ?? "") ||
testAndSave !==
(editingCredential.save_browser_session_intent ??
!!editingCredential.browser_profile_id) ||
userContext.trim() !== (editingCredential.user_context ?? "");
if (!editingGroups.name && !editingGroups.values) {
if (!hasMetadataChanges) {
// Nothing was edited — close silently
reset();
setIsOpen(false);
return;
}
// Only metadata changed (no auth values edited) — save via PATCH
handleRenameOnly(name, hasMetadataChanges);
// Nothing was edited — close silently
reset();
setIsOpen(false);
return;
}
if (editingGroups.name && !editingGroups.values) {
handleRenameOnly(name, hasMetadataChanges);
handleRenameOnly(name);
return;
}
}