vikarti.anatra/Skyvern
1
0
Fork 0
mirror of https://github.com/Skyvern-AI/skyvern.git synced 2026-07-09 16:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(SKY-12018): classify external download HTTP errors (#7210)

Browse source
This commit is contained in:
Aaron Perez 2026-07-08 14:32:38 -05:00 • committed by GitHub
parent 777e842c39
commit 2452bf60e1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 78 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

21
skyvern/forge/sdk/api/files.py
View file

@ -116,6 +116,19 @@ def _determine_download_filename(
return sanitize_filename(file_name)
def _raise_download_response_for_status(response: aiohttp.ClientResponse) -> None:
if response.status < HTTPStatus.BAD_REQUEST:
return
raise aiohttp.ClientResponseError(
request_info=response.request_info,
history=response.history,
status=response.status,
message=response.reason,
headers=response.headers,
)
def validate_download_url(url: str, organization_id: str | None = None) -> bool:
"""Validate if a URL is supported for downloading.
@ -224,9 +237,7 @@ async def download_file(
resolver = SSRFGuardedResolver()
current_url = await validate_and_pin_fetch_url(url, resolver)
request_headers = dict(headers or {})
async with aiohttp.ClientSession(
raise_for_status=True, connector=ssrf_guarded_tcp_connector(resolver)
) as session:
async with aiohttp.ClientSession(connector=ssrf_guarded_tcp_connector(resolver)) as session:
LOG.info("Starting to download file", url=url)
for _ in range(MAX_SAFE_REDIRECTS + 1):
encoded_url = encode_url(current_url)
@ -243,6 +254,8 @@ async def download_file(
current_url = next_url
continue
_raise_download_response_for_status(response)
# Check the content length if available
if max_size_mb and response.content_length and response.content_length > max_size_mb * 1024 * 1024:
# todo: move to root exception.py
@ -301,7 +314,7 @@ async def download_file(
)
except aiohttp.ClientResponseError as e:
# Re-raised and handled at the action/block boundary; server rejections are external.
LOG.warning(f"Failed to download file, status code: {e.status}", exc_info=True)
LOG.warning("Failed to download file", status_code=e.status)
raise
except DownloadFileMaxSizeExceeded as e:
LOG.warning(f"Failed to download file, max size exceeded: {e.max_size}", exc_info=True)