Commit graph

1905 commits

Author SHA1 Message Date
Harald Hope c54ff52417 changelog update 2021-03-15 20:16:12 -07:00
Harald Hope 75433a383a Huge upgrade!! Bug Fixes!! Refactors!!! BSDs!!! More BSDs!!!
raspberry pi!! New Features!!! Enhanced old features!!! Did I
mention bluetooth?! USB? Audio? No? well, all hugely upgraded!

------------------------------------------------------------------------
BUGS:

1. Sadly, 3.3.01 went out with a bug, forgot to remove a debugger,
resulted in hardcoded kernel compiler version always showing.

Note that there is a new inxi-perl/docs/inxi-bugs.txt file to
track such bugs, and matched to specific tagged releases so you
know the line number and items to update to fix it.

2. Typo in manjaro system base match resulted in failing to report
system base as expected.

------------------------------------------------------------------------
KNOWN ISSUES BUT CAN'T OR WON'T BE FIXED:

1. OpenBSD made fvwm -version output an error along with the
version, and not in the normal format for standard fvwm, this
is just too complicated to work around for now, though it could
be in theory by creating a dedicated fvwm-oBSD item in
program_values. But that kind of granularity gets too hard to track,
and they are likely to change or fix this in the future anyway.
Best is they just restore default -version output to what it is
elsewhere, not nested in error outputs.

2. Discovered an oddity, don't know how widespread this
is, but Intel SSDs take about 200 milliseconds to get the sys
hwmon based drive temps, when it should take under a
millisecond, this may be a similar cause as those drives having
a noticeable SMART report delay, not sure. This is quite
noticeable since 200 ms is about 15% of the total execution
time on my test system.

------------------------------------------------------------------------
FIXES:

1. For --recommends, added different rpm SUSE xdpyinfo package name.

2. Distro Data: added double term filter for lsb-release due to sometimes
generating repeated names in distro.

3. Packages: fix for appimage package counts.

4. Desktop: fixed ID for some wm when no xprop installed, fallback to
using @ps_cmd detections, which usually work fine.

5a. When swap used was 0, showed N/A, fixed to correctly show 0 KiB.

5b. If no swap devices found, BSDs were not correctly showing
no swap data found message. Corrected.

6a. Bluetooth: Removed hcidump from debugger, in some cases, that will
just hang endlessly. Also wrapped bluetoothctl and bt-adapter debugger
data collection with @ps_cmd bluetooth running test. Only run if
bluetooth service is running.

6b. Bluetooth: running detections have to be very strict, only
bluetoothd, not bluetooth, the latter can show true when bluetoothd
is not running, and did in my tests.

7. USB: with Code Change 1, found a few places where fallback usb type
detections were creating false matches, which resulted in say,
bluetooth devices showing up as network devices due to the presence
of the word 'wireless' in the device description. These matches are
all updated and revised to be more accurate and less error prone.

8. Battery: an oversight, had forgotten to have percent used of
available capacity, which made Battery data hard to decipher, now
it shows the percent of available total, as well as the condition
percent, so it's easier to understand the data now, and hopefully
more clear.

9a. OpenBSD changed usbdevs output format sometime in the latest
releases, which made the delicate matching patterns fail. Updated
to handle both variants. They also changed pcidump -v formatting
at some point, now inxi will try to handle either. Note that
usbdevs updates also work fine on NetBSD.

9b. FreeBSD also changed their pciconf output in beta 13.0, which
also broke the detections completely, now checks for old and new
formats. Sigh. It should not take this much work to parse tools
whose output should be consistent and reliable. Luckily I ran
the beta prior to this release, or all pci device detections
would simply have failed, without fallback.

9c. Dragonfly BSD also changed an output format, in vmstat, that
made the RAM used report fail. Since it's clearly not predictable
which BSD will change support for which vmstat options, now just
running vmstat without options, and then using processing logic
to determine what to do with the results.

10. It turns out NetBSD is using /proc/meminfo, who would have
thought? for memory data, but they use it in a weird way that
could result in either negative or near 0 ram used. Added in
some filters to not allow such values to print, now it tries
to make an educated guess about how much ram the system is
really using based on some tests.

11. Something you'd only notice if testing a lot, uptime failed
when the uptime was < 1 minute, it had failed to handle the seconds
only option, now it does, seconds, minutes, hours:minutes,
days hours:minutes, all work.

12. Missed linsysfs type to exclude in partitons, that was a partner
to linprocfs type, both are BSD types.

13. Added -ww to ps arguments, that stops the cutting width to terminal
size default behavior in BSDs, an easy fix, wish I'd known about
that a long time ago.

15. gpart seems to show sizes in bytes, not the expected KiB, so
that's now handled internally. Hopefully that odd behavior won't
randomly change in the future, sigh.

16. Fixed slim dm detection, saw instance where it's got slim.pid
like normal dms, not the slim.lock which inxi was looking for, so
now inxi looks for both, and we're all happy!

------------------------------------------------------------------------
ENHANCEMENTS:

1. Added in something that should have been there all along, now inxi
validates the man page download as well as the self, this avoids
corrupted downloads breaking the man.

2. Init: added support for shepherd init system.

3. Distro Data: added support for guix distro ID; added support for
NomadBSD, GhostBSD, HardenedBSD system base. GhostBSD also shows the main
package version for the distro version ID, which isn't quite the
same as the version you download, but it's close. Also added os-release
support for BSDs, using similar tests as for linux distros, that
results in nicer outputs for example for Dragonfly BSD.

4. Package Data: added guix/scratch [venom]/kiss/nix package managers.
Update for slackware 15 package manager data directory relocation,
now handles either legacy current or future one.

5. Repos: added scratch/kiss/nix-channels; Added GhostBSD, HardenedBSD
pkg repos.

6. USB Data: added usbconfig. That's FreeBSD's, and related systems.

7. Device Data: Added pcictl support, that's NetBSD's, I thought
inxi had supported that, but then I remembered last time I tried to
run netBSD in a vm, I couldn't get it figured out. Now debugged and
working reasonably well.

8. Raspberry Pi 3, 4: ethernet nic now detected; wifi device,
which is on a special mmcnr type, now works, that stopped working in
pi 3, due to the change, now it's handled cleanly. Also added support
for pi bluetooth, which lives on a special serial bus, not usb.
For Raspberry Pi OS, added system base detections, which are tricky.
Also matched mmcnr devices to IF data, which was trickyy as well.
Note that as far as I could discover, only pi puts wifi on mmcnr.

9. Bluetooth: due to deprecated nature of the fine hciconfig
utility, added in support for bt-adapter, which also allows matching
of bluetooth data to device data, but is very sparse in info
supplied compared to hciconfig. bluetoothctl does not have enough
data to show the hci device, so it's not used, since inxi can't
match the bluetooth data to the device (no hci[x]). This should help
the distros that are moving away from hciconfig, in particular,
AUR is only way arch users can get hciconfig, which isn't ideal.

10. New tool and feature, ServiceData, this does two things,
as cross platform as practical, show status of bluetooth service,
this should help a lot in support people debugging bluetooth problems,
since you have bluetooth enabled but down, or up, disabled, and you
can also have the device itself down or up, so now it shows all that
data together for when it's down, but when the device is up, it just
shows the device status since the other stuff is redundant then.

In -Sa, it now shows the OS service manager that inxi detected
using a bunch of fallback tests, that's useful to admins who
are on a machine they don't know, then you can see the service
manager to use, like rc-service, systemctl, service, sv, etc.

11. Big update for -A: Sound Servers: had always been really
just only ALSA, now it shows all detected sound servers, and whether
they are running or not. Includes: ALSA, OSS, PipeWire, PulseAudio,
sndio, JACK. Note that OSS version is a guess, might be wrong source
for the version info.

12. Added USB device 'power:' item, that's in mA, not a terrible
thing to have listed, -xxx. This new feature was launched cross
platform, which is nice. Whether the BSD detections will break
in the future of course depends on whether they change the output
formats again or not. Also added in USB more chip IDs, which can
be useful. For BSDs, also added in a synthetic USB rev, taken
from the device/hub speeds. Yes, I know, USB 2 can have low speed,
full speed, or high speed, and 1.1 can have low and full speeds,
so you actually can't tell the USB revision version from the speeds,
but it's close enough.

13. Made all USB/Device data the same syntax and order, more
predictable, bus, chip, class IDs all the same now.

14. Added in support for hammer and null/nullfs file system types,
which trigger 'logical:' type device in partitions, that's also
more correct than the source: Err-102 that used to show, which
was really just a flag to alert me visibly that the partition
type detection had simply failed internally. Now for detected
types, like zfs tank/name or null/nullfs, it knows they are
logical structures.

15. Expanded BSD CPU data, where available, now can show L1/L2/
L3 cache, cpu arch, stepping, family/model ids, etc, which is
kind of nifty, although, again, delicate fragile rules that
will probably break in the future, but easier to fix now.

16. By an old request, added full native BSD doas support.
That's a nice little tool, and it plugged in fairly seamlessly
to existing sudo support. Both the internal doas/sudo stuff
should work the same, and the detection of sudo/doas start
should work the same too.

17a. Shell/Parent Data: Big refactor of the shell start/parent logic,
into ShellData which helped resolve some issues with running-in
showing shell name, not vt terminal or program name. Cause of that
is lots of levels of parents before inxi could reach the actual
program that was running inxi. Solution was to change to a longer
loop, and let it iterate 8 times, until it finds something that is
not a shell or sudo/doas/su type parent, this seems to work quite
well, you can only make it fail now if you actually try to do it on
purpose, which is fine.

This was very old logic, and carried some mistakes and
redundancies that made it very hard to understand, that's cleaned
up now. Also restored the old (login) value, which shows
when you use your normal login account on console, some system
will also now show (sudo,login) if the login user sudos inxi,
but that varies system to system.

17b. BSD running-in: Some of the BSDs now support the -f flag
for ps, which made the parent logic for running-in possible for
BSDs, which was nice. Some still don't support it, like OpenBSD
and NetBSD, but that's fine, inxi tests, and if no support detected,
just shows tty number. Adding in more robust support here cleaned
up some redundant logic internally as well.

17c. Updated terminal and shell ID detections, there's quite a few
new terminals this year, and a new shell or two. Those are needed
for more reliable detections of when the parent is NOT a shell,
which is how we find what it is.

18. Added ctwm wm support, that's the new default for NetBSD,
based on twm, has version numbers.

19. Upgraded BSD support for gpart and glabel data, now should
catch more more often.

20. For things like zfs raid, added component size, that doesn't
always work due to how zfs refers to its components, but it often
does, which is better than never before.

21. To make BSD support smoother, got rid of some OpenBSD only
rules, which in fact often apply to NetBSD as well. That may
lead to some glitches, but overall it's better to totally stay
away from OpenBSD only tests, and all BSD variant tests, and
just do dynamic testing that will work when it applies, and
not when it doesn't. In this case, added ftp downloader support
for netBSD by removing the openBSD only flag for that item.

There's a bit of a risk there in a sense since if different ftp
programs with different options were to be the fallback for something
else, it might get used, but that's fine, it's a corner case, better
to have them all work now than to worry about weird future things.
But limiting it to only BSDs should get rid of most of the problem.

vmstat and optical drive still use net/openbsd specifics because
it is too tricky to figure out it out in any more dynamic way.

22. For -Sxxx, added if systemd, display, virtual terminal number.
Could be useful to debug subtle issues, if the user is for example
not running their desktop in vt 7, the default for most systems.

------------------------------------------------------------------------
CHANGES:

1. Moved battery voltage to -Bx output, the voltage is quite
important to know since that is the key indicator of battery state.
If voltage is within .5 volts of specified minimum, shows voltage
for -B since that's a prefail condition, it's getting close to
death.

2. In partitions and raid, when the device was linear raid logical
type layout, it said, no-raid, when it should be 'linear', that's
now cleaner and more correct.

3. When running-in is a tty value, it will now show the entire
tty ID, minus the '/dev/tty', this will be more precise, and also
may resolve cases where tty was fully alpha, no numbers, previously
inxi filtered out everything that was not a number, but that can
in some tty types remove critical tty data, so now it will show:

running-in:
tty 2 [not changed]; tty pts/2 [adds pts/]; tty E2 [adds the E];
tty rx [would have not shown at ll before]

------------------------------------------------------------------------
CODE CHANGES:

NOTE: unlike the previous refactors, a lot of these changes were
done to make inxi more maintainable, which means, slightly less
optimized, which has been my preference in the past, but if the
stuff can't be maintained, it doesn't matter how fast it runs!

These changes have really enhanced the quality of the code and
made it a lot easier to work with. It's also now a lot easier to
add debuggers, force/fake data switches, etc, so it gets done,
unlike before, when it was a pain, so it got skipped, and then
caused bugs because of stray debuggers left in place, and so on.

The bright side is while reading up on this, I learned that using
very large subs is much more efficient than many small ones,
which I've always felt was the case, and it is, so the style
used internally in inxi proves to be the best one for optimizations.

These refactors, ongoing, have now touched at least 1/3, almost
1/2, of the entire inxi codebase, so the stuff is getting more
and more consistent and up to date, but given how old the logic
is in places, there will be more refactors in the future, and
maybe once the code is easier to maintain, some renewed
optimizations!, if we can find anything that makes sense, like
passing array/hash references back to the caller, already the
first half is done, passing references to the sub/method always.

The second part is started, using the Benchmark Perl module,
which really speeds up testing and helps avoid pointless tweaks
that do little re speed improvements.

I could see with some care some areas where working on data
directly via references could really speed things up, but it's
hard to write and read that type of code, but it's already being
done in the recursive data and output logics, and a few other
places.

1. Large refactor of USBData, that was done in part to help make
it work for BSDs better, but also to get it better organized.

This refactor also made all the device items, like -A,-G,-N,-E
use the same methods for creating USB output, previously they
had used a hodgepodge of methods, some super old, it was not
possible to add USB support more extensively for BSDs without
this change.

Also added in some fallback usb type detection tools using
several large online collections of that info to see what possible
matching patterns could catch more devices and correctly match
them to their type, which is the primary way now that usb output
per type is created. This really helps with BSDs, though BSD
usb utilities suffer from less data than lsusb so they don't always
get device name strings in a form where they can be readily ID'ed,
but it's way better than it was before, so that's fine!

Moved all previous methods of detecting if a card/device was USB
into USBData itself so it would all be in one place, and easier
to maintain.

All USB tools now use bus_id_alpha for sorting, and all now
sort as well, that was an oversight, previously the BSD usb
tools were not sorted, but those have been enhanced a lot, so
sorting on alpha synthetic bus ids became possible.

Removed lsusb as a BSD option, it's really unreliable, and the data
is different, and also varies a lot, it didn't really work at all
in Dragonfly, or had strange output, so lsusb is now a linux only
item.

2. Moved various booleans that were global to %force, %loaded, and
some to the already present, but lightly used, %use hashes. It was
getting too hard to add tests etc, which was causing bugs to happen.
Yes, using hashes is slower than hardcoding in the boolean scalars,
but this change was done to improve maintainability, which is starting
to matter more.

3. Moved several sets of subs to new packages, again, to help with
debugging and maintainability. MemoryData, redone in part to
handle the oddities with NetBSD reporting of free, cached, and
buffers, but really just to make it easier to work with overall.
Also moved kernel parameter logic to KernelParameters, gpart logic
to GpartData, glabel logic to GlabelData, ip data IpData, check_tools
to CheckTools, which was also enhanced largely, and simplified,
making it much easier to work with.

4. Wrapped more debugger logic in $fake{data} logic, that makes
it harder to leave a debugger uncommented, now to run it, you have
to trigger it with $fake{item} so the test runs, that way even if
I forget to comment it out, it won't run for regular user.

5. Big update to docs in branch inxi-perl/docs, those are now
much more usable for development. Updated in particular
inxi-values.txt to be primary reference doc for $fake, $dbg,
%force, %use, etc types and values. Also updated inxi-optimization.txt
and inxi-resources.txt to bring them closer to the present.

Created inxi-bugs.txt as well, which will help to know which known
bugs belonged to which frozen pools. These bugs will only refer
to bugs known to exist in tagged releases in frozen pool distros.

6. For sizes, moved most of the sizing to use main::translate_size,
this is more predictable, though as noted, these types of
changes make inxi a bit slower since it moved stuff out of inline
to using quick expensive sub calls, but it's a lot easier to
maintain, and that's getting to be more important to me now.

7. In order to catch live events, added in dmesg to dmesg.boot data
in BSDs, that's the only way I could find to readily detect
usb flash drives that were plugged in after boot. Another hack,
these will all come back to bite me, but that's fine, the base
is easier to work on and debug now, so if I want to spend time
revisiting the next major version BSD releases, it will be easier
to resolve the next sets of failures.

8. A big change, I learned about the non greedy operator for
regex patterns, ?, as in, .*?(next match rule), it will now
go up only to the next match rule. Not knowing this simple
little thing made inxi use some really convoluted regex to
avoid such greedy patterns. Still some gotchas with ?, like
it ignores following rules that are zero or 1, ? type, and
just treats it as zero instances. But that's easy to work with.

9. Not totally done, but now moved more to having set data
tools set their $loaded{item} value in get data, not externally,
that makes it easier to track the stuff. Only where it makes
sense, but there's a lot of those set/get items, they should
probably all become package/classes, with set/get I think.

10. Optimized reader() and grabber() and set_ps_aux_data(), all
switched from using grep/map to using for loops, that means
inxi doesn't have to go through each array 2x anymore, actually
4x in  the case of set_ps_aux_data(). This saved a visible
amount of execution time, I noticed this lag when running
pinxi through NYTProf optimizer, there was a quite visible
time difference between grabber/reader and  the subshell
time, these optimizations almost removed that difference,
meaning only the subshell now really takes any time to run.

Optimized url_cleaner and data_cleaner in RepoData, those
now just work directy on the array references, no returns.

Ran some more optimization tests, but will probably hold off
on some of them, for example, using cleaner() by reference is
about 50% faster than by copy, but redoing that requires
adding in many copies from read only things like $1, so
the change would lead to slightly less clean code, but may
revisit this in the future, we'll see.

But in theory, basically all the core internal tools that
take a value and modify it should do that by reference
purely since it's way faster, up to 10x.
2021-03-15 18:44:00 -07:00
Harald Hope d11f2a7a89 small man fix 2021-02-08 17:15:46 -08:00
Harald Hope 2b49b32223 Bug fixes!! Fixes!!! Refactors!!! Edits!!!
Bugs:
1. Big bug, 3.2 appears to have introduced this bug, for disks, rotation and
partition scheme would never show, oops.

2. Tiny bug kept one specific smart value from ever showing, typo.

Fixes:
1. Accidentally followed Arch linux derived distro page, which claims KaOS as
arch derived, when of course it's not, it's its own distro, own toolchain, etc.
I kind of knew this but had forgotten, then I believed the Arch derived distro
page, oh well. Resulted in KaOS being listed with arch linux as system base
with -Sx. Arch should fix this, it's not like it's hard, just remove the distro
from the page.

2. Cleared up explanations for drivetemp vs hddtemp use, updated --recommends,
man, and help to hopefully make this clear. Debian will be dropping hddtemp,
which is not maintained, sometime in the coming years, sooner than later.
Note that users unfortunately have to manually enable drivetemp module unless
their distros enable it by default, but the man/recommands/help explain that.

3. Fixed smart indentation issues, that went along with code change 1, was
failing to indent one further level for failed/age values like it's supposed
to.

Enhancements:
1. Added /proc/device to debugger, that will help track block device main numbers

2. More disk vendors, more disk vendor IDs!!! As noted, the enternal flow flows
eternally, thanks linux-lite hardware database users!! and other inxi users,
whose outputs sometimes reveal a failure or two.

3. Added loaded kernel module tests to --recommends, this was mostly to let users
know that drivetemp is needed if you want non superuser fast drive temps, and
that this came along with kernels 5.6 or newer. Hopefully word will start drifting
out. Note that if inxi is using drivetemp values, drive temps will appear as
regular user with -Dx, and will be to 1 decimal place. hddtemp temps are
integers, and requires sudo to display the temps.

4. To handle issue #239  which I'd thought of trying off and on, but never did,
added option to -Dxxx to show SSD if a positive SSD ID was made to rotation:
So rotation will show either nothing, if no rotation or ssd data is detected,
the disk speed in rpm, or SSD if an SSD device. There may be corner cases where
this is wrong, but I don't have data for that, for example, if a disk is parked
and has zero rotation but is a HDD, not as SSD. I don't know what the data
looksl ike in that case. Note that if sudo inxi -Da is used, and smartctl is
installed, it should be right almost all the time, and with regular -Dxxx, it's
going to be right almost always, with a few corner cases. That slight
uncertainty is why I never implemented this before. Legacy drives also sometimes
did not report rotation speeds even when HDD, so those may create issues,
but inxi will only call it an SSD if it's an nvme, mmcblk device, both are
easy to ID as SSD, or if it meets certain conditions. It will not call a drive
an SSD if it was unable to meet those conditions.

INTERNAL CODE CHANGES:
1. Refactored the output logic for DiskData, that was messy, split it into a few
subs, and also refactored the way smartctl data was loaded and used, that's
much cleaner and easier to use now. Split the previous 1 big sub into:
totals_output(), drives_output(), and smart_output().
Also split out the smart field arrays into a separate sub, which loads
references to avoid creating new arrays and copying them all over when outputting
smart data. References are weird to work with directly but they are MUCH faster
to use, so I'm moving as much of the internal logic to use array raferences
instead of dereferenced arrays/hashes assigned to a new array, or hash.

2. Redid all the output modules and renamed them to be more consistent and
predictable, and redid the logic here and there to make the get() items be fairly
similar on all the data builder packages. Now as with the data subs, which
generally end in _data, now most of the output subs end with _output.

3. Roughly finished the process started in 3.2, got rid of redundant array loads,
changed:
@something = something_data();
push (@rows,@something);
to:
push (@rows,something_data());
which avoids creating an extra array, this also let me remove many arrays overall.

4. Missed a few hashes in machine data that were being passed directly, not as
references, to other subs, corrected that. I think I missed those because they
were %, so the search I did for @ in sub arg lists didn't catch the % hashes.
2021-02-08 17:07:34 -08:00
Harald Hope 6c9b259375 changelog, added one more bug item. 2021-01-28 23:09:29 -08:00
Harald Hope 244a8f3035 zfs raid level fix 2021-01-28 22:27:04 -08:00
Harald Hope 3a625f13ea Failed to use all possible sd block device major number matches, which
led to false disk total/used reports, that is, totals less than used.
2021-01-28 20:58:58 -08:00
Harald Hope 287b8cfe77 tiny fix for weird sdaj type > 26 drive systems 2021-01-28 20:29:12 -08:00
Harald Hope a68b1e8358 Bug fixes!! New Feature!! Edits, cleanups!!
Bugs:
1. Small bug, wrong regex would make mdraid unused report never show.
Was looking for ^used, not ^unused. No idea how that happened, but it's fixed.

2. Big RAID bug. Due to never having seen an 'inactive' state mdraid dataset,
inxi had a bunch of bugs around that. I'd assumed active and inactive would have
roughly the same syntax, but they don't. This is now corrected. Thanks Solus user
for giving me the required data. This case when not corrected resulted in a
spray of errors as RAID ran, and a fairly incomplete RAID report for mdraid.

3. A bug that probably never impacted anyone, but in SMART the matching rules
failed to match field name Size[s]? in the logical/physical block sizes.
However, those were already coming in from I believe pre-existing /sys data
for the drives but now it's fixed anyway. I had not realized that smartctl
made it plural when logical/physical were different, and singular when
they were the same.

Fixes:
1. Going along with bug 2, fixed some other admin/non admin report glitches.
Made patterns more aggressively matching, whitelist based to avoid the types
of syntax issues that caused bug 2.

2. Added 'faulty' type to mdraid matches, that had not been handled.

3. Found even more of those pesky 'card' references in help and man page,
replaced all of them with 'device[s]'.

4. Subtle fix, for debugger data collectors, added -y1 support, which can
be useful at times.

Enhancements:
1. In USB data grabber, added fallback case for unspecified type cases, now
uses a simple name/driver string test to determine if it's graphics, audio,
or bluetooth. This was mainly to make sure bluetooth usb devices get caught.

2. New feature! -E/--bluetooth. Gives an -n like bluetooth Device-x/Report.
Requires for the 'Report:' part hciconfig, which most all distros still have
in their repos. With -a, shows an additional Info: line that has more obscure
bluetooth hci data: acl-mtu sco-mtu, link-policy, link-mode, service-classes.

This closes the ancient, venerable issue #79, filed by mikaela so many years
ago. Better late than never!! However, features like this were really difficult
in legacy bash/gawk inxi 2.x, and became fairly easy with inxi 3.x, so I guess
we'll slowly whittle away at these things when the mood, and global pandemic
lockdowns, make that seem like a good idea...

Includes a small lookup table to match LMP number to Bluetooth version (bt-v:),
hopefully that's a correct way to determine bluetooth version, there was some
ambiguity about that.

-x, -xx, and -xxx function pretty much the same way as with -A, -G, and -N
devices, adding Chip IDs, Bus IDs, version info, and so on.
Since this bluetooth report does not require root and is an upper case option,
it's been added to default -F, similar to -R, and -v 5, where raid/bluetooth
shows only if data is found. With -v7 or -R or -E, always shows, including
no data found message.

Includes a fallback report Report-ID: case where for some reason, inxi could
not match the HCI ID with the device. That's similar to IF-ID in -n, which
does the same when some of the IFs could not be matched to a specific device.

3. For -A, -G, -N, and -E, new item for -xxx, classID, I realized this is
actually useful for many cases of trying to figure out what devices are,
though most users would not know what to do with that information, but that's
why it's an -xxx option!

4. Yes! You've been paying attention!! More disk vendors, and new vendor IDs!!
The cornucopia flows its endless bounty over the grateful data collector, and,
hopefully, inxi users!! Thanks as always, linux-lite hardware database, and
linux-lite users who really seem set on the impossible project of obtaining
all the disks/vendors known to man.

Changes:
1. Small change in wording for mdraid report:
'System supported mdraid' becomes 'Supported mdraid levels' which is cleaner
and much more precise.
2021-01-28 20:02:42 -08:00
Harald Hope 1e2d470c69 That damned Kate editor bug where it randomly sprays out characters
that were in the desktop clipboard caused 3 random pastes of the
characters 'failed' into the man page. Kate needs to get their damned
crap in order!!! It's becoming unusable.
2021-01-13 17:32:13 -08:00
Harald Hope 23b86ad5f2 typo fix 2021-01-10 21:01:32 -08:00
Harald Hope 6e4cd28791 New version, man page, bug fixes, changes, adjustments and cleanups!!!
Special thanks to mr. mazda for his ongoing suggestions, ideas, and observations.

Bugs:
1. In certain corner cases, it appears that lsusb has blank lines, which tripped
errors in inxi output when the usb parser was trying to access split keys that did
not exist. Added in check to make sure split actually resulted in expected data.

2. A red face bug, I'd left the output debugger switched on with json output, so
it was printing out the json data structure with Dumper, that's now switched off.
Hope this doesn't mess anyone up, but it would have mattered only if the person
was using:
--output json --output-type print
It did not effect xml output.

Fixes:
1. Got rid of extra level of -L data structure and output handler. Not visible
to users, but still irksome, so nice to get that fixed. Recursive structures are
confusing, lol, but this extra level was pointless, but to fix it required redoing
the logic a bit for both data generator and output feature.

2. Added in support for --display :0.0, previously it did not support the
.0 addition, but why not, if it works for people, good, if not, makes no difference.

3. There were some missing cases for LVM missing data messages, so the following
fixes were added:
 * In cases where lsblk is installed and user is non root, or lvs is not installed,
 but no lvm data is present, inxi now shows the expected 'Message: No LVM data found.'
 instead of the permissions or missing program error that showed before.
 If lsblk is not installed, and lvm is installed (or missing), with lvs not root
 readable, the permissiosn message (or missing program) will show since at that
 point, inxi has no way to know if there is lvm data or not.

 * Not an inxi, but rather an Arch Linux packaging bug, the maintainer of lvm
 has made lvs and vgs fail to return error number on non root start, which is
 a bug (pvs does return expected error return). Rather than wait for this bug
 to be fixed, inxi will just test if lvs and lsblk lvm data, it will show
 permissions message, otherwse the no lvm data message as expected.

I think these cover the last unhandled LVM cases I came across, so ideally, the
lvm data messages will be reasonably correct.

4. Some man page lintian fixes.

5. Changed usb data parser to use 'unless' instead of 'if' in tests since
it's easier to read unless positive tests are true than if negative or
negative etc.

Enhancements:
1. Since I see too often things like -F --no-host -z which is redundant, the
help and man now make it more clear that -z implies --no-host.

2. Even though it's not that pointful, I added in derived Arch Linux system
base like Ubuntu/Debian have. It's not that meaningful because unlike
Ubuntu/Debian, where you want to know what version the derived distro is
based on, Arch is rolling thus no versions, but I figured, why not, it's
easy to do, so might as well make the system base feature a bit more complete.

Note that the way I did this requires that the distro is ID'ed as its derived
distro nanme, not Arch Linux, that will vary depending on how they did their
os-release etc, or distro files, but that's not really an inxi issue, that's
up to them. From what I've been seeing, it looks like more of the derived
distros are being ID'ed in inxi as the derived name, so those should all work
fine. Note that seeing 'base:' requires -Sx.

3. More disk vendors!! More disk vendor IDs!!! I really dug into the stuff,
and refactored slightly the backend tools I use, so it's now a bit easier
to handle the data. Thanks linux-lite hardware database, as always, for
having users that really seemt to use every disk variant known to humanity.

Changes:
1. In -G, made FAILED: lower case, and also moved it to be after unloaded:
It was too easy to think that the loaded driver had failed. Also to make it
more explicit, made output like this, in other words, driver: is a container
for the possible children: loaded: unloaded: failed: alternate: which should be
easier to parse and read without mixing up what belongs to what.

driver: loaded: modesetting unloaded: nouvean,vesa alternate: nv
driver: loaded: amdgpu unloaded: vesa failed: ati

Note that if there is no unloaded: driver, failed: would still appear to come after
loaded:, but hopefully it's more clear now.

Basically what we found was that the presence of the uppercase FAILED: drew
the eye so much that it was sometimes not noted that it was a key: following
the driver: item, which itself because it did not list explicitly loaded:
was not as clear as it could have been. By making failed: the same as the
other key names visually, hopefully it will be less easy to think that the
loaded: driver failed:

In a sense, this is a legacy issue, because the original use of FAILED: was for
non free video drivers, to see when xorg had failed to load them, but over
more recent years, the most frequent thing I have been seeing is odd things
like failed: ati, when xorg tries to load the legacy ati driver when amdgpu
is being used.

2. Likewise, for RAID mdraid and zfs changed FAILED: to Failed:, again, to make it
more consistent with the other types.

3. In help menu and man page, removed legacy 'card(s)' in -A, -G, -N, and replaced
that with 'device(s)', which is the more accurate term, since the days when these
things were only addon cards are long behind us. I had not noticed that, but it
caught me eye and I realized it was a very deprecated and obsolete syntax, which
did not match the way inxi describes devices today.

4. It was pointed out how incoherent the naming of the item for setting wrap width,
--indent-min and config item INDENT_MIN were super confusing, since it was neither
indent or minimum, it was in fact wrap maximum, so the new options and config items
are --wrap-max and WRAP_MAX. Note that the legacy values will keep working, but
it was almost impossible in words to explain this option because the option text
was almost the exact opposite of what the option actually does. Redid the man
and help explanations to make the function of this option/config item more clear.

5. Made -J/--usb Hub-xx: to fit with other repeating device types in inxi output,
before Hub: was not numbered, but it struck me, it should be, like all the other
auto-incremented counter line starters, like ID-xx:, Device-x:, and so on.

6. Reorganized the main help menu to hopefully be more logical, now it shows the
primary output triggers, then after, the extra data items, -a, -x, -xx, -xxx,
separated by white space per type to make it easier to read. This also moved
the stuff that had been under the -x items back to where they should be, together
with the main output control options. For readability and usability, I think this
will help, the help menu is really long, so the more visual cues it has to make it
clear what each section is, the better I think. Previously -a was the first items,
then way further down was -x, -xx, and -xxx, then under those was -z, -Z, -y.
2021-01-10 19:20:21 -08:00
Harald Hope df45e6d4ae Bug Fixes!!! Continuing internal refactor!!
This bug report came in right after 3.2.00 went out live, but I would never have
found it myself in testing so better found than not found!

Bugs:

1. A bug was introduced to dmidecode data handlers in 3.2.00 resulted in the
dmidecode data array basically eating itself up until errors appear. Quite difficult
to trigger, but babydr from Slackware forums figured it out, using -F --dmidecode
to force dmidecode use for all features that support it triggered thee bug always.
This was a result of the refactor, previously inxi had worked on copies of referenced
arrays, but in this case, it was working on the original array of arrays, subtle,
but obvious. This method was only used on dmidecode arrays.

2. A second bug was exposed almost by accident, for -M --dmidecode data, there was
a missing field and also a missing is set test on that field that led to an error
of using undefined value in string comparison. This was strictly speaking 2 bugs,
both very old, from 2.9 first rewrite, one failing to set/get the value, and the
other failing to test if the value was set before using it.

Fixes:

1. There were a few glitches in help menu and man page related to -L option, those
are corrected.

INTERNAL CODE CHANGES:
1. removed bug inducing splice use in some cases, and added parens to splice to make
it fit the new way of with perl builtins, when taking 2 or more arguments, use parens.

2. Found many more instances to add -> dereferencing operator. I have to say, not
doing that consistently made the code much harder to read, and created situations
where it's somewhat ambiguous what item belongs to what, with everything consistently
-> operator run, the code is more clear and obvious, and some of the hacks I'd added
because of the lack of clarity were also removed.

3. Removed explicit setting of hash references with null value, that was done out
of failure to use -> operators which clearly indicate to Perl and coder what is
happening, so those crutches were removed. Also got rid of unnecessary array
priming like: my @array = (); Some of these habits came from other languages,
but in Perl, declaring my @array means it's an array that is null, and you don't
need to do a further (). @array = () is obviously fine for resetting arrays in
loops or whatever, but not in the initial declaration.
2020-12-17 14:51:11 -08:00
Harald Hope 9503a0010e recommends cleanup 2020-12-15 17:07:14 -08:00
Harald Hope 359c92f14f forgot to update recommends with lvs and mdadm 2020-12-15 16:23:01 -08:00
Harald Hope 421e637465 oops, forgot to add --logical to -L 2020-12-15 15:57:59 -08:00
Harald Hope 1f7241ed6b edits 2020-12-15 15:45:01 -08:00
Harald Hope 021bb48600 removed legacy comment 2020-12-15 15:31:16 -08:00
Harald Hope 38757e73a6 grammar 2020-12-15 15:29:38 -08:00
Harald Hope 10c38ebca4 typo 2020-12-15 15:27:02 -08:00
Harald Hope c7a2605a7c fixed typo 2020-12-15 15:18:39 -08:00
Harald Hope 61f5454c32 cleanup 2020-12-15 15:16:35 -08:00
Harald Hope 5234e3903d Huge upgrade, major rewrite/refactor, new features, everything is polished!!!
Note that due to large number of internal changes to code, a separate
INTERNAL CODE CHANGES section is at the bottom. Those are changes which in
general do not impact what users see that much, but which definitely impact
working on and with inxi! They also make errors less likely, and removed many
possible bad data error situations.

BUGS:

1. Obscure, but very old Tyan Mobo used a form of dmidecode data for RAM that I'd
never gotten a dataset for before, this tripped a series of errors in inxi, which
were actually caused by small errors and failures to check certain things, as
well as simply never assigning data in corner cases. This system used only dmi
handles 6 and 7, which is a very rare setup, from the very early days of dmi
data being settled, but it was valid data, and actually inxi was supposed to support
it, because I'd never gotten a dataset containing such legacy hardware data, the
support didn't work. There were actually several bugs discovered while tracking
this down, all were corrected.

2. Going along with the cpu fixes below, there was a bug that if stepping was 0,
stepping would not show. I had not realized stepping could be 0, so did a true/false
test instead of a defined test, which makes 0 in perl always test as false. This is
corrected.

3. While going through code, discovered that missing second argument to main::grabber
would have made glabel tool (BSD I think mostly) always fail, without exception.
That explains why bsd systems were never getting glabel data, heh.

4. Many null get_size tests would not have worked because they were testing
for null array but ('','') was actually being returned, which is not a null array.
The testing and results for get_size were quite random, now hey are all the same
and consistent, and confirmed correct.

5. In unmounted devices, the match sent to @lsblk to get extended device data
would never work with dm-xx type names, failed to translate them to their
mapped name, which is what is used in lsblk matches, this is corrected.
This could lead to failures to match fs of members of luks, raid, etc,
particularly noticeable with complex logical device structures. This means
the fallback filters against internal logic volume names, various file system
type matches, would always fail.

6. A small host of further bugs found and fixed during the major refactor, but
not all of them were noted, they were just fixed, sorry, those will be lost
to history unless you compare with diffs the two versions, but that's thousands
of lines, but there were more bugs fixed than listed above, just can't remember
them all.

FIXES:

1. There was some ambiguity about when inxi falls back to showing hardware graphics
driver instead of xorg gfx driver when it can't find an xorg driver. That can happen
for instance because of wayland, or because of obscure xorg drivers not yet supported.
Now the message is very clear, it says the gfx software driver is n/a, and that it's
showing the hardware gfx driver.

2. Big redo of cpu microarch, finally handled cases where same stepping/model ID
has two micorarches listed, now that is shown clearly to users, like AMD Zen family
17, model 18, which can be either Zen or Zen+, so now it shows that ambiguity, and
a comment: note: check, like it shows for ram report when it's not sure. Shows
for instance:
arch: Zen/Zen+ note: check
in such cases, in other words, it tells users that the naming convention
basically changed during the same hardware/die cycle.

3. There were some raid component errors in the unmounted tests which is supposed
to test the raid components and remove them from the mounted list. Note that inxi
now also tests better if something is a raid component, or an lvm component, or
various other things, so unmounted will be right more often now, though it's still
not perfect since there are still more unhandled logical storage components that
will show as unmounted when tney are parts of logical volumes. Bit by bit!!

4. Part of a significant android fine tuning and fix series, for -P, android uses
different default names for partitions, so none showed, now a subset of standard
android partitions, like /System, /firmware, etc, shows. Android will never work
well though because google keeps locking down key file read/search permissions in
/sys and /proc.

5. More ARM device detections, that got tuned quite a bit and cleaned up, for
instance, it was doing case sensitive checks, but found cases where the value
is all upper case, so it was missing it. Now it does case sensitive device type
searches.

6. One of the oldest glitches in inxi was the failure to take the size of the raid
arrays versus the size totals of the raid array components led to Local Storage
results that were uselessly wrong, being based on what is now called 'raw' disk
totals, that's the raw physical total of all system disks. Now if raid is detected
the old total: used:... is expanded to: total: raw:... usable:....used:, the usable
being the actual disk space that can be used to store data. Also in the case of
LVM systems, a further item is added, lvm-free: to report the unused but available
volume group space, that is, space not currently taken by logical volumes. This
can provide a useful overview of your system storage, and is much improved over
the previous version, which was technically unable to solve that issue because
the internal structures did not support it, now they do. LVM data requires sudo/
root unfortunately, so you will see different disk raw totals depending on
if it's root or not if there is LVM RAID running.

Sample: inxi -D
Drives:    Local Storage: total: raw: 340.19 GiB usable: 276.38 GiB
           lvm-free: 84.61 GiB used: 8.49 GiB (3.1%)

lvm-free is non assigned volume group size, that is, size not assigned
to a logical volume in the volume group, but available in the volume group.
raw: is the total of all detected block devices, usable is how much of that
can be used in file systems, that is, raid is > 1 devices, but those devices
are not available for storage, only the total of the raid volume is.
Note that if you are not using LVM, you will never see lvm-free:.

7.  An anonymous user sent a dataset that contained a reasonable alternate
syntax for sensors output, that made inxi fail to get the sensors data. That was
prepending 'T' to temp items, and 'F' to fan items, which made enough sense though
I'd never seen it before, so inxi now supports that alternate sensors temp/fan
syntax, so that should expand the systems it supports by default out of the box.

8. Finally was able to resolve a long standing issue of loading File::Find, which
is only used in --debug 20-22 debugger, from top of inxi to require load in the
debugger. I'd tried to fix this before, but failed, the problem is that redhat
/fedora have broken apart Perl core modules, and made some of them into external
modules, which made inxi fail to start due to missing use of required module that
was not really required. Thanks to mrmazda for pointing this out to me, I'd tried
to get this working before but failed, but this time I figured out how to recode
some of the uses of File::Find so it would work when loaded without the package
debugger, hard to figure it, turned out a specific sub routine call in that
specific case required the parentheses that had been left off, very subtle.

9. Subtle issue, unlike most of the other device data processors, the USB
data parser did not use the remove duplicates tool, which led in some cases
to duplicated company names in the output for USB, which looks silly.

10. Somehow devtmpfs was not being detected in all cases to remove that from
partitions report, that was added to the file systen filters to make sure it
gets caught.

11. Removed LVM image/meta/data data slices from unmounted report, those are LVM
items, but they are internal LVM volumes, not available or usable. I believe
there are other data/meta type variants for different LVM features but I have
added as many types as I could find.. Also explictly now remove any _member type
item, which is always part of some other logical structure, like RAID or
LVM, those were not explicitly handled before.

12. Corrected the varous terms ZFS can use for spare drives, and due to how
those describe slightly different situations than simply spare, changed the spare
section header to Available, which is more accureate for ZFS.

ENHANCEMENTS:

1. Going along with FIX 2 is updating and adding to intel, elbrus microarch family/
model/stepping IDs (E8C2), so that is fairly up to date now.

2. Added in a very crude and highly unreliable default fallback for intel:
/sys/devices/cpu/caps/pmu_name which will show the basic internal name used
which can be quite different from what the actual microarch name is, but the hope
is that for new intel cpus that come out after these last inxi updates, something
may show, instead of nothing. Note these names are often much more generic, like
using skylake for many different microarches.

3. More android enhancements, for androids that allow reading of /system/build.prop,
which is a very useful informative system info file, more android data will show,
like the device name and variant, and a few other specialized items. You can see if
your android device lets inxi read build.prop if you see under -S Distro:
Android 7.1 (2016-07-23) or just Android. If it shows just android, that means
it can't read that file. Showing Android however is also new, since while inxi
can't always read build.prop if that file is there, it's android, so inxi
finally can recognize it's in android, even though it can't give much info if
it's locked down. Inxi in fact did not previously know it was running in android,
which is quite different from ARM systems in some ways, but now it does.

If the data is available, it will be used in Distro: and in Machine: data to add
more information about the android version and device.

4. A big one, for -p/-P/-o/-j now shows with -x the mapped device name, not just
the /dev/dm-xx ID, which makes connecting the various new bits easier, for RAID,
Logical reports. Note that /dev/mapper/ is removed from the mapped name since
that's redundant and verbose and makes the output harder to read. For mapped
devices, the new --logical / -L report lets you drill into the devices to find
out what dm-xx is actually based on, though that is a limited feature which only
supports drilling to a depth of 2 components/devices, there can be more,
particularly for bcache, luks setups, but it's just too  hard to code that
level of depth, so something is better than nothing in this case, which
is the actual choice I was faced, the perfect in this case really is/was
the enemy of the good, as they say.

5. More big ones, for -a -p/-P/-o/-j shows kernel device major:minor number,
which again lets you trace each device around the system and report.

6. Added mdadm if root for mdraid report, that let me add a few other
details for mdraid not previously available. This added item 'state;'
to the mdraid report with right -x options.

7. Added vpu component type to ARM gfx device type detection, don't know
how video processing vcu had escaped my notice.

8. Added fio[a-z] block device, I'd never heard of that before, but saw
use of it in dataset, so learned it's real, but was never handled as a
valid block device type before, like sda, hda, vda, nvme, mmcblk,
etc. fio works the same, it's fio + [a-z] + [0-9]+ partition number.

9. Expanded to alternate syntax Elbrus cpu L1, L2, L3 reporting. Note
that in their nomenclature, L0 and L1 are actually both L1, so add those
together when detected.

10. RAM, thanks to a Mint user, antikythera, learned, and handled something
new, module 'speed:' vs module 'configured clock speed:'.
To quote from supermicro:

<<<
Question: Under dmidecode, my 'Configured Clock Speed' is lower than my
'Speed'. What does each term mean and why are they not the same?
Answer: Under dmidecode, Speed is the expected speed of the memory
(what is advertised on the memory spec sheet) and Configured Clock Speed
is what the actual speed is now. The cause could be many things but the
main possibilities are mismatching memory and using a CPU that doesn't
support your expected memory clock speed.
Please use only one type of memory and make sure that your CPU supports
your memory.
>>>

11. Since RAM was gettng a look, also changed cases where ddr ram speed is reported
in MHz, now it will show the speeds as: [speed * 2] MT/S ([speed] MHz). This
will let users make apples to apples speed comparisons between different systems.
Since MT/S is largely standard now, there's no need to translate that to MHz.

12. And, even more!! When RAM speeds are logically absurd, adds in note: check
This is from a real user's data by the way, as you can see, it triggers all
the new RAM per Device report features.

Sample:
Memory:
  RAM: total: 31.38 GiB used: 20.65 GiB (65.8%)
  Array-1: capacity: N/A slots: 4 note: check EC: N/A
  Device-1: DIMM_A1 size: 8 GiB speed: 1600 MT/s (800 MHz)
  Device-2: DIMM_A2 size: 8 GiB speed: spec: 1600 MT/s (800 MHz)
  actual: 61910 MT/s (30955 MHz) note: check
  Device-3: DIMM_B1 size: 8 GiB speed: 1600 MT/s (800 MHz)
  Device-4: DIMM_B2 size: 8 GiB speed: spec: 1600 MT/s (800 MHz)
  actual: 2 MT/s (1 MHz) note: check

13. More disks vendor!!! More disk vendor IDs!!! Yes, that's right, eternity
exists, here, now, and manifests every day!! Thanks to linux-lite hardware
database for this eternally generating list. Never underestimate the
creativity of mankind to make more disk drive companies, and to release
new model IDs for existing companies. Yes, I feel that this is a metaphore
for something much larger, but what that is, I'm not entirely clear about.

CHANGES:

1. Recent kernel changes have added a lot more sensor data in /sys, although
this varies system to system, but now, if your system supports it, you can
get at least partial hdd temp reports without needing hddtemp or root. Early
results suggest that nvme may have better support than spinning disks, but it
really varies. inxi will now look for the /sys based temp first, then fall
back to the much slower and root / sudo only hddtemp. You can force hddtemp
always with --hddtemp option, which has a corresponding configuration item.

2. The long requested and awaited yet arcane and obscure feature -L/--logical,
which tries to give a reasonably good report on LVM, LUKS, VeraCrypt, as well
as handling LVM raid, both regular and thin, is now working, more or less.
This took a lot of testing and will probably not be reasonably complete for
a while, mainly because the levels of abstraction possible between lvm,
lvm raid, mdraid, LUKS, bcache, and other caching and other encryption
options are just too deep to allow for easy handling, or easy outputs.
But a very solid and good start in my view, going from nothing to something
is always a big improvement!! LVM reports require root/sudo. This will,
finally, close issue #135.

3. Going along with -L, and serving as a model for the logic of -L, was the
complete refactor of -R, RAID, which was a real mess internally,  definitely
one of the messiest and hardest to work with features of inxi before the
refactor. It's now completely cleaned up and modularized, and is easy to add
raid types, which was not possible before, now it cleanly supports zfs, mdraid,
and lvm raid, with in depth reports and added items like mdraid size, raid
component device sizes and maj:min numbers if the -a option is used. Note
that LVM RAID requires root/sudo.

4. Added some more sensors dimm, volts items, slight expansion. Note that the
possible expansion of sensors made possible by the recently upgraded sensors
output logic, as well as the new inxi internal sensors data structure,
which is far more granular than the previous version, and allows for much
more fine grained control and output, though only gpu data currently takes
advantage of this new power under the covers, although as noted, the /sys based
hdd temps use the same source, only straight from /sys, since it was actually
easier using the data directly from sys than trying to map the drive locations to
specific drives in sensors output. Well, to be accurate, since now only
board type sensors are used for the temp/fan speed, voltage, etc, reports,
the removal of entire sensor groups means less chance of wrong results.

5. To bring the ancient RAID logic to fit the rest of inxi style, made
zfs, mdraid, and lvm raid components use incrementing numbers, like cpu
cores does. This got rid of the kind of ugly hacks used previously
which were not the same for zfs or mdraid, but now they are all the same,
except that the numbers for mdraid are the actual device numbers that
mdraid supplies, and the LVM and ZFS numbers are just autoincremented,
starting at 1.

6. Changed message <root/superuser required> to <superuser required> because
it's shorter and communicates the same thing.

INTERNAL CODE CHANGES:

1. Small, transparent test, tested on Perl 5.032 for Perl 7 compatibility. All
tests passed, no legacy code issues in inxi as of now.

2. Although most users won't notice, a big chunk of inxi was refactored
internally, which is why the new -L, the revamped -R, and the fixed
disk totals finally all can work now. This may hopefully result in more
consistent output and fewer oddities and randomnesses, since more of the
methods all use the same tools now under the covers. Ths refactor also
significantly improved inxi's execution speed, by about 4-5%, but most
of those gains are not visible due to the added new features, but the
end result is new inxi runs roughly the same speed as pre 3.2.00 inxi, but
does more, and does it better, internally at least. If you have a very
good eye you may also note a few places where this manifests externally
as well. Last I checked about 10-12% of the lines of inxi had been changed,
but I think that number is higher now. Everything that could be optimized
was, everything could be made more efficient was.

3. Several core tools in inxi were expanded to work much more cleanly,
like reader(), which now supports returning just the index value you want,
that always happened on the caller end before, which led to extra code.
get_size likewise was expanded to do a string return, which let me
remove a lot of internal redundant code in creating the size unit output,
like 32 MiB. uniq() was also redone to work exclusively by reference.

4. Many bad reference and dereference practices that had slipped into inxi
from the start are mostly corrected now, array assignments use push now,
rather than assign to array, then add array to another array, and assign
those to the master array. Several unnecessary and cpu/ram intensive copying
steps, that is, were removed in many locations internally in inxi. Also
now inxi uses more direct anonymous array and hash refernce assignments,
which again removes redundant array/hash creation, copy, and assignment.

5. Also added explicit -> dereferencing arrows to make the code more clear
and readable, and to make it easier for perl to know  what is happening.
The lack of consistency actually created confusion, I was not aware of
what certain code was doing, and didn't realize it was doing the same
thing as other code because of using different methods and syntaxes for
referencing array/hash components. I probably missed some, but I got many
of them, most probably.

6. Instituted a new perl builtin sub routine rule which is: if the sub
takes 2 or more arguments, always put in parentheses, it makes the
code much easier to follow because you see the closing ), like:
push(@rows,@row); Most perl builtins that take only one arg do not
use parentheses, except length, which just looks weird when used in
math tests, that is: length($var) > 13 looks better than length $var > 13.
This resolved inconsistent uses that had grown over time, so now all the
main builtins follow these rules consistently internally.

Due to certain style elements, and the time required to carefully go through
all these rules, grep and map do not yet consistently use these rules, that's
because the tendency has been to use the grep {..test..} @array and
map {...actions...} @array

7. Mainly to deal with android failures to read standard system files due to
google locking it down, moved most file queries to use -r, is readable, rather
than -e, exists, or -f, is file, unless it only needs to know if it exists,
of course. This fixed many null data errors in android even on locked androids.

8. Added in %mapper and %dmmapper hashes to allow for easy mapping and
unmapping of mapped block devices. Got rid of other ways of doing that,
and made it consistent throughout inxi. These are globals that load once.

9. Learned that perl builtin split() has a very strange and in my view originally
terrible decision that involves treating as regex rules string characters in split
string, like split('^^',$string), which should logically be a string value, not
a ^ start search followed by a ^, but that's how it is, so that was carefully checked
and made consistent as well. Also expanded split to take advantage of the number of
splits to do, which I had only used occasionally before, but only updated field/value
splits where I have a good idea of what the data is. This is very useful when the
data is in the form of field: value, but value can contain : as well. You have to
be very careful however, since some data we do want in fact the 2nd split, but not
the subsequent ones, so I only updated the ones I was very sure about.

10. Going along with the cpu microarch fixes, updated and cleaned up all the lists
of model/stepping matches, now they are all in order and much easier to scan and
find, that had gotten sloppy over the years.

11. More ARM, moved dummy and codec device values into their own storage arrays,
that let me remove the filters against those in the other detections. Makes logic
easier to read and maintain as well.
2020-12-15 15:13:14 -08:00
Harald Hope 0eedb2c89e typo fixes 2020-11-11 15:49:05 -08:00
Harald Hope f30d907c4c man page fix 2020-11-11 15:45:10 -08:00
Harald Hope 0e56aeeb74 updted changelog 2020-11-11 15:35:59 -08:00
Harald Hope 285c6f715f Bug fixes, new features!! Update now!! Or don't, it's up to you.
Bugs:
1. Let's call some of the android fixes and debugger failures bugs, why not?
Those are fixed. Note that many of these fixes will impact any system that is
ARM based, not just android.

Fixes:
1. Related to issue #226 which was a fine issue, fine tuned the debugger debuggers
to allow for smoother handling of /sys parse failures. Also added debugger filters
for common items that would make the /sys parser hang, oddly, most seem to be in
/sys/power for android devices.

2. Added some finetunings for possible mmcblk storage paths, in some cases, an
extra /block is added, which made inxi think mounted drives were unmounted. I've
never seen this extra /block except on mmcblk devices on android, but you never
know, it could be more widespread.

3. Also mainly related to android, but maybe other ARM devices, in some cases,
an errant 'timer' device was appearing as a cpu variant, which is wrong. That was
a corner case for sure, and part of the variant logic in fact uses timer values
to assign the actual cpu variants, but it was wrong in this case because it was
....-timer-mem, not ...-timer, which led to non-existent CPU variants showing.

4. Issue #236 by ChrisCheney pointed out that inxi had never updated its default
/proc/meminfo value to use the newer MemAvailable as default if present, which led
to incorrect memory used values showing up. That's because back in the old days,
we had to construct a synthetic Memory used from MemFree, buffers, cache, etc, but that
wasn't always right, since sometimes the cache actually isn't available, often is,
but not always.
34e431b0ae
This commit on the kernel explains it pretty clearly.
Thanks Chris for bringing this to our attention.

5. Kind of more future-proofing, got rid of a bunchy of hard-coded strings internally
and switched those to use the row_defaults values, which is where string messages
are supposed to go. That was mostly in the initial program check messages on start-up,
but also a few other stray ones. Also consolidated them a bit to get rid of redundant
messages, and added more variable based messages, like for missing/permissions on
programs etc. The idea in general is that all the strings are contained in subs so
that in theory they could be swapped for other strings, eg, languages, but honestly,
I no longer see this as very likely to ever happen. But it's still nice to be
consistent internally and not get sloppy with english strings.

This also got rid of some largely redundant items in row_defaults, and expanded the
list of handled events, and of variable based events, so it shouldn't be as necessary
to add new row_defaults items for similar events.

Enhancements:
1. Debugger item to maybe try to find distro OEM, this was connected with issue #231
but the issue poster vanished, and didn't do the work required, so this one won't
happen until someone who cares [not me, that is] does the required work.
It's always funny to see how quickly people vanish when they have to do the actual
boring research that they want me to do for them, lol. Or maybe, sigh is more
appropriate than lol. But it is pretty much par for the course, sad to say.
Or maybe this was an OEM hoping to have someone do their corporate work for them
for free, who knows. Anyway, there's a certain category of items that I'm reasonably
happy to implement, but NOT if I have to do all the boring research work, so such
features being added will depend on the poster actually doing the boring work.

I've gotten burned on this a few times, cpu arch: for example, some guy said he'd
track that and provide updates, he never even made it to the first release, so I got
stuck doing that one forever after. But that one at least has some general value, so
that's ok more or less, but I definitely won't take on stuff that I really don't
personally care at all about unless the person requesting the feature does all the work
beforehand. The boring part, that is....

2. Related to issue #226, much improved android ID and many small android fixes for
machine data etc. Now uses /system/build.prop for some data, which is a nice source,
sadly, most modern android devices seem to be locked down, with both build.prop and
/sys locked down, which makes inxi unable to actually get any of that data, but if
your device either does not have these root only readable, or if you have an android
rooted phone, the android support will be more informative.

Hint: if you run inxi in termux on your non rooted android device, and it shows
you what android version you are using in System:... Distro: line, then your android
is not locked down. I have one such phone, android 7.1, but I cannot say how usual
or non usual this is. The poster of issue #226 for instance had to root his android
7 phone to get this data to display. So it seems to vary quite a bit.

Note that due to these file system lockdowns, in general, trying to do android arm
support remains largely a waste of time, but on some devices sometimes, you can now
get quite nice system info. As I noted in the issue, if I can't get the features to
work on a non rooted phone in my possession, I'm probably not going to try to do the
work because it's too hard to try to work on android issues without having the device
in front of you for testing and debugging. In this case, one of my phones did work, so
I did the work just to see where android is at now.

Android showed some slightly odd syntaxes for some devices, but those are now handled
where I got a dataset for them that revealed the changes required.

3. Also related to issue #226 for termux in android, will show -r info.
That's an apt based package manager, but termux puts the apt files somewhere else so
needed to change paths if those alternate paths existed for apt.

4. Added PARTFLAGS to debugger to see what knd of data that will yield, that's
a lsblk key/value pair.

5. Just because it's easy to do, added new -Ixxx item, wakeups: which is a
subset of Uptime, this will show how many times the system has been woken from
suspend since the last boot. If the system has never been suspended, shows 0.

6. Many more disk vendors and disk IDs. The list just never ends, possibly a
metaphor for something, the endless spinning of maya, who knows?

7. Added newest known ubuntu release, hirsute, to buntu ID logic. Might as well
catch them early, that will be 21.04.
2020-11-11 15:35:08 -08:00
Harald Hope e45c696010 Bug fixes, updates!!! Yes!! Why wait!!! Can't stay frozen forever!
Bugs:
1. Not an inxi bug, but a weird change in defaults for ubuntu GNOME ENV
variable values when running at least the gnome desktop, result to end
users appears to be a bug. This resolves issue #228
Note that so much weird non desktop data was put into those environmental
variables that inxi simply could make no sense of it. The fix was to make
the detections more robust, using regex instead of string compare, as well as
to at least try to strip out such corrupted data values, though that can never
be fully predictable.
As far as I know, this issue only hits ubuntu gnome desktops, I've never seen these
value corruptions on any other distro, or on any other ubuntu desktop, though
they may be there, but I'm not going to test all the ubuntu spins to find out.

I'm hoping the combination of logic fixes and junk data cleaning will handle
most future instances of these types of corruptions automatically.

Again, this only happens on relatively laste ubuntu gnomes as far as I know.

Fixes:
1. An oversight, added sshd to list of whitelisted start clients. This permits
expected output for: ssh <name@server> inxi -bay
that is, running inxi as an ssh command string. Should have done that a while ago,
but better late than never.
This corrects issue #227, or at least, has a better default, it worked fine before,
but required using --tty to reset to default terminal behavior. The problem is
that if inxi can't determine what it's running in, it defaults to thinking it's
in an IRC client, and switches to IRC color codes, among other changes.
But it was nice to get sshd covered automatically so users don't have to know
the --tty option.

Changes:
1. More disk vendors and vendor IDs!!! Yes, that's right, the list never ends!!
2020-10-16 13:54:25 -07:00
Harald Hope 4e4c0d8e14 more edits 2020-09-29 16:41:46 -07:00
Harald Hope 31e1a933a0 small edit 2020-09-29 16:32:31 -07:00
Harald Hope ef428e75e1 Bug fixes, feature updates, changes!!
Bugs:
1. There was a glitch in the pattern that made -D samsung / seagate not ID right,
fixed.

2. I  do not like calling this a bug, because it's not an inxi bug, it's an upstream
regression in the syntax used in /proc/version, they changed a fully predictable
gcc version .... to a random series of embedded/nested parentheses and other random
junk. inxi tries to deal with this regression, which will be perceived as a bug in
systems running kernel 5.8 or newer and inxi 3.1.06 or older, since it will fail to
show the kernel build compiler version since it can't find it in the string.

I really dislike these types of regressions caused by bad ideas done badly and
without any thought to the transmitted knowledge base, but that's how it goes,
no discipline, I miss the graybeards, who cared about things like this.

Fixes:
1. more -D nvme id changes, intel in this case.

2. FreeBSD lsusb changed syntax, which triggered a series of errors when run.
Since I never really got the required data [hint bsd users, do NOT file issues
that you want fixed and then not provide all the data required, otherwise, really,
why did you file the issue? did you expect magic pixies to fly in with the required
data?] See the README.txt for what to do to get issues really handed in BSDs.

tldr; version: if you won't spend the time providing data and access required,
I won't spend the time on the issue, period, since if you don't care enough to
do those simple steps, why on earth do you expect me to?

Changes:
1. -C 'boost' option changed from -xxx feature to -x feature.
Consider it a promotion!

2. Added --dbg 19 switch to enable smart data debugging for -Da.

3. Some new tools to handle impossible data values for some -D situations for SMART
where the smart report contains gibberish values, that was issue #225 -- tools were
convert_hex and is_Hex. The utility for these is limited, but might be of use in
some cases, like handling the above gibberish data value.
2020-09-29 16:22:15 -07:00
Harald Hope ddbd8e8679 fixed seagate/samsung glitch 2020-08-17 15:23:55 -07:00
Harald Hope b1650ea2a8 New features, new changes, new bug fixes!!! Excitement!!! Thrills!!!
Bugs:
1. Forgot to set get Shell logic in inxi short form, oops, so Shell remained blank,
only inxi short, which I rarely use so I didn't notice.

2. Failed to test pacman-g2 for packages, had wrong query argument, so it failed.
Also failed to test for null data, so showed errors for packages as well. Both
fixed.

3. A big bug, subtle, and also at the same time, an enhancement, it turns out NVME
drives do NOT follow the age old /proc/partitions logic where if the minor number is
divisible by 16 or has remainder 8 when divided by 16, it's a primary drive, not
a partition. nvme drives use a random numbering when > 1 nvme drives are present, and
the old tests would fail for all nvme drivers more than the first one, which led
to wrong disk size totals. Thanks gardotd426 who took the time to help figure this
out in issue #223 - fix is to not do that test for nvme drives, or rather, to add
a last fail test for nvme primary nvme[0-9]n[0-9] drive detections, not the minor
number.

Fixes:
1. Corrected indentation for block sizes, children were not indented.

2. Updated some older inxi-perl/docs pages, why not, once in a while?

3. Kernel 5.8 introduces a changed syntax to gcc string location, this has been
corrected, and the kernel gcc version now shows correctly for the previous
syntax and the new one. Hopefully they do not change it again, sigh...

4. Removed string 'hwmon' sensors from gpu, those are not gpu sensors, and
are also usually not board/cpu sensors, but things like ath10, iwl, etc,
network, or disk sensors, etc. In some cases hwmon sensor data would appear

Enhancements:
1. Big sensors refactor, now inxi supports two new sensors options:
--sensors-exclude - which allows you to exclude any primary sensor type[s]. Note that
in the refactored logic, and in the old logic, gpu sensors were already excluded.
Now other hardware specific sensors like network are excluded as well.

--sensors-use - use ONLY list of supplied sensor IDs, which have to match the
syntax you see in lm-sensors sensors output.

Both accept comma separated list of sensors, 1 or more, no spaces.

The refactor however is more far reaching, now inxi stores and structures data
not as a long line of sensors and data without differentiation, but by sensor array/chip
ID, which is how  the exclude and use features can work, and how granular default
hardware sensor exclusions and uses can happen. This is now working in the gpu
sensors, and will in the future be extended to the newer 5.7/5.8 kernel disk
temperature sensors values, which will lead in some cases to being able to get
sensors data for disks without root or hddtemp. This is a complicated bit of logic,
and I don't have time to do it right now, but the data is now there and stored
and possible to use in the future.

To see sensors structures, use: inxi -s --dbg 18 and that will show the sensors data
and its structures, which makes debugger a lot easier for new features.

This issue was originally generated by what was in my view an invalid complaint
about some inxi sensors defaults, which led me to look more closely at sensors
logic, which is severely lacking. More work on sensors will happen in the future,
time, health, and energy permitting.

2. Added Watts, mem temp, for amdgpu sensors, as -sxxx option. More gpu sensor
data will be added as new data samples show what will be available for the
free modules like amdgpu, nouvean, and the intel graphics modules.

3. More disk vendors and IDs, as noted, the list never ends, and it hasn't ended,
so statement remains true. Thanks linux-lite hardware database.

Changes:

1. This has always bugged me since it was introduced, the primary cpu line starter
Topology: which was only technically accurate for its direct value, not its children,
and also, in -b, cpu short form was using the value as the key, which is a no-no,
I'd been meaning to fix that too, but finally realized if I just make the primary
CPU line key be 'Info:', which is short, yet non-ambiguous, it would solve both
problems.
To keep the -b cpu line as short as before, I removed the 'type:' and integraged
that value into the primary Info: string:
CPU:
  Info: 6-Core AMD Ryzen 5 2600 [MT MCP] speed: 2750 MHz min/max: 1550/3400 MHz

-b 3.1.05 and earlier:
CPU:
  6-Core: AMD Ryzen 5 2600 type: MT MCP speed: 1515 MHz min/max: 1550/3400 MHz

These resolve something that has irked me for quite a while, 'Topology:' didn't
fit, it was too geeky, and worst, it only applied to the value directly following
it, NOT to the rest of the CPU information. It also could not be shortened or
abbreviated since then it would have made no actual sense, like topo:, and the
same issue with value being used for key in -b, and wrong word for line starter
in -C would have existed. Besides, someone might think I was trying to make a
subtle reference to the great Jodorowsky film 'El Topo', which would be silly,
because that's art, and this is just some system specs that are reasonably
readable...

2. Was using opendns for WAN dig IP address, but apparently cysco bought that
company, and now I've noticed the old opendns dig queries were failing more and
more, so replaced that with akamai dig requests.
Also made the WAN IP fallback to HTTP IP method if dig failed. New option:
--no-http-wan and config item NO_HTTP_WAN with override --http-wan added to
let you switch off http wan IP requests if you want. Note that if dig fails,
you will get no wan ip address.
Updated/improved error messages to handle this more complex set of wan ip
options, so hopefully the error alert message will in most cases be right.

3. To future proof inxi, switched debugger upload location to ftp.smxi.org/incoming
from the old techpatterns.com/incoming. Updated man/help to remove those urls too.
2020-08-16 15:27:11 -07:00
Harald Hope f16e714dc6 two bugs fixed, first: forgot to set shell generator on inxi short feature,
so shell is blank, second, unhandled new 5.8 kernel /proc/version syntax.
Normally I'd do a new numbered release, but I want these out asap and will
do a full new release later, there are some features under development in
pinxi for sensors that will take some time to handle.
2020-08-10 19:08:29 -07:00
Harald Hope 2ebd05dfb6 bug fix for pacman-g2, used bad data source for the info command for g2. 2020-08-10 18:17:07 -07:00
Harald Hope 6ce9149bb1 bug fix, bad copy paste 2020-07-28 07:54:33 -07:00
Harald Hope b3b734d87a tiny patch to fix indentation on disk block-physical 2020-07-27 15:22:41 -07:00
Harald Hope 3224a39f80 man page typo fix 2020-07-26 20:36:27 -07:00
Harald Hope bbcaed9475 Bug fixes!!! New Features!! Why wait!!!
Bugs:
1. Issue #220 on github: inxi misidentified XFCE as Gnome. This was a kind of core
issue, and pointed to some logic that needed updating, and some inadequate
assumptions made, and some too loose cascade of tests. Hopefully now xfce will
almost never get misidentified, and the other primary desktops ID'ed either from
$ENV or from xrop -root will be slightly more accurately identified as well.

Note that this fix creates a possibility for obscure misconfigured desktops to
be ID'ed wrong, but in this case, that will be technically a bug for them, but
with the new fixes, that situation will be cleaner to handle internally in the
desktop ID logic.

Also tightened the final Gnome fallback detection to not trigger a possible
false positive, it was testing for ^_GNOME but that is not adequate, because
some gnome programs will trigger these values in xprop -root even if GNOME
is not running. Should be safer now, hopefully no new bugs will be triggered
by these changes.

Fixes:
1. Missed an indentation level for -y1, gcc alt should have been indented in
one more level, now it is.

2. In disk vendors/family, didn't clean items starting with '/', this is
now corrected. Yes, some do, don't ask me why. Might be cases like:
Crucial/Micron maybe, where the first ID is grabbed, not sure.

Enhancements:
1. New Disk vendors, vendor IDs!!! The list never ends!!! We've finally found
infinity, and it is the unceasing wave of tiny and not so tiny disks and their
Ids.

2. New feature: for -Aa, -Na/-na/-ia, -Ga, now will add the modules the kernel
could support if they were available on the Device-x lines of those items.
This was made an -a option because it really makes no sense, if it's a regular
option, users might think that for example an nvidia card had a nouveua driver
when it didn't, when in fact, all the kernel is saying is that it knows those
listed modules 'couid' be used or present. This corresponds to the Display:
item in -Ga, that lists 'alternate:' drivers that Xorg knows about that could
likewise be used, if they were on the system.

In other words these are --admin options because otherwise users might get confused,
so this is one where you want to know the man explanation before you ask for it.

It is useful however if you're not sure what your choices are for kernel modules.

When the alternate driver is the same as the active driver, or if none is found,
it does not show the alternate: item to avoid spamming.
2020-07-26 19:22:59 -07:00
Harald Hope 776c788273 one more changelong typo fix 2020-06-28 22:42:50 -07:00
Harald Hope 7255a3dedc fixed changelog typos 2020-06-28 22:40:03 -07:00
Harald Hope 0645c3a7a6 New version, new man, huge update, bug fixes, cleanups, updates!!
What started as a relatively minor issue report ended up with a refactor of big
chunks of some of the oldest code and logic in inxi.

So many bugs and fixes, updates, and enhancements, that I will probably miss some
when I try to list them.

Bugs:
1. In the process of fixing an issue about sudo use triggering server admin
emails on failure, when --sudo/--no-sudo and their respective configuration
items were added, sudo was inadvertently disabled because the test ran before
the options were processed, which meant the condition to set sudo data was
always false, so sudo for internal use was never set. The solution was to
set a flag in the option handler and set sudo after options or configs run.

2. Issue #219 reported gentoo and one other repo type would fail to show
enabled repos, and would show an error as well, this was due to forgetting
to make the match test case insensitive. If only all bugs were this easy
to fix!!

3. I'd seen this bug before, and couldn't figure out why it existed.
It turned out that the partition blacklist filters were running fine
in the main partition data tool, but I had forgotten to add in corresponding
lsblk partition data filters, lol, so when the logic went back and double
checked for missing partitions [this feature had been if i remember right
to be able to show hidden partitions, which the standard method didn't see,
but lsblk did, anyway, when the double check and add missing partitions
logic ran, inxi was putting back in the blacklisted partitions every time,
despite the original blacklists working well and as intended.
This was fixed by adding in all the required fs type blacklists, then
adding in comments above each black list reminding coders that if they
add or remove from one blacklist, they have to do the same on the other.

4. Found while testing something unrelated on older vm, the fallback
case for cpu bugs, which was supposed to show the basic /proc/cpuinfo
cpu bugs, was failing inexplicably because the data was simply being
put into the wrong variable name, sigh.

Fixes:
1. While not technically an inxi bug, it would certainly appear that way to
anyone who triggered it. We'd gotten issue reports before on this, but they
were never complete, so couldn't figure it out. Basically, if someone puts
inxi into a simple script that is $PATH [this was the missing fact needed to
actually trigger this bug in order to fix it], the script [not inxi], will
then enter into an endless loop as inxi queries it for its version number using
<script name> --version. This issue didn't happen if the script calling inxi
was not in PATH, which is why I'd never been able to figure it out before.

Only simple scripts with no argument handlers could trigger this scenario,
and only if they were in PATH.

Fixing this required refactoring the entire start get_shell_data logic, which
ended up with a full refactor of the program_version logic as well. The fix
was to expand the list of shells known by inxi so it would be able to recognize
when it was in a shell running a script running inxi.

This resulted in several real improvements, for instance, inxi will now almost
always be able to determine the actual shell running inxi, even when started
by something else. It will also never use --version attempts on programs it does
not know about in a whitelist.

So we lose slightly the abilty to get version data on unknown shells, but we
gain inxi never being able to trigger such an infinite loop situation.

2. As part of the program_version refactor, a long standing failure to get ksh,
lksh, loksh, pdksh, and the related posh shells, all of which ID their version
numbers only if they are running the command in themselves. The mistake had
been having the default shell run that command. These all now correctly identify
themselves.

3. As part of the wm upgrades, many small failures to ID version numbers, or
even wm's, in some cases, were discovered when testing, and corrected. Some
I had not tested, like qtile, and the lisp variants, were not being detected
correctly by the tests due to the way python or lisp items are listed in ps aux.

4. As part of the wm update and program_version refactor, updated and simplified
many desktop and wm detections and logic blocks. Ideally this makes them more
preditable and easy to work on for the future.

5. As some last tunings for the new -y1 key: value pair per line output option,
fixed some small glitches in -b indentation. Also improved RAID indenting,
and Weather, and made it all very clean and predictable in terms of indentations.

6. Something I'd slightly noticed but never done anything about, while testing
desktop fixes, I realized that for Desktop: item, dm: is a secondary data type,
but if it's Console:, then DM: is a primary data type, not a secondary one. So
now if Console: it becomes DM: whic makes sense, previously it implied a dm:
was used to start the console, which was silly. Also, since often the reason
it's Console: with no dm in the first place is that it's a server with no dm.
So now if console, and no dm detected, rather than showing DM: N/A it just
doesn't show dm at all.

7. As part of the overall core refactor, the print_data logic was also refactored
and simplified, by making -y1 a first class citizen, it led to significantly
different way of being able to present inxi data on your screen, and now
print_data logic is cleaner and reflects these changes more natively, all the
initial hacks to get this working were removed, and the logic was made to be
core, not tacked on.

8. A small thing also revealed in issue #219, battery data was not being
trimmed, not sure how I missed that, but in some cases, space padding was in the
values and was not removed, which leads to silly looking inxi output.

9. Several massive internal optimizations, which were tested heavily, led to
in one case, 8-900x faster execution the second time a data structure is used,
previously in program_values the entire list was loaded each time program_values
was called, now it's loaded into a variable on first load and the variable is
used for the tests after that. This was also done for the vendor_version for
disk vendors, which also features a very long data structure which can be
loaded > 1 times for instances where a system has > 1 disk.

I also tested while I was at it, to see if loading these tyeps of data structures,
arrays of arrays, or hashes of arrays, by reference, or by dereferencing their
arrays, was faster, and it proved that it's about 20% faster to not
dereference them, but to use them directly. So I've switched a number of the
fixed data structures internally do use that method.

Another tiny optimization was hard resetting the print_data iterator hash,
while this would never matter in the real world, it showed that resetting
the iterator hash manually was slightly more efficient than resetting it
with a for loop.

10. While  not seen inside inxi, I updated and improved a number of the vm's
used to test inxi and various software detections, so now I have a good selection,
going back to 2008 or so, up to current. This is helpful because things like
shells and window managers and desktops come and go, so it is hard to test
old detections on new stuff when you can't install those anymore. You'll see
these fixes in many of the less well known window managers, and in a few of
the better known ones, where in some cases the detections were damaged.

11. As part of the program_version refactor, updated and fixed file based
version detections, those, ideally, will almost never be used. Hopefully
programmers of things like window managers, shells, and desktops, can
learn how to handle --version requests, even though I realize that's a lot
harder than copying someone's code and then rebranding as your own project, or
whatever excuse people have for not including a --version item in their softaware.

Enhancements:
1. As a result of the shell, start shell, shell parent refactors, inxi was able
to correctly in most cases deetermine also the user default shell and its verison,
so that was added as an -Ixxx option:
Shell: ksh v: A_2020.0.0 default: Bash v: 5.0.16

2. As part of the program_version refactor, a more robust version number
cleaner was made, which now allows for much more manipulation of the version
number string, which sometimes contains, without spaces, non version number '
info right before the actual version.

3. Many more wm IDs were created and tested, and some old virtual machines
that were used years ago were used again to test old window managers and
their IDs, as well as new vms created to test newer ones. Many version
IDs and WM ids were fixed in this process as well. All kinds of new ones
added, though the list is basiclaly endless so ideally inxi would only use
its internal data tables for window managers that have actual users, or did.

4. First wayland datatype, now it may show Display ID: with -Ga, so far that's
the only wayland screen/display data I can get reliably.

5. As part of the shell parent/started in: updates and fixes, added every shell
I could find, and installed and tested as many of them as possible to verify
that either they have no version method, or that their version method works.
This shell logic also is used to determine start parent. Obviously using
whitelists of things that can change over time isn't ideal, but there was no
way to actually do it otherwise. The best part of the fixes is that it's now
remarkably difficult to trick inxi into reporting the wrong shell, and it
generally will also get the default shell right, though I found cases in
testing where a shell when started replaces the value in $SHELL with itself.

6. I found a much faster and reasonably reliable way to determine toolkits
used by gtk desktops, like cinnamon, gnome, and a few others. Test is to
get version from gtk-launcher, which is MUCH faster than doing a package
version query on the random libgtk toolkit that might be tested, and actually
was tested for pacman, apt, and rpm in the old days, but that was removed
because it was a silly hack. It's possible that now and then gtk desktops
will be 0.0.1 versions off, but in most cases, the version matched, so I decided
to restore the tk: item for a selection of gtk or gnome based desktops.

So now gtk desktops, except mate, which of course will be using gtk 2 for a
while longer, toolkit version should be working again, and the new method
works on everything, unlike the old nasty hack that was used, which required
package queries and guessing at which gtk lib was actually running the desktop,
it was such a slow nasty hack that it was dumped a while ago, but this new
method works reliably in most cases and solves most of the issues.

7. As part of the overall program_versions refactor, the package version
tester tool was extended to support pacman, dpkg, and rpm, which in practical
terms covers most gnu/linux users and systems. Since this feature is literally
only used for ASH and DASH shell version detections, it was really just added
as a proof of concept, and because it fit in well with the new Package counts
feature of -I/-r.

8. Updated for version info a few other programs, added compositors as well.

9. Last but not least!! More disk vendor IDs, more disk vendors!! And found
another source to double check vendor IDs, that's good.

New Features:
1. For -Ix/-rx, -Ixx/-rxx, -Ia/-ra, now inxi shows package counts for most
package managers plus snap, flatpak, and appimage. I didn't test appimage so
I'm not 100% sure that works, but the others are all tested and work.

If -r, Packages shows in the Repos item as first row, which makes sense, packages,
repos, fits. Note that in some systems getting full package counts takes some
time so it's an -x option not default.
If -rx, -rxx, -ra, package info moved to -r section, and if -Ix, -Ixx, or -Ia,
the following data shows:
 * -Ix or -rx: show total package counts: Packages: 2429
 * -Ixx or -rxx: shows Packages then counts by package manager located. If there
 was only one package manager with packages, the total moves from right after
 Packages: to the package manager, like: Packages: apt: 3241 but if there were
 for example 2 or more found, it would show the total then:
 Packages 3245 apt:3241 snap: 4
 * -Ia or -ra: adds package managers with 0 packages managed, those are not
 show with -xx, and also shows how many of those packages per package manager
 is a library type lib file.
 Sample:
 inxi -Iay1
Info:
  Processes: 470
  Uptime: 8d 10h 42m
  Memory: 31.38 GiB
    used: 14.43 GiB (46.0%)
  Init: systemd
    v: 245
    runlevel: 5
  Compilers:
    gcc: 9.3.0
    alt: 5/6/7/8/9
  Packages:
    apt: 3685
      lib: 2098
    rpm: 0
  Shell: Elvish
    v: 0.13.1+ds1-1
    default: Bash
      v: 5.0.16
    running in: kate
  pinxi: 3.1.04-1
2020-06-28 22:22:12 -07:00
Harald Hope 03e6abe3e2 fixed accidental patch number bump 2020-06-17 12:20:42 -07:00
Harald Hope e7f7110e6c Fixed a bug with repos, failed to do case insensitive test, which
resulted in issue #219 failure.
2020-06-17 12:18:17 -07:00
Harald Hope 166c1364d2 Big internal refactor!! Fully adjustable indentation logic, built in, native!
NOTE: none of these changes have any impact on normal inxi -y -1, -y, or -y xx
operation, everything will remain exactly the same, this only changes and
makes robust -y 1 single key: value pair per line output.

3.1.03 finishes the -y1 introduced in 3.1.02, but makes it a core part of the inxi
logic for line printing, not a tacked on afterthought.

Because the first draft of this in 3.1.02 was really a hack tacked onto the existing
logic, which was not very flexible or robust, and required way too much literal test
logic in the black box print_data() subroutine, which is supposed to be a 'dumb'
logic, that just does what you give it automatically, I added in key changes that
hard code the indentations per key, like so:

Now: 34#0#3#key-name
Before: 34#key-name

Note that anyone using the json or XML output option may need to redo their code
a bit to handle these extra 2 values that preface the actual key names.

Fixes:
1. In order to make this work, changed a few small things internally, a few
key names were slightly altered to make them more clear.

Changes:
1. Redo of all internal full key strings, added two new # separated items:
 xx#x#y#key-name:
  * xx remains the main 0 padded 2 digit sorter per row/block.
  * x is a new 0/1 boolean, that shows if the value is a container or not. As
    currently implemented probably not hugely useful since it won't say when
    the following items it is a container of ends.
    Note that the following y value will always be 1 for the item contained by
    the container, so you can check that way if you want. the next item can
    also be a container, but it would have either the same indentation level
    as the previous container or be different.
    Thus, if a key is a container, it can contain either non containers, or
    other containers, but that primary container does not end until the indent
    value equals or is less than the indent value of the first container.
    If you are a programmer you should be able to figure this out.
  * y is the indentation level, 0-xx is supported, but in practical terms, only
    4 levels are used. For single line output, these set the indentation for that
    key.
  * key-name remains the key string ID name.

2. For -y 1 -G will show drivers then indented one more level unloaded, FAILED,
and alternate: to make it clear those are a subset of drivers. driver: itself
will contain the actual driver. In cases where no driver is loaded, a note
will show indented after driver:

3. For -y 1, driver v: versions will be indented 1, and driver will be a container
that contains that version key: value pair.

Samples:
-----------------------------------
inxi -Razy1
RAID:
  Device-1: g23-home
    type: zfs
    status: ONLINE
    size: 2.69 TiB
    free: 1.26 TiB
    allocated: 1.43 TiB
    Array-1: mirror
      status: ONLINE
      size: 1.82 TiB
      free: 602.00 GiB
      Components:
        online: sdb sdc
    Array-2: mirror
      status: ONLINE
      size: 888.00 GiB
      free: 688.00 GiB
      Components:
        online: sdd sde

-----------------------------------
sudo inxi -dazy1
Drives:
  Local Storage:
    total: 1.98 TiB
    used: 1.43 TiB (72.2%)
  ID-1: /dev/sda
    vendor: Intel
    model: SSDSC2BW180A4
    family: 53x and Pro 1500/2500 Series SSDs
    size: 167.68 GiB
    block size:
    physical: 512 B
    logical: 512 B
    sata: 3.0
    speed: 6.0 Gb/s
    serial: <filter>
    rev: DC32
    temp: 37 C
    scheme: MBR
    SMART: yes
      state: enabled
      health: PASSED
      on: 291d 17h
      cycles: 1346
      read: 431.94 GiB
      written: 666.16 GiB
  Optical-1: /dev/sr0
    vendor: HL-DT-ST
    model: DVDRAM GH20LS10
    rev: FL00
    dev-links: cdrom,cdrw,dvd,dvdrw
    Features:
      speed: 48
      multisession: yes
      audio: yes
      dvd: yes
      rw: cd-r,cd-rw,dvd-r,dvd-ram
      state: running

-----------------------------------
inxi -Aazy1
Audio:
  Device-1: NVIDIA High Definition Audio
    vendor: Gigabyte
    driver: snd_hda_intel
      v: kernel
    bus ID: 09:00.1
    chip ID: 10de:0be3
  Device-2: AMD Family 17h HD Audio
    vendor: Gigabyte
    driver: snd_hda_intel
      v: kernel
    bus ID: 0b:00.3
    chip ID: 1022:1457
  Device-3: N/A
    type: USB
    driver: hid-generic,snd-usb-audio,usbhid
    bus ID: 5-1.3.4:5
    chip ID: 21b4:0083
    serial: <filter>
  Sound Server: ALSA
    v: k5.4.0-11.2-liquorix-amd64
2020-06-12 19:27:04 -07:00
Harald Hope 46ae081ec6 Big change, cleanup, small bug fixes. Hot, grab it now!!
The new -y 1 feature exposed several small and larger glitches with how sets
of data were constructed in inxi output. See Changes: for list of changes made
to improve or fix these glitches.

These errors and minor output inconsistencies became very obvious when I was
doing heavy testing of -y 1, so I decided to just fix all of them at the same
time, plus it was very hard to make the -y 1 indenter work as expected when the
key values were not being treated consistently.

Note that this completes the set of all possible -y results:

Full -y Options:
1. -y [no integer given] :: set width to a default of 80. this is what you usually
want for forum posts, or for online issue reports, because it won't wrap and be
hard to read. Help us help your users and others!! Teach them to use for example
-Fxzy or -bay for their bug reports. Just add y to whatever collection of arguments
you generally ask for in support forums or issue reports. Highly recommended,
easy to type, and joins cleanly with other letters.

2. -y -1 :: removes line width limits, this can lead to very long lines in some
cases, and removes all auto-wrapping of line widths.

3. -y 1 :: Switch to stacked key: value pairs, with primary data blocks separated
by a blank line. Think dmidecode type output, or other command line sys info tools.
By request, a forum support guy noted it was hard for newbies to understand the
-G values, particularly -Ga when in lines, so this is another way to request
data. WARNING: for lots of data, this gets really long!!! But if you are curious
how inxi actually constructs its data internally, this sort of shows it.

4. -y 80-xx :: set width to 80 or greater. Note you can also set these in
your configurations if you want using the various options supported.

-----------------------------------

Bugs:
1. Once again, no real bugs found beyond a few trivial things I can't remember.

Fixes:
1. When out of X, dm: showed after Console: and often said dm: N/A particularly
on headless servers, which was silly. Now DM: only shows after Console: if
a DM: was actually found. If regular Desktop output, either in X, or via
--display out of X, no changes.

2. There was a pointless sudo test when sudo values are set initially, they
were still running even if --no-sudo was used. Now they don't run in that case.

Enhancements:
1. The biggie, now inxi can output in a similar indented way as something like
dmidecode if you use the -y 1 option. This feature was originally by request,
though the initial request actually just wanted to see it stacked simply,
but that was almost impossible to read for any output reasonably long, so
I made the indentations very dynamic and deep, they go up to 4 levels in,
which is roughly how deep in the inxi sub Categories go. This output format
makes it very easy to see how inxi 'thinks' about its data, how it views
sets, subsets, subsubsets, and subsubsubsets of data.

Note that each data block, as with dmidecode data, is separated by a blank
line. You know what this means!!! Yes, that's right!!! You can parse inxi
output with awk!!, same way legacy bash+gawk inxi used to parse its data!!
Or if your brain just does not like lines of data, you can make it appear in
indented single key: value pairs.

Here you can see for example that 1 Xorg Display has 1 or more Screens,
and each Screen has one or more Monitors. Note that this -Ga data first
appeared in inxi 3.1.00.

Sample [with bug in OpenGL output!, and showing -Ga newer values as well
for dual monitor setup, with one Xorg Screen]:

inxi -aGy1
Graphics:
  Device-1: NVIDIA GT218 [GeForce 210]
    vendor: Gigabyte
    driver: nouveau
    v: kernel
    bus ID: 09:00.0
    chip ID: 10de:0a65
  Display: x11
    server: X.Org 1.20.8
    driver: nouveau
    unloaded: fbdev,modesetting,vesa
    display ID: :0.0
    screens: 1
    Screen-1: 0
      s-res: 2560x1024
      s-dpi: 96
      s-size: 677x271mm (26.7x10.7")
      s-diag: 729mm (28.7")
      Monitor-1: DVI-I-0
        res: 1280x1024
        hz: 60
        dpi: 96
        size: 338x270mm (13.3x10.6")
        diag: 433mm (17")
      Monitor-2: VGA-0
        res: 1280x1024
        hz: 60
        dpi: 86
        size: 376x301mm (14.8x11.9")
        diag: 482mm (19")
  OpenGL:
    renderer: N/A
    v: N/A
    direct render: N/A

2. Refactored and cleaned up print_data(), got rid of some early testing code,
dumped some unnecessary tests, simplified old tests, and optimized the new
indentation logic reasonably well. Hopefully the print_data() will not be
quite as much of a black box now as it was.

3. Even more drive vendors and ID matches!!! The list never ends!! An endless
series of new vendors and IDs of existing vendors sprout up, then float away.
And inxi follows them to the best of its ability. Thanks again to Linux-Lite
hardware database, which help make this ever expanding list possible, since
their users appear to use every disk known to humankind.

Changes:
1. When out of Display, and Console: shows, -S will not show dm: if no
display manager is detected, and if it is detected, it shows DM: since it's
not part of the Console: set of data. If out of X and --display is used to
get Xorg data out of X, it will show Desktop: set of data as normal, at least
it will show the stuff it can find. This resolves the issue where dm: appeared
to be a member of the set of Console: data, instead of either its own thing,
DM:, or a member of the set of Desktop: data.

2. For RAID Devices with sub Array-x: values, Array-x: is capitalized, it used
to be array-x: That was silly.

3. In USB, now Device-x: resets inside each Hub: so that the Device-x: are
numbered starting at 1 within each Hub:. This makes the counter behavior act
the same as it does in for example RAM Array-x: / Device-y:, where each Array-x:
resets Device-y: count to 1. This changes the old default of having Device-x:
not reset, to let you see the total number of devices plugged in or attached
no matter which hub they were plugged into, but the output actually gets
sort of confusing in single key: value pair mode per line.

4. The key: value syntax for weather was changed completely, now it works
like the rest of the features, with Report:... [Forecast:...] Locale:...
and Source:. Locale makes the source of the times and other date related
features, and the location if shown or available, much more obvious. Before
it was never clear if Current Time referred to your local or the remote
time, now it's clearly from the Locale: you specified with -W, or
the default -w local info. Also made Report 1 line if unwrapped, Forecast 1
line if not wrapped, and Locale: 1 line if not wrapped, which makes the output
easier to read.

NOTE: automated weather queries are NOT allowed, if you do it, you will be
banned!! inxi is NOT a desktop weather app!! Don't confuse it with one!!
Weather is just a small service to users who might for example want to check
the weather on a remote system, or something like that, and is not intended
to be used on a routine basis.

5. Cleaned up and re-ordered the --version output. It had some pretty old
contexts in the language, which were removed or cleaned up and brought up to
date. If you're wondering, I roughly use rsync and nano --version as guides
for what to show or not show there.
2020-06-12 00:47:10 -07:00
Harald Hope e51ada6bfe forgot a help item 2020-06-01 11:20:33 -07:00
Harald Hope ea2c06f1db fixed copyright year 2020-05-31 14:43:50 -07:00
Harald Hope 7ca58b94d2 New inxi, man. New information types, fixes, man updates.
Bugs:
No bugs of any importance fixed or found!!

Fixes:
1. Tiny fix, didn't use partition/slice assignment in help menu. BSD
interest only since default partition is standard for Linux.

Enhancements:
1. Disc Vendors: added a large number of possible disk vendors, without having
actual detection data available for all of them, using a different source.
Also added, as usual, more disc vendor IDs from linux-lite hardware database,
always ready with more vendors!
2. Added groovy gorilla ID for ubuntu
3. Very nice usability change, mostly for support people, now if -y without
an integer is supplied, it will assign default column width of 80, which
is what you usually want for forums or issue reports, otherwise the output
can wrap outside the post or issue report, which is hard to read. Hopefully
support people will catch onto this one.
4. This closes issue #217 - Adds dmidecode based extra data:
 -xxx - shows CPU voltage and external clock speeds
 -a - shows CPU socket type and base/boost: speed items. These are --admin
 options because neither is particularly reliable, sometimes they are right,
 sometimes they aren't, as usual with dmi data. As far as tests show, base
 speed, what dmidecode misleadingly calls 'Current Speed', which it isn't,
 is the actual normal non throttled speed of the CPU / motherboard setup.
 boost is what dmidecode calls 'Max Speed', which it also isn't, though
 sometimes it is, as with AMD cpus with boost, and no overclocking. With
 overclocking, sometimes base will be higher, sometimes the actual real
 current cpu speeds will be higher than all the max/boost values.
 Motherboard CPU socket type is likewise randomly correct, incorrect, empty,
 misleading, depending on the age and type of the system, and the CPU
 vendor. It appears that in general, AMD CPUs will be more or less right
 if they have this data, and Intel CPUs will sometimes be right, sometimes
 not, or empty. For > 1 CPU systems, the data is much less reliable.
2020-05-31 14:41:20 -07:00
Harald Hope 383aa21b0d forgot to consistently use partition/slice for help. 2020-04-22 22:00:47 -07:00