dmitriy.kazimirov/inxi
1
0
Fork 0
mirror of https://github.com/smxi/inxi.git synced 2024-11-16 16:21:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug fix release. 2 bugs that can impact all users under the right circumstances

Browse source 
were detected and fixed. Thanks manjaro users there for finding and reporting
those. No other changes.

--------------------------------------------------------------------------------
BUGS:

1. Manjaro user ben81 located a critical bug in hardware raid output, this bug
impacts ALL users of hwraid that run inxi with -xx option. Bug was a bad copy
paste, the classic, had updated all the pci type data blocks at once, and hw
raid unfortunately had a slightly different logic due to being part of the more
complex RAID block of logic. Was trying to use an array, not a hash, reference.

Thanks ben81, I would never have spotted this one, and it would impact 100% of
all inxi users with hwraid on their machine who ran inxi with -xx option.

2. Also, ps wwaux parser was spitting out an undefined index error. This is
caused by one of two things:

* ps has an issue, and is apparently at times failing to respect ww, unlimited
line length, and wrapping anyway. This is the likely cause.
* the user terminal for some inexpicable reason has decided to hard wrap long
lines. This is very unlikely, but has to be considered as a possible cause.
Since these commands run in a subshell, this is VERY unlikely.

Workaround this failure by double checking that line split item is defined, if
not, next row. Thanks Carpenter for finding that one.

--------------------------------------------------------------------------------
CODE:

1. Added workarounds for bug 2. Corrected silly copy/paste error for bug 1.
This commit is contained in:
Harald Hope 2021-10-21 12:26:48 -07:00
parent a6c1c46db2
commit 385e91e602
3 changed files with 78 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
inxi
View file

@ -46,8 +46,8 @@ use POSIX qw(ceil uname strftime ttyname);
## INXI INFO ##
my $self_name='inxi';
my $self_version='3.3.07';
my $self_date='2021-10-11';
my $self_version='3.3.08';
my $self_date='2021-10-21';
my $self_patch='00';
## END INXI INFO ##
@ -16004,7 +16004,7 @@ sub hw_output {
$rows[$j]->{main::key($num++,0,2,'bus-ID')} = $bus_id;
}
if ($extra > 1){
my $chip_id = main::get_chip_id($row->[5],$row->[6]);
my $chip_id = main::get_chip_id($row->{'vendor-id'},$row->{'chip-id'});
$rows[$j]->{main::key($num++,0,2,'chip-ID')} = $chip_id;
}
if ($extra > 2){
@ -22441,6 +22441,7 @@ sub lspci_n_data {
my (@data);
if ($fake{'lspci'}){
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/steve-mint-topaz-lspci-n.txt";
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/ben81-hwraid-lspci-n.txt";
# @data = main::reader($file,'strip');
}
else {
@ -22669,6 +22670,7 @@ sub pci_grabber {
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/rk016013-knnv.txt";
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/kot--book-lspci-nnv.txt";
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/steve-mint-topaz-lspci-nnkv.txt";
# my $file = "$ENV{'HOME'}/bin/scripts/inxi/data/lspci/ben81-hwraid-lspci-nnv.txt";
# @data = main::reader($file,'strip');
}
else {
@ -25172,6 +25174,9 @@ sub set_ps_aux {
my $final = $#split;
# some stuff has a lot of data, chrome for example
$final = ($final > ($ps_cols + 2)) ? $ps_cols + 2 : $final;
# handle case of ps wrapping lines despite ww unlimited width, which
# should NOT be happening, but is.
next if !defined $split[$ps_cols];
if ($split[$ps_cols] !~ /^\[/){
push(@ps_cmd,join(' ', @split[$ps_cols .. $final]));
}

2
inxi.1
View file

@ -15,7 +15,7 @@
.\" with this program; if not, write to the Free Software Foundation, Inc.,
.\" 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
.\"
.TH INXI 1 "2021\-10\-11" "inxi" "inxi manual"
.TH INXI 1 "2021\-10\-21" "inxi" "inxi manual"
.SH NAME
inxi \- Command line system information script for console and IRC

69
inxi.changelog
View file

@ -1,3 +1,72 @@
================================================================================
Version: 3.3.08
Patch: 00
Date: 2021-10-21
--------------------------------------------------------------------------------
RELEASE NOTES:
--------------------------------------------------------------------------------
Bug fix release. 2 bugs that can impact all users under the right circumstances
were detected and fixed. Thanks manjaro users there for finding and reporting
those. No other changes.
--------------------------------------------------------------------------------
KNOWN ISSUES:
None.
--------------------------------------------------------------------------------
BUGS:
1. Manjaro user ben81 located a critical bug in hardware raid output, this bug
impacts ALL users of hwraid that run inxi with -xx option. Bug was a bad copy
paste, the classic, had updated all the pci type data blocks at once, and hw
raid unfortunately had a slightly different logic due to being part of the more
complex RAID block of logic. Was trying to use an array, not a hash, reference.
Thanks ben81, I would never have spotted this one, and it would impact 100% of
all inxi users with hwraid on their machine who ran inxi with -xx option.
2. Also, ps wwaux parser was spitting out an undefined index error. This is
caused by one of two things:
* ps has an issue, and is apparently at times failing to respect ww, unlimited
line length, and wrapping anyway. This is the likely cause.
* the user terminal for some inexpicable reason has decided to hard wrap long
lines. This is very unlikely, but has to be considered as a possible cause.
Since these commands run in a subshell, this is VERY unlikely.
Workaround this failure by double checking that line split item is defined, if
not, next row. Thanks Carpenter for finding that one.
--------------------------------------------------------------------------------
FIXES:
None.
--------------------------------------------------------------------------------
ENHANCEMENTS:
None.
--------------------------------------------------------------------------------
CHANGES:
None.
--------------------------------------------------------------------------------
DOCUMENTATION:
None.
--------------------------------------------------------------------------------
CODE:
1. Added workarounds for bug 2. Corrected silly copy/paste error for bug 1.
--------------------------------------------------------------------------------
-- Harald Hope - Mon, 11 Oct 2021 19:08:36 -0700
================================================================================
Version: 3.3.07
Patch: 00